| Message ID | 201109231355.52431.hartleys@visionengravers.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
On Fri 23-09-11 13:55:52, H Hartley Sweeten wrote: > This quites the sparse noise: > > warning: symbol 'ext3_trim_all_free' was not declared. Should it be static? > > Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> > Cc: Jan Kara <jack@suse.cz> > Cc: Andrew Morton <akpm@linux-foundation.org> > Cc: Andreas Dilger <adilger.kernel@dilger.ca> Thanks, merged into my tree. Honza > > --- > > diff --git a/fs/ext3/balloc.c b/fs/ext3/balloc.c > index 6386d76..8e62ec5 100644 > --- a/fs/ext3/balloc.c > +++ b/fs/ext3/balloc.c > @@ -1924,9 +1924,10 @@ unsigned long ext3_bg_num_gdb(struct super_block *sb, int group) > * reaches any used block. Then issue a TRIM command on this extent and free > * the extent in the block bitmap. This is done until whole group is scanned. > */ > -ext3_grpblk_t ext3_trim_all_free(struct super_block *sb, unsigned int group, > - ext3_grpblk_t start, ext3_grpblk_t max, > - ext3_grpblk_t minblocks) > +static ext3_grpblk_t ext3_trim_all_free(struct super_block *sb, > + unsigned int group, > + ext3_grpblk_t start, ext3_grpblk_t max, > + ext3_grpblk_t minblocks) > { > handle_t *handle; > ext3_grpblk_t next, free_blocks, bit, freed, count = 0;
diff --git a/fs/ext3/balloc.c b/fs/ext3/balloc.c index 6386d76..8e62ec5 100644 --- a/fs/ext3/balloc.c +++ b/fs/ext3/balloc.c @@ -1924,9 +1924,10 @@ unsigned long ext3_bg_num_gdb(struct super_block *sb, int group) * reaches any used block. Then issue a TRIM command on this extent and free * the extent in the block bitmap. This is done until whole group is scanned. */ -ext3_grpblk_t ext3_trim_all_free(struct super_block *sb, unsigned int group, - ext3_grpblk_t start, ext3_grpblk_t max, - ext3_grpblk_t minblocks) +static ext3_grpblk_t ext3_trim_all_free(struct super_block *sb, + unsigned int group, + ext3_grpblk_t start, ext3_grpblk_t max, + ext3_grpblk_t minblocks) { handle_t *handle; ext3_grpblk_t next, free_blocks, bit, freed, count = 0;
This quites the sparse noise: warning: symbol 'ext3_trim_all_free' was not declared. Should it be static? Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Cc: Jan Kara <jack@suse.cz> Cc: Andrew Morton <akpm@linux-foundation.org> Cc: Andreas Dilger <adilger.kernel@dilger.ca> --- -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html