From patchwork Sat Jul 30 08:25:57 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Carpenter X-Patchwork-Id: 107484 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 034B8B6F6B for ; Sat, 30 Jul 2011 18:28:03 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751194Ab1G3I2A (ORCPT ); Sat, 30 Jul 2011 04:28:00 -0400 Received: from mail-pz0-f42.google.com ([209.85.210.42]:45317 "EHLO mail-pz0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751187Ab1G3I17 (ORCPT ); Sat, 30 Jul 2011 04:27:59 -0400 Received: by pzk37 with SMTP id 37so7730235pzk.1 for ; Sat, 30 Jul 2011 01:27:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:mime-version:content-type :content-disposition:user-agent; bh=P+gMS8lKF+oiXnPh9lyDaGP35f+mXkP4gLRg3uXEnEA=; b=Qe1H/NQfbjHUqei/XBQ8Rgw8xtgfw6210adCxoK4hUolrUJ7lxM2sZz5csOvSg7XZ4 Ucd4MOcgDR1Z6As/wP5DYu7oirQ8Dju3PgyYQbWAXaWCBxPPWcLQYEdUCoNoyUEFB+vi GaETbv4FtJt/NdVzXfJp+GXf6W+XKDscnjnaU= Received: by 10.68.26.164 with SMTP id m4mr3988955pbg.46.1312014479421; Sat, 30 Jul 2011 01:27:59 -0700 (PDT) Received: from shale.localdomain ([41.139.221.94]) by mx.google.com with ESMTPS id 9sm3015572pbx.34.2011.07.30.01.27.54 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 30 Jul 2011 01:27:58 -0700 (PDT) Date: Sat, 30 Jul 2011 11:25:57 +0300 From: Dan Carpenter To: Theodore Ts'o Cc: Andreas Dilger , "open list:EXT4 FILE SYSTEM" , kernel-janitors@vger.kernel.org Subject: [patch] ext4: add a kfree() on error i add_new_gdb() Message-ID: <20110730082557.GB5575@shale.localdomain> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org We added some more error handling in b40971426a "ext4: add error checking to calls to ext4_handle_dirty_metadata()". But we need to call kfree() as well to avoid a memory leak. Signed-off-by: Dan Carpenter --- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/fs/ext4/resize.c b/fs/ext4/resize.c index 6e3327d..71085df 100644 --- a/fs/ext4/resize.c +++ b/fs/ext4/resize.c @@ -517,6 +517,7 @@ static int add_new_gdb(handle_t *handle, struct inode *inode, return err; exit_inode: + kfree(n_group_desc); /* ext4_handle_release_buffer(handle, iloc.bh); */ brelse(iloc.bh); exit_dindj: