diff mbox series

ext4: Actually request zeroing of inode table after grow

Message ID 155592139208.19009.5887870564232862529.stgit@localhost.localdomain
State Accepted, archived
Headers show
Series ext4: Actually request zeroing of inode table after grow | expand

Commit Message

Kirill Tkhai April 22, 2019, 8:23 a.m. UTC 
It is never possible, that number of block groups decreases,
since only online grow is supported.

But after a growing occured, we have to zero inode tables
for just created new block groups.

Signed-off-by: Kirill Tkhai <ktkhai@virtuozzo.com>
Reviewed-by: Jan Kara <jack@suse.cz>
---
 fs/ext4/ioctl.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Theodore Ts'o April 25, 2019, 5:23 p.m. UTC | #1 
On Mon, Apr 22, 2019 at 11:23:20AM +0300, Kirill Tkhai wrote:
> It is never possible, that number of block groups decreases,
> since only online grow is supported.
> 
> But after a growing occured, we have to zero inode tables
> for just created new block groups.
> 
> Signed-off-by: Kirill Tkhai <ktkhai@virtuozzo.com>
> Reviewed-by: Jan Kara <jack@suse.cz>

Applied, thanks.

				- Ted
diff mbox series

Patch

diff --git a/fs/ext4/ioctl.c b/fs/ext4/ioctl.c
index bab3da4f1e0d..20faa6a69238 100644
--- a/fs/ext4/ioctl.c
+++ b/fs/ext4/ioctl.c
@@ -978,7 +978,7 @@  long ext4_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
 		if (err == 0)
 			err = err2;
 		mnt_drop_write_file(filp);
-		if (!err && (o_group > EXT4_SB(sb)->s_groups_count) &&
+		if (!err && (o_group < EXT4_SB(sb)->s_groups_count) &&
 		    ext4_has_group_desc_csum(sb) &&
 		    test_opt(sb, INIT_INODE_TABLE))
 			err = ext4_register_li_request(sb, o_group);