From patchwork Sun Sep 2 09:45:08 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yongqiang Yang X-Patchwork-Id: 181173 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 4552A2C0079 for ; Sun, 2 Sep 2012 20:21:00 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752231Ab2IBKUe (ORCPT ); Sun, 2 Sep 2012 06:20:34 -0400 Received: from mail-pz0-f46.google.com ([209.85.210.46]:49383 "EHLO mail-pz0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752063Ab2IBKUd (ORCPT ); Sun, 2 Sep 2012 06:20:33 -0400 Received: by dady13 with SMTP id y13so3013380dad.19 for ; Sun, 02 Sep 2012 03:20:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer; bh=Rhfe0EC4nvOByNtpQxoRBA7yQfiWogPY75Zi67YdATI=; b=z2x1bN7Oo7EIjIbm+2Yf9mXdEdujUHZ+u6tNpL/Sm/8jkGU9gG//25vjMUyggqT+wE 5PVLD/nSdzy7Rup1lQ/tJ4MVOkJC2J8oWmU95B/R5Xj1/SbMzxcM7oM8FGTEKzS2Dezy HdMlFjv+Te+hDICaafRBWe/s6e55Ew7xnFHudgscjURHIqnFqhPXxJ2jXPUM/wqENkIP 02pI4Wv0WVmzdrALFSEIQ+hucbKVmPXN5MguN631/mrkQ9Kv40K30lB3q1nKLlrNP9Di fMrGnrLn1oEuEvVHf6RJV4jyClqqdN3wy9TCvXEjCyUB+4FP5EIx+LUv3dWmrwBFtTXY TQfw== Received: by 10.68.200.227 with SMTP id jv3mr29617453pbc.162.1346581233123; Sun, 02 Sep 2012 03:20:33 -0700 (PDT) Received: from localhost.localdomain ([106.3.102.60]) by mx.google.com with ESMTPS id to6sm7490193pbc.12.2012.09.02.03.20.29 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 02 Sep 2012 03:20:32 -0700 (PDT) From: Yongqiang Yang To: linux-ext4@vger.kernel.org Cc: tytso@mit.edu, Yongqiang Yang Subject: [PATCH 1/2] ext4: check free block counters in ext4_mb_find_by_goal Date: Sun, 2 Sep 2012 17:45:08 +0800 Message-Id: <1346579109-25016-1-git-send-email-xiaoqiangnk@gmail.com> X-Mailer: git-send-email 1.7.5.1 Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org Free block counters should be checked before doing allocation. Signed-off-by: Yongqiang Yang --- fs/ext4/mballoc.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c index 6873571..5d4c21a 100644 --- a/fs/ext4/mballoc.c +++ b/fs/ext4/mballoc.c @@ -1659,10 +1659,13 @@ int ext4_mb_find_by_goal(struct ext4_allocation_context *ac, int max; int err; struct ext4_sb_info *sbi = EXT4_SB(ac->ac_sb); + struct ext4_group_info *grp = ext4_get_group_info(ac->ac_sb, group); struct ext4_free_extent ex; if (!(ac->ac_flags & EXT4_MB_HINT_TRY_GOAL)) return 0; + if (grp->bb_free == 0) + return 0; err = ext4_mb_load_buddy(ac->ac_sb, group, e4b); if (err)