Message ID | 1338779898-3146-1-git-send-email-tm@tao.ma |
---|---|
State | Accepted, archived |
Headers | show |
On Mon, Jun 04, 2012 at 11:18:18AM +0800, Tao Ma wrote: > From: Tao Ma <boyu.mt@taobao.com> > > 7990696 uses the ext4_{set,clear}_inode_flags() functions to change > the i_flags automatically but fails to remove the error setting of > i_flags. So we still have the problem of trashing state flags. So > remove it. > > Cc: "Theodore Ts'o" <tytso@mit.edu> > Signed-off-by: Tao Ma <boyu.mt@taobao.com> Good catch! Sorry that I missed it. I've taken this patch, thanks. - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/fs/ext4/ioctl.c b/fs/ext4/ioctl.c index 8ad112a..e34deac 100644 --- a/fs/ext4/ioctl.c +++ b/fs/ext4/ioctl.c @@ -123,7 +123,6 @@ long ext4_ioctl(struct file *filp, unsigned int cmd, unsigned long arg) else ext4_clear_inode_flag(inode, i); } - ei->i_flags = flags; ext4_set_inode_flags(inode); inode->i_ctime = ext4_current_time(inode);