From patchwork Fri Dec 21 19:24:58 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Lutomirski X-Patchwork-Id: 207872 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 609902C008E for ; Sat, 22 Dec 2012 06:25:33 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751968Ab2LUTZP (ORCPT ); Fri, 21 Dec 2012 14:25:15 -0500 Received: from mail-pb0-f44.google.com ([209.85.160.44]:38678 "EHLO mail-pb0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751293Ab2LUTZO (ORCPT ); Fri, 21 Dec 2012 14:25:14 -0500 Received: by mail-pb0-f44.google.com with SMTP id uo1so2904014pbc.3 for ; Fri, 21 Dec 2012 11:25:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:from:to:cc:subject:date:message-id:x-mailer :x-gm-message-state; bh=zloOMZHIky/Sz34f4bVgHFxj+fnb6IXt6ISoCSt89bI=; b=Pebq91G6eGMtukxlx16R5ZXMucBIIh2XxVPn5G3ctXVmwuik9Ev93SVdDaT9z1eql5 kf5bWt9Y5Sc1jqHJq5XjcCXrFmgklfXFF5P+Pnb1vNMPkx3w2U3GSQVtju3xE7LY2dNk stlMyaGYL56XiNiB6VHywWucV1PquwTw+PIOkbY2UTNamvDz18j9PYwjvqcZvNlG+6iI 3F1GOihhDriCrWOOhVFqigYGTU5g1oDcnfVGTkywHVc1uGdZEhltzAM9LOQ1PrPlEBm/ 9dyeztymGYAa1rUfNxCfwHgycEyVNa6H0p87YWfjnOPW4NftxiKZq90WLH5SJffq0ANF 2iEw== X-Received: by 10.68.137.167 with SMTP id qj7mr42004128pbb.148.1356117914120; Fri, 21 Dec 2012 11:25:14 -0800 (PST) Received: from localhost (50-76-60-73-ip-static.hfc.comcastbusiness.net. [50.76.60.73]) by mx.google.com with ESMTPS id sk1sm7453482pbc.0.2012.12.21.11.25.12 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 21 Dec 2012 11:25:13 -0800 (PST) From: Andy Lutomirski To: Theodore Ts'o Cc: Jan Kara , linux-kernel@vger.kernel.org, linux-ext4@vger.kernel.org, Andy Lutomirski Subject: [PATCH] ext4: Fix an incorrect comment about i_mutex Date: Fri, 21 Dec 2012 11:24:58 -0800 Message-Id: <1323a2735a9106cf0fa1a6ffee938ce432aa085d.1356117764.git.luto@amacapital.net> X-Mailer: git-send-email 1.7.11.7 X-Gm-Message-State: ALoCoQmVrZSDqXhtQM7c4xf79u2+cnfncg/w2waGxCB00Mh/5bdE7obolsTK2rKoV7S7mxxywNwu Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org i_mutex is not held when ->sync_file is called. Reviewed-by: Jan Kara Signed-off-by: Andy Lutomirski --- fs/ext4/fsync.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/ext4/fsync.c b/fs/ext4/fsync.c index be1d89f..8c15642 100644 --- a/fs/ext4/fsync.c +++ b/fs/ext4/fsync.c @@ -113,8 +113,6 @@ static int __sync_inode(struct inode *inode, int datasync) * * What we do is just kick off a commit and wait on it. This will snapshot the * inode to disk. - * - * i_mutex lock is held when entering and exiting this function */ int ext4_sync_file(struct file *file, loff_t start, loff_t end, int datasync)