From patchwork Fri Aug 30 07:37:50 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhang Yi X-Patchwork-Id: 1978780 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=ozlabs.org (client-ip=150.107.74.76; helo=mail.ozlabs.org; envelope-from=srs0=j676=p5=vger.kernel.org=linux-ext4+bounces-3982-patchwork-incoming=ozlabs.org@ozlabs.org; receiver=patchwork.ozlabs.org) Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Ww95s2sfvz1yZ9 for ; Fri, 30 Aug 2024 17:39:45 +1000 (AEST) Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by gandalf.ozlabs.org (Postfix) with ESMTP id 4Ww95s16HGz4wbv for ; Fri, 30 Aug 2024 17:39:45 +1000 (AEST) Received: by gandalf.ozlabs.org (Postfix) id 4Ww95s14Dhz4wj2; Fri, 30 Aug 2024 17:39:45 +1000 (AEST) Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: gandalf.ozlabs.org; dmarc=none (p=none dis=none) header.from=huaweicloud.com Authentication-Results: gandalf.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=2604:1380:45e3:2400::1; helo=sv.mirrors.kernel.org; envelope-from=linux-ext4+bounces-3982-patchwork-incoming=ozlabs.org@vger.kernel.org; receiver=ozlabs.org) Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org [IPv6:2604:1380:45e3:2400::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by gandalf.ozlabs.org (Postfix) with ESMTPS id 4Ww95r26tGz4wbv for ; Fri, 30 Aug 2024 17:39:44 +1000 (AEST) Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 0B68B281807 for ; Fri, 30 Aug 2024 07:39:43 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8FF061586CD; Fri, 30 Aug 2024 07:39:36 +0000 (UTC) X-Original-To: linux-ext4@vger.kernel.org Received: from dggsgout11.his.huawei.com (dggsgout11.his.huawei.com [45.249.212.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 696687F6; Fri, 30 Aug 2024 07:39:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725003576; cv=none; b=B+w1g3xAXWCc4XKX6m6hHNoHsM1PUmCAB2EAJiYiRSc16802J5Az1eqIGh4bDttf5UFFF6Y+P3OnP75SNfrMKIQH8CbQC65s3PaHIu6YMkriJhdZyWTsbDNJ7YITzB3KDwxSF+aIbAHY7Cw3KqfTrOGaclfHVY7vT1xLwTeBdDc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725003576; c=relaxed/simple; bh=FYRO+/sCjJwbslfJ6rTDTpYUYD1ku482mD5uWo2qrM8=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=Nj6BT6p8KZwOTVH2G8W8Q1iSMcnWO3yPDc0/L3UFuI2/hYJZatL6nrP+9ExAifcbZ+ZGLoh/TaGiyyrPSYIUj2xDpjIJvuVlEWuZgpjIn1+8GbR/qlHkbqR8luFMMYXwVUgsx4aKc5KKY0VboKC9+Wbxtf+ERYaY9lEtb1ToG4M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=huaweicloud.com; spf=pass smtp.mailfrom=huaweicloud.com; arc=none smtp.client-ip=45.249.212.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=huaweicloud.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huaweicloud.com Received: from mail.maildlp.com (unknown [172.19.93.142]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4Ww95G4gnqz4f3lD4; Fri, 30 Aug 2024 15:39:14 +0800 (CST) Received: from mail02.huawei.com (unknown [10.116.40.128]) by mail.maildlp.com (Postfix) with ESMTP id 390DC1A018D; Fri, 30 Aug 2024 15:39:30 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.104.67]) by APP4 (Coremail) with SMTP id gCh0CgCHr4Uhd9FmXb5_DA--.51707S4; Fri, 30 Aug 2024 15:39:30 +0800 (CST) From: Zhang Yi To: linux-ext4@vger.kernel.org Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, tytso@mit.edu, adilger.kernel@dilger.ca, jack@suse.cz, ritesh.list@gmail.com, yi.zhang@huawei.com, yi.zhang@huaweicloud.com, chengzhihao1@huawei.com, yukuai3@huawei.com Subject: [PATCH 00/10] ext4: clean up and refactor fallocate Date: Fri, 30 Aug 2024 15:37:50 +0800 Message-Id: <20240830073800.2131781-1-yi.zhang@huaweicloud.com> X-Mailer: git-send-email 2.39.2 Precedence: bulk X-Mailing-List: linux-ext4@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-CM-TRANSID: gCh0CgCHr4Uhd9FmXb5_DA--.51707S4 X-Coremail-Antispam: 1UD129KBjvJXoW7Kw4Dtry7KFW7Cr4xtF1UJrb_yoW8WFWDpF WfKw1Sqr4UK3srurs3Zw4xXF4xKw4rAr47JFWIga1vgrn5ur109F43Ka40kFWxJFWfJa47 XF4jvrnru3Wjka7anT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUU9Y14x267AKxVW8JVW5JwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK02 1l84ACjcxK6xIIjxv20xvE14v26w1j6s0DM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26r4U JVWxJr1l84ACjcxK6I8E87Iv67AKxVW0oVCq3wA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_Gc CE3s1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx0E 2Ix0cI8IcVAFwI0_JrI_JrylYx0Ex4A2jsIE14v26r1j6r4UMcvjeVCFs4IE7xkEbVWUJV W8JwACjcxG0xvY0x0EwIxGrwACjI8F5VA0II8E6IAqYI8I648v4I1lFIxGxcIEc7CjxVA2 Y2ka0xkIwI1lc7CjxVAaw2AFwI0_Jw0_GFyl42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x 0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67AKxVWUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2 zVAF1VAY17CE14v26r1q6r43MIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF 4lIxAIcVC0I7IYx2IY6xkF7I0E14v26r4j6F4UMIIF0xvE42xK8VAvwI8IcIk0rVWUJVWU CwCI42IY6I8E87Iv67AKxVWUJVW8JwCI42IY6I8E87Iv6xkF7I0E14v26r4j6r4UJbIYCT nIWIevJa73UjIFyTuYvjfUFg4SDUUUU X-CM-SenderInfo: d1lo6xhdqjqx5xdzvxpfor3voofrz/ From: Zhang Yi Hello! Current ext4 fallocate code is mess with mode checking, locking, input parameter checking, position calculation, and having some stale code. Almost all of the five sub-functions have the same preparation, it deserve a clean up now. This series tries to clean this up by refactor all fallocate related operations, it unifiy variable naming, reduce some unnecessary position calculation, factor out one common helper to check input parameters, and also foctor out one common helper to wait for the dios to finish, hold filemap invalidate lock, write back dirty data and drop page cache. The first patch fix a potential data loss problem when punch hole, zero range and collapse range by always write back dirty pages. Later patchs do cleanup and refactor work, please see them for details. After this series, we can reduce a lot of redundant code and make it more clear than before. Thanks, Yi. Zhang Yi (10): ext4: write out dirty data before dropping pages ext4: don't explicit update times in ext4_fallocate() ext4: drop ext4_update_disksize_before_punch() ext4: refactor ext4_zero_range() ext4: refactor ext4_punch_hole() ext4: refactor ext4_collapse_range() ext4: refactor ext4_insert_range() ext4: factor out ext4_do_fallocate() ext4: factor out the common checking part of all fallocate operations ext4: factor out a common helper to lock and flush data before fallocate fs/ext4/ext4.h | 5 +- fs/ext4/extents.c | 566 +++++++++++++++++++--------------------------- fs/ext4/inode.c | 173 ++++---------- 3 files changed, 278 insertions(+), 466 deletions(-)