mbox series

[v3,00/12] ext4: simplify the counting and management of delalloc reserved blocks

Message ID 20240813123452.2824659-1-yi.zhang@huaweicloud.com
Headers show
Series ext4: simplify the counting and management of delalloc reserved blocks | expand

Message

Zhang Yi Aug. 13, 2024, 12:34 p.m. UTC
From: Zhang Yi <yi.zhang@huawei.com>

Changes since v2:
 - In patch 3, update the chang log as Jan suggested.
 - In patch 5 and 6, when moving reserved blocks count updating to
   ext4_es_insert_extent(), chang the condition for determining quota
   claim by passing allocation information instead of counting used
   reserved blocks as Jan suggested.
 - Add patch 9, drop an unused helper ext4_es_store_status().
 - Add patch 10, make extent status type exclusive, add assertion and
   commtents as Jan suggested.

Changes since v1:
 - Just rebase to v6.11-rc1.

This patch series is the part 3 prepartory changes of the buffered IO
iomap conversion, it simplify the counting and updating logic of
delalloc reserved blocks. I picked them out from my buffered IO iomap
conversion RFC series v4[1], and did some minor improvements of commit
messages. This series is based on 6.11-rc3, after it we could save a lot
of code.

Patch 1-3 simplify the delalloc extent management logic by changes to
always set EXT4_GET_BLOCKS_DELALLOC_RESERVE flag when allocating
preallocated blocks, and don't add EXTENT_STATUS_DELAYED flag to an
unwritten extent, which means ext4_es_is_delayed() is equal to
ext4_es_is_delonly().

Patch 4-6 simplify the reserved blocks updating logic by moves the
reserved blocks updating from ext4_{ind|ext}_map_blocks() to
ext4_es_insert_extent().

Patch 7-12 make extent status type exclusive and drop the unused code
(e.g. ext4_es_is_delonly()), update comments and do some cleanup.

[1] https://lore.kernel.org/linux-ext4/20240410142948.2817554-1-yi.zhang@huaweicloud.com/

Thanks,
Yi.

Zhang Yi (12):
  ext4: factor out ext4_map_create_blocks() to allocate new blocks
  ext4: optimize the EXT4_GET_BLOCKS_DELALLOC_RESERVE flag set
  ext4: don't set EXTENT_STATUS_DELAYED on allocated blocks
  ext4: let __revise_pending() return newly inserted pendings
  ext4: passing block allocation information to ext4_es_insert_extent()
  ext4: update delalloc data reserve spcae in ext4_es_insert_extent()
  ext4: drop ext4_es_delayed_clu()
  ext4: use ext4_map_query_blocks() in ext4_map_blocks()
  ext4: drop unused ext4_es_store_status()
  ext4: make extent status types exclusive
  ext4: drop ext4_es_is_delonly()
  ext4: drop all delonly descriptions

 fs/ext4/extents.c        |  42 +------
 fs/ext4/extents_status.c | 240 ++++++++++++++-------------------------
 fs/ext4/extents_status.h |  28 ++---
 fs/ext4/indirect.c       |   7 --
 fs/ext4/inode.c          | 201 ++++++++++++++------------------
 5 files changed, 189 insertions(+), 329 deletions(-)

Comments

Theodore Ts'o Sept. 5, 2024, 2:53 p.m. UTC | #1
On Tue, 13 Aug 2024 20:34:40 +0800, Zhang Yi wrote:
> Changes since v2:
>  - In patch 3, update the chang log as Jan suggested.
>  - In patch 5 and 6, when moving reserved blocks count updating to
>    ext4_es_insert_extent(), chang the condition for determining quota
>    claim by passing allocation information instead of counting used
>    reserved blocks as Jan suggested.
>  - Add patch 9, drop an unused helper ext4_es_store_status().
>  - Add patch 10, make extent status type exclusive, add assertion and
>    commtents as Jan suggested.
> 
> [...]

Applied, thanks!

[01/12] ext4: factor out ext4_map_create_blocks() to allocate new blocks
        commit: 130078d020e0214809f2e13cf4fb80c646020e94
[02/12] ext4: optimize the EXT4_GET_BLOCKS_DELALLOC_RESERVE flag set
        commit: 8b8252884f2ff4d28e3ce1a825057b3ad2900c35
[03/12] ext4: don't set EXTENT_STATUS_DELAYED on allocated blocks
        commit: eba8c368c8cb9ea05c08caf3dd1a0d0b87d614dc
[04/12] ext4: let __revise_pending() return newly inserted pendings
        commit: fccd632670408ab3066712aa90cc972b18d1b617
[05/12] ext4: passing block allocation information to ext4_es_insert_extent()
        commit: f3baf33b9cae0e00fe1870abca952d5dfea53dc6
[06/12] ext4: update delalloc data reserve spcae in ext4_es_insert_extent()
        commit: c543e2429640293d9eda8c7841d4b5d5e8682826
[07/12] ext4: drop ext4_es_delayed_clu()
        commit: 6e124d5b4b02229f8aaa206b1952db31d1687523
[08/12] ext4: use ext4_map_query_blocks() in ext4_map_blocks()
        commit: 15996a848564e40a3d030ec7e4603dddb9f425b6
[09/12] ext4: drop unused ext4_es_store_status()
        commit: 3b4ba269ab6673d664d2522a0e76797a3550983f
[10/12] ext4: make extent status types exclusive
        commit: ce09036ea4f0a54e9dcd7ba644bb1db7cf2d95d4
[11/12] ext4: drop ext4_es_is_delonly()
        commit: b224b18497484eef9d2dbb3c803888a3f3a3475e
[12/12] ext4: drop all delonly descriptions
        commit: 2046657e64a11b61d5ed07e0d60befd86303125e

Best regards,