| Message ID | 20240715-mgtime-v6-0-48e5d34bd2ba@kernel.org |
|---|---|
| Headers | show |
| Series | fs: multigrain timestamp redux | expand |
On Mon, Jul 15, 2024 at 08:48:51AM GMT, Jeff Layton wrote: > I think this is pretty much ready for linux-next now. Since the latest > changes are pretty minimal, I've left the Reviewed-by's intact. It would > be nice to have acks or reviews from maintainers for ext4 and tmpfs too. > > I did try to plumb this into bcachefs too, but the way it handles > timestamps makes that pretty difficult. It keeps the active copies in an > internal representation of the on-disk inode and periodically copies > them to struct inode. This is backward from the way most blockdev > filesystems do this. > > Christian, would you be willing to pick these up with an eye toward > v6.12 after the merge window settles? Yup. About to queue it up. I'll try to find some time to go through it so I might have some replies later but that shouldn't hold up linux-next at all.
On Tue, 2024-07-16 at 09:37 +0200, Christian Brauner wrote: > On Mon, Jul 15, 2024 at 08:48:51AM GMT, Jeff Layton wrote: > > I think this is pretty much ready for linux-next now. Since the latest > > changes are pretty minimal, I've left the Reviewed-by's intact. It would > > be nice to have acks or reviews from maintainers for ext4 and tmpfs too. > > > > I did try to plumb this into bcachefs too, but the way it handles > > timestamps makes that pretty difficult. It keeps the active copies in an > > internal representation of the on-disk inode and periodically copies > > them to struct inode. This is backward from the way most blockdev > > filesystems do this. > > > > Christian, would you be willing to pick these up with an eye toward > > v6.12 after the merge window settles? > > Yup. About to queue it up. I'll try to find some time to go through it > so I might have some replies later but that shouldn't hold up linux-next > at all. Great! There is one minor update to the percpu counter patch to compile those out when debugfs isn't enabled, so it may be best to pick the series from the "mgtime" branch in my public git tree. Let me know if you'd rather I re-post the series though. Thanks!
On Tue, Jul 16, 2024 at 08:45:16AM GMT, Jeff Layton wrote: > On Tue, 2024-07-16 at 09:37 +0200, Christian Brauner wrote: > > On Mon, Jul 15, 2024 at 08:48:51AM GMT, Jeff Layton wrote: > > > I think this is pretty much ready for linux-next now. Since the latest > > > changes are pretty minimal, I've left the Reviewed-by's intact. It would > > > be nice to have acks or reviews from maintainers for ext4 and tmpfs too. > > > > > > I did try to plumb this into bcachefs too, but the way it handles > > > timestamps makes that pretty difficult. It keeps the active copies in an > > > internal representation of the on-disk inode and periodically copies > > > them to struct inode. This is backward from the way most blockdev > > > filesystems do this. > > > > > > Christian, would you be willing to pick these up with an eye toward > > > v6.12 after the merge window settles? > > > > Yup. About to queue it up. I'll try to find some time to go through it > > so I might have some replies later but that shouldn't hold up linux-next > > at all. > > Great! > > There is one minor update to the percpu counter patch to compile those > out when debugfs isn't enabled, so it may be best to pick the series > from the "mgtime" branch in my public git tree. Let me know if you'd I did that now and pushed to vfs.mgtime. Please take a look as I rebased onto current master and resolved conflicts in xfs and btrfs. Thanks!
I think this is pretty much ready for linux-next now. Since the latest changes are pretty minimal, I've left the Reviewed-by's intact. It would be nice to have acks or reviews from maintainers for ext4 and tmpfs too. I did try to plumb this into bcachefs too, but the way it handles timestamps makes that pretty difficult. It keeps the active copies in an internal representation of the on-disk inode and periodically copies them to struct inode. This is backward from the way most blockdev filesystems do this. Christian, would you be willing to pick these up with an eye toward v6.12 after the merge window settles? Thanks! Signed-off-by: Jeff Layton <jlayton@kernel.org> --- Changes in v6: - Normalize timespec64 in inode_set_ctime_to_ts - use DEFINE_PER_CPU counters for better vfs consistency - skip ctime cmpxchg if the result means nothing will change - add trace_ctime_xchg_skip to track skipped ctime updates - use __print_flags in ctime_ns_xchg tracepoint - Link to v5: https://lore.kernel.org/r/20240711-mgtime-v5-0-37bb5b465feb@kernel.org Changes in v5: - refetch coarse time in coarse_ctime if not returning floor - timestamp_truncate before swapping new ctime value into place - track floor value as atomic64_t - cleanups to Documentation file - Link to v4: https://lore.kernel.org/r/20240708-mgtime-v4-0-a0f3c6fb57f3@kernel.org Changes in v4: - reordered tracepoint fields for better packing - rework percpu counters again to also count fine grained timestamps - switch to try_cmpxchg for better efficiency - Link to v3: https://lore.kernel.org/r/20240705-mgtime-v3-0-85b2daa9b335@kernel.org Changes in v3: - Drop the conversion of i_ctime fields to ktime_t, and use an unused bit of the i_ctime_nsec field as QUERIED flag. - Better tracepoints for tracking floor and ctime updates - Reworked percpu counters to be more useful - Track floor as monotonic value, which eliminates clock-jump problem Changes in v2: - Added Documentation file - Link to v1: https://lore.kernel.org/r/20240626-mgtime-v1-0-a189352d0f8f@kernel.org --- Jeff Layton (9): fs: add infrastructure for multigrain timestamps fs: tracepoints around multigrain timestamp events fs: add percpu counters for significant multigrain timestamp events fs: have setattr_copy handle multigrain timestamps appropriately Documentation: add a new file documenting multigrain timestamps xfs: switch to multigrain timestamps ext4: switch to multigrain timestamps btrfs: convert to multigrain timestamps tmpfs: add support for multigrain timestamps Documentation/filesystems/multigrain-ts.rst | 120 +++++++++++++ fs/attr.c | 52 +++++- fs/btrfs/file.c | 25 +-- fs/btrfs/super.c | 3 +- fs/ext4/super.c | 2 +- fs/inode.c | 251 +++++++++++++++++++++++++--- fs/stat.c | 39 ++++- fs/xfs/libxfs/xfs_trans_inode.c | 6 +- fs/xfs/xfs_iops.c | 10 +- fs/xfs/xfs_super.c | 2 +- include/linux/fs.h | 34 +++- include/trace/events/timestamp.h | 124 ++++++++++++++ mm/shmem.c | 2 +- 13 files changed, 592 insertions(+), 78 deletions(-) --- base-commit: bb83a76c647a96db4c9ae77b0577170da4d7bd77 change-id: 20240626-mgtime-5cd80b18d810 Best regards,