| Message ID | CAKYAXd_2diW78c1kCehQ3suGyOC6Zj_3fn=A=_GzFAbL8D4nQw@mail.gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | ksmbd: fix wrong name of SMB2_CREATE_ALLOCATION_SIZE | expand |
Namjae Jeon <linkinjeon@kernel.org> writes: > MS confirm that "AISi" name of SMB2_CREATE_ALLOCATION_SIZE in MS-SMB2 > specification is a typo. cifs/ksmbd have been using this wrong name from > MS-SMB2. It should be "AlSi". Also It will cause problem when running > smb2.create.open test in smbtorture against ksmbd. I see only ksmbd using it. > Cc: stable@vger.kernel.org > Fixes: 12197a7fdda9 ("Clarify SMB2/SMB3 create context and add missing ones") > Signed-off-by: Namjae Jeon <linkinjeon@kernel.org> > --- > fs/smb/common/smb2pdu.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Looks good, Reviewed-by: Paulo Alcantara (SUSE) <pc@manguebit.com>
diff --git a/fs/smb/common/smb2pdu.h b/fs/smb/common/smb2pdu.h index e373018259e5..5a721c952c2f 100644 --- a/fs/smb/common/smb2pdu.h +++ b/fs/smb/common/smb2pdu.h @@ -1142,7 +1142,7 @@ struct smb2_server_client_notification { #define SMB2_CREATE_SD_BUFFER "SecD" /* security descriptor */ #define SMB2_CREATE_DURABLE_HANDLE_REQUEST "DHnQ" #define SMB2_CREATE_DURABLE_HANDLE_RECONNECT "DHnC" -#define SMB2_CREATE_ALLOCATION_SIZE "AISi" +#define SMB2_CREATE_ALLOCATION_SIZE "AlSi" #define SMB2_CREATE_QUERY_MAXIMAL_ACCESS_REQUEST "MxAc" #define SMB2_CREATE_TIMEWARP_REQUEST "TWrp" #define SMB2_CREATE_QUERY_ON_DISK_ID "QFid"
MS confirm that "AISi" name of SMB2_CREATE_ALLOCATION_SIZE in MS-SMB2 specification is a typo. cifs/ksmbd have been using this wrong name from MS-SMB2. It should be "AlSi". Also It will cause problem when running smb2.create.open test in smbtorture against ksmbd. Cc: stable@vger.kernel.org Fixes: 12197a7fdda9 ("Clarify SMB2/SMB3 create context and add missing ones") Signed-off-by: Namjae Jeon <linkinjeon@kernel.org> --- fs/smb/common/smb2pdu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)