| Message ID | CAH2r5mvM6a4dU3d7Mxer9jWP0xkA2hyF9PrkwreES5T11W9O9w@mail.gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | new SMB3.1.1 create contexts | expand |
patch attached to add the four missing create context IDs to the kernel On Sat, Oct 1, 2022 at 6:50 PM Steve French <smfrench@gmail.com> wrote: > > Noticed a few SMB3.1.1 create contexts missing from the Linux kernel > code. Any more beyond these four that are still missing? > > diff --git a/fs/smbfs_common/smb2pdu.h b/fs/smbfs_common/smb2pdu.h > index 2cab413fffee..7d605db3bb3b 100644 > --- a/fs/smbfs_common/smb2pdu.h > +++ b/fs/smbfs_common/smb2pdu.h > @@ -1101,7 +1101,11 @@ struct smb2_change_notify_rsp { > #define SMB2_CREATE_REQUEST_LEASE "RqLs" > #define SMB2_CREATE_DURABLE_HANDLE_REQUEST_V2 "DH2Q" > #define SMB2_CREATE_DURABLE_HANDLE_RECONNECT_V2 "DH2C" > -#define SMB2_CREATE_TAG_POSIX > "\x93\xAD\x25\x50\x9C\xB4\x11\xE7\xB4\x23\x83\xDE\x96\x8B\xCD\x7C" > +#define SMB2_CREATE_TAG_POSIX > "\x93\xAD\x25\x50\x9C\xB4\x11\xE7\xB4\x23\x83\xDE\x96\x8B\xCD\x7C" > +#define SMB2_CREATE_APP_INSTANCE_ID > "\x45\xBC\xA6\x6A\xEF\xA7\xF7\x4A\x90\x08\xFA\x46\x2E\x14\x4D\x74" > +#define SMB2_CREATE_APP_INSTANCE_VERSION > "\xB9\x82\xD0\xB7\x3B\x56\x07\x4F\xA0\x7B\x52\x4A\x81\x16\xA0\x10" > +#define SVHDX_OPEN_DEVICE_CONTEXT > "\x9C\xCB\xCF\x9E\x04\xC1\xE6\x43\x98\x0E\x15\x8D\xA1\xF6\xEC\x83" > +#define SMB2_CREATE_TAG_AAPL "AAPL" > > > -- > Thanks, > > Steve
On 10/2/2022 12:01 AM, Steve French wrote: > patch attached to add the four missing create context IDs to the kernel These don't seem very important, to me. The APP_INSTANCE ones are about clustered clients where VMs may want to migrate around the cluster and not lose their VHDs. The OPEN_DEVICE_CONTEXT is about MS-RSVD. Neither of these are in Linux? The AAPL one is all about MacOS behaviors. If this is being added, it needs additional documentation of the parameter block, no? Tom. > On Sat, Oct 1, 2022 at 6:50 PM Steve French <smfrench@gmail.com> wrote: >> >> Noticed a few SMB3.1.1 create contexts missing from the Linux kernel >> code. Any more beyond these four that are still missing? >> >> diff --git a/fs/smbfs_common/smb2pdu.h b/fs/smbfs_common/smb2pdu.h >> index 2cab413fffee..7d605db3bb3b 100644 >> --- a/fs/smbfs_common/smb2pdu.h >> +++ b/fs/smbfs_common/smb2pdu.h >> @@ -1101,7 +1101,11 @@ struct smb2_change_notify_rsp { >> #define SMB2_CREATE_REQUEST_LEASE "RqLs" >> #define SMB2_CREATE_DURABLE_HANDLE_REQUEST_V2 "DH2Q" >> #define SMB2_CREATE_DURABLE_HANDLE_RECONNECT_V2 "DH2C" >> -#define SMB2_CREATE_TAG_POSIX >> "\x93\xAD\x25\x50\x9C\xB4\x11\xE7\xB4\x23\x83\xDE\x96\x8B\xCD\x7C" >> +#define SMB2_CREATE_TAG_POSIX >> "\x93\xAD\x25\x50\x9C\xB4\x11\xE7\xB4\x23\x83\xDE\x96\x8B\xCD\x7C" >> +#define SMB2_CREATE_APP_INSTANCE_ID >> "\x45\xBC\xA6\x6A\xEF\xA7\xF7\x4A\x90\x08\xFA\x46\x2E\x14\x4D\x74" >> +#define SMB2_CREATE_APP_INSTANCE_VERSION >> "\xB9\x82\xD0\xB7\x3B\x56\x07\x4F\xA0\x7B\x52\x4A\x81\x16\xA0\x10" >> +#define SVHDX_OPEN_DEVICE_CONTEXT >> "\x9C\xCB\xCF\x9E\x04\xC1\xE6\x43\x98\x0E\x15\x8D\xA1\xF6\xEC\x83" >> +#define SMB2_CREATE_TAG_AAPL "AAPL" >> >> >> -- >> Thanks, >> >> Steve > > >
diff --git a/fs/smbfs_common/smb2pdu.h b/fs/smbfs_common/smb2pdu.h index 2cab413fffee..7d605db3bb3b 100644 --- a/fs/smbfs_common/smb2pdu.h +++ b/fs/smbfs_common/smb2pdu.h @@ -1101,7 +1101,11 @@ struct smb2_change_notify_rsp { #define SMB2_CREATE_REQUEST_LEASE "RqLs" #define SMB2_CREATE_DURABLE_HANDLE_REQUEST_V2 "DH2Q" #define SMB2_CREATE_DURABLE_HANDLE_RECONNECT_V2 "DH2C" -#define SMB2_CREATE_TAG_POSIX "\x93\xAD\x25\x50\x9C\xB4\x11\xE7\xB4\x23\x83\xDE\x96\x8B\xCD\x7C" +#define SMB2_CREATE_TAG_POSIX "\x93\xAD\x25\x50\x9C\xB4\x11\xE7\xB4\x23\x83\xDE\x96\x8B\xCD\x7C" +#define SMB2_CREATE_APP_INSTANCE_ID "\x45\xBC\xA6\x6A\xEF\xA7\xF7\x4A\x90\x08\xFA\x46\x2E\x14\x4D\x74" +#define SMB2_CREATE_APP_INSTANCE_VERSION "\xB9\x82\xD0\xB7\x3B\x56\x07\x4F\xA0\x7B\x52\x4A\x81\x16\xA0\x10" +#define SVHDX_OPEN_DEVICE_CONTEXT