diff mbox series

cifs: cifs_md4 convert to SPDX identifier

Message ID CAH2r5mu-QRnkdaB=nNVY2Q3Dhb5vgnk4n0XnMADMWkEGbtchFw@mail.gmail.com
State New
Headers show
Series cifs: cifs_md4 convert to SPDX identifier | expand

Commit Message

Steve French Aug. 24, 2021, 5:15 p.m. UTC 
Add SPDX license identifier and replace license boilerplate
for cifs_md4.c

Comments

Christoph Hellwig Aug. 25, 2021, 6:15 a.m. UTC | #1 
On Tue, Aug 24, 2021 at 12:15:05PM -0500, Steve French wrote:
> - *   fs/smb2/smb2maperror.c
> + *   fs/cifs/smb2maperror.c


>  /*
> + * fs/cifs_common/cifs_md4.c
> + *

This is a good reminder on why putting the file name into the top of
file comment is stupid.  Just don't do it.
Steve French Aug. 25, 2021, 8:53 p.m. UTC | #2 
Removed the file name from the top of header comments as suggested.

On Wed, Aug 25, 2021 at 1:16 AM Christoph Hellwig <hch@infradead.org> wrote:
>
> On Tue, Aug 24, 2021 at 12:15:05PM -0500, Steve French wrote:
> > - *   fs/smb2/smb2maperror.c
> > + *   fs/cifs/smb2maperror.c
>
>
> >  /*
> > + * fs/cifs_common/cifs_md4.c
> > + *
>
> This is a good reminder on why putting the file name into the top of
> file comment is stupid.  Just don't do it.
>
diff mbox series

Patch

From 2cc08e732805ad6f99d78e5013dbf3d06eb13772 Mon Sep 17 00:00:00 2001
From: Steve French <stfrench@microsoft.com>
Date: Tue, 24 Aug 2021 12:07:46 -0500
Subject: [PATCH] cifs: cifs_md4 convert to SPDX identifier

Add SPDX license identifier and replace license boilerplate
for cifs_md4.c

Signed-off-by: Steve French <stfrench@microsoft.com>
---
 fs/cifs/smb2maperror.c    | 2 +-
 fs/cifs_common/cifs_md4.c | 8 +++-----
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/fs/cifs/smb2maperror.c b/fs/cifs/smb2maperror.c
index cea39bcecbab..8ba4aa3e0d8d 100644
--- a/fs/cifs/smb2maperror.c
+++ b/fs/cifs/smb2maperror.c
@@ -1,6 +1,6 @@ 
 // SPDX-License-Identifier: LGPL-2.1
 /*
- *   fs/smb2/smb2maperror.c
+ *   fs/cifs/smb2maperror.c
  *
  *   Functions which do error mapping of SMB2 status codes to POSIX errors
  *
diff --git a/fs/cifs_common/cifs_md4.c b/fs/cifs_common/cifs_md4.c
index dbf9113b8600..cc12e4cedb96 100644
--- a/fs/cifs_common/cifs_md4.c
+++ b/fs/cifs_common/cifs_md4.c
@@ -1,4 +1,7 @@ 
+// SPDX-License-Identifier: GPL-2.0
 /*
+ * fs/cifs_common/cifs_md4.c
+ *
  * Cryptographic API.
  *
  * MD4 Message Digest Algorithm (RFC1320).
@@ -14,11 +17,6 @@ 
  * Copyright (c) 2002 David S. Miller (davem@redhat.com)
  * Copyright (c) 2002 James Morris <jmorris@intercode.com.au>
  *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
  */
 #include <linux/init.h>
 #include <linux/kernel.h>
-- 
2.30.2