From patchwork Fri Jan 19 03:05:25 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steve French X-Patchwork-Id: 1888293 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=ZMZnXScW; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=2604:1380:4601:e00::3; helo=am.mirrors.kernel.org; envelope-from=linux-cifs+bounces-841-incoming=patchwork.ozlabs.org@vger.kernel.org; receiver=patchwork.ozlabs.org) Received: from am.mirrors.kernel.org (am.mirrors.kernel.org [IPv6:2604:1380:4601:e00::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4TGPd94qBTz1yQ0 for ; Fri, 19 Jan 2024 14:05:49 +1100 (AEDT) Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 1B0DF1F2369E for ; Fri, 19 Jan 2024 03:05:47 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 724531392; Fri, 19 Jan 2024 03:05:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZMZnXScW" X-Original-To: linux-cifs@vger.kernel.org Received: from mail-lj1-f174.google.com (mail-lj1-f174.google.com [209.85.208.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 26D081362 for ; Fri, 19 Jan 2024 03:05:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705633542; cv=none; b=OBsRakXLQRfNFB3k9DACztqsL0biALX6lrzghvSo2m0c2VItW6A8fOo6C8R3gf1GnYDRqdqhT7cCpci5EtuTYYi2oEhrU2sgiYFMyzN6i96KmfuIrE6YBa71UPBwuk+KtQkBUhjGUhVFd3xKhE3UK0DwmWp7GUxLMN5BleVk0jM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705633542; c=relaxed/simple; bh=dqMJw8ZH7wXviL3FOF7O/0gltJwL3hCiamV1TzkvQlI=; h=MIME-Version:From:Date:Message-ID:Subject:To:Cc:Content-Type; b=ZGKg4IBCJYoM/Y0Hlh39sCiJn6JZYDpNhWUfHPFSUfLlbQpu5rU5wnIIExWfbZcchoy6DilRWxkTvDT67uHG13awY929z41TWec3+iQJ+j9R8VpdhZeJ2dv2pKZbUJRtxZyAcaTj6KU/OyjZIAWCpyI+zrKmsXu4lJFw82DMX7c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZMZnXScW; arc=none smtp.client-ip=209.85.208.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lj1-f174.google.com with SMTP id 38308e7fff4ca-2cdeb808889so3883141fa.3 for ; Thu, 18 Jan 2024 19:05:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705633538; x=1706238338; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=ZRa4NM6IsikZO1n/Ev57pQHAoqkU2gjYRfLCre4W0Ps=; b=ZMZnXScWEy/aM5USpO5Ug41n354ezXDvpvB1wSiSYg9qJJueDhyGwv44PpqGZpXact ijzDaEwumcJobPRPByTg7CXOInRsgbThB6wAVQYvbYU/3NdYgnxseffiw/2aUcxh6zlC 0FZP910lbrKcZwDFJAHvcfKDyoF8T8WkSHnMPKN/AKH9BZHD8+F59J3SOxjhfPZkO8kC I9bcQL04fdKbh3E/7Y8gL4psSoLITAfyOcc6asvOnpueztykS88TIvzvUvZ4GryU4fPY eUboRbF9AEObxFjOt3Mb88di2Cg1U0RfXkECI48HPYOieEU/HN/0RIGnICQrVw7fmUWA JJmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705633538; x=1706238338; h=cc:to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=ZRa4NM6IsikZO1n/Ev57pQHAoqkU2gjYRfLCre4W0Ps=; b=iOm7bKzicVz1hGJG2AiW5mDTVu43f9gR/hSokPDdyrHRzJAJSDnFNNCXR7l61r/NRF gfSAWmTv0W5GWcCeOlXc681tvLWMn87PfAXD53j5vRLBwQfkeXk1k1WaSeaDTkBTRNtt B33630gYiLDNHfoSJdpaBhKmWWyoAz60SKLMd1sOIobNPN5/ix0XBMcaRKEBiZ9JdjJ3 qKe57CYIwgyJzsU9iTqqB5XKDTSiiD9V/9600Fs/jAMDLGLeNX4h7s4qCrjAO5CWObwG 4Rc0uGD1XhPIt7ZCxL2rdKnfJmdOnnAaKFd1p4JPl/GhNrXOTDiEDfGlsJ5K8KpvSYi1 HhVA== X-Gm-Message-State: AOJu0YyZKpDAAPcia+5+GXI16Bai9TN3EON+GhtPrCH7pAddCNzsF4fI tIo7zdFAbr2/NEIW9bjeLqBDR+T7nyCdrwL2ZOrOONp3TV1pWjyTm6/Xqifh5PLKreEUMjDsJIS vQBLfyhh9T1kU2ar9qBJ3R/YMKqKfu7qoyhQ= X-Google-Smtp-Source: AGHT+IGlYQ4RtdXS9exRYEbn+7cArU5JoCiHawO6yzW1KaTpOnLCP8KbAh2knNzSKUX7ohJ7f1xip59GiXsxqCY/xIY= X-Received: by 2002:ac2:51a3:0:b0:50e:3777:f779 with SMTP id f3-20020ac251a3000000b0050e3777f779mr254644lfk.31.1705633537629; Thu, 18 Jan 2024 19:05:37 -0800 (PST) Precedence: bulk X-Mailing-List: linux-cifs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Steve French Date: Thu, 18 Jan 2024 21:05:25 -0600 Message-ID: Subject: lightly updated versions of Shyam's recent multichannel patches To: CIFS Cc: Shyam Prasad N multichannel set of patches from Shyam. There are three additional patches of his that need more fixup, but these eight looked ok (I did minor updates to a few) From 936eba9cfb5cfbf6a2c762cd163605f2b784e03e Mon Sep 17 00:00:00 2001 From: Shyam Prasad N Date: Wed, 17 Jan 2024 05:55:39 +0000 Subject: [PATCH 1/8] cifs: open_cached_dir should not rely on primary channel open_cached_dir today selects ses->server a.k.a primary channel to send requests. When multichannel is used, the primary channel maybe down. So it does not make sense to rely only on that channel. This fix makes this function pick a channel with the standard helper function cifs_pick_channel. Signed-off-by: Shyam Prasad N Signed-off-by: Steve French --- fs/smb/client/cached_dir.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/smb/client/cached_dir.c b/fs/smb/client/cached_dir.c index d64a306a414b..971892620504 100644 --- a/fs/smb/client/cached_dir.c +++ b/fs/smb/client/cached_dir.c @@ -151,7 +151,7 @@ int open_cached_dir(unsigned int xid, struct cifs_tcon *tcon, return -EOPNOTSUPP; ses = tcon->ses; - server = ses->server; + server = cifs_pick_channel(ses); cfids = tcon->cfids; if (!server->ops->new_lease_key) -- 2.40.1