| Message ID | 18310e20-826f-45ab-b69e-dbfe47a1f83f@web.de |
|---|---|
| State | New |
| Headers | show |
| Series | cifs: Use seq_putc() in two functions | expand |
are there other examples of modules where similar changes have been made? On Sun, Jul 14, 2024 at 3:35 AM Markus Elfring <Markus.Elfring@web.de> wrote: > > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Sun, 14 Jul 2024 10:23:49 +0200 > > Single characters should be put into a sequence. > Thus use the corresponding function “seq_putc”. > > This issue was transformed by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> > --- > fs/smb/client/cifs_swn.c | 2 +- > fs/smb/client/cifsfs.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fs/smb/client/cifs_swn.c b/fs/smb/client/cifs_swn.c > index 7233c6a7e6d7..68998c6ba7a2 100644 > --- a/fs/smb/client/cifs_swn.c > +++ b/fs/smb/client/cifs_swn.c > @@ -655,7 +655,7 @@ void cifs_swn_dump(struct seq_file *m) > seq_printf(m, "%s", swnreg->ip_notify ? "(y)" : "(n)"); > } > mutex_unlock(&cifs_swnreg_idr_mutex); > - seq_puts(m, "\n"); > + seq_putc(m, '\n'); > } > > void cifs_swn_check(void) > diff --git a/fs/smb/client/cifsfs.c b/fs/smb/client/cifsfs.c > index 6397fdefd876..ce5cb72bb81f 100644 > --- a/fs/smb/client/cifsfs.c > +++ b/fs/smb/client/cifsfs.c > @@ -491,7 +491,7 @@ cifs_show_security(struct seq_file *s, struct cifs_ses *ses) > } > > if (ses->sign) > - seq_puts(s, "i"); > + seq_putc(s, 'i'); > > if (ses->sectype == Kerberos) > seq_printf(s, ",cruid=%u", > -- > 2.45.2 > >
Le 14/07/2024 à 23:31, Steve French a écrit : > are there other examples of modules where similar changes have been made? > Hi Steve, Most of the time, this kind of modification is useless because it is already done by the compiler, see [1]. CJ [1]: https://elixir.bootlin.com/linux/v6.10-rc7/source/include/linux/seq_file.h#L123 > On Sun, Jul 14, 2024 at 3:35 AM Markus Elfring <Markus.Elfring@web.de> wrote: >> >> From: Markus Elfring <elfring@users.sourceforge.net> >> Date: Sun, 14 Jul 2024 10:23:49 +0200 >> >> Single characters should be put into a sequence. >> Thus use the corresponding function “seq_putc”. >> >> This issue was transformed by using the Coccinelle software. >> >> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> >> --- >> fs/smb/client/cifs_swn.c | 2 +- >> fs/smb/client/cifsfs.c | 2 +- >> 2 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/fs/smb/client/cifs_swn.c b/fs/smb/client/cifs_swn.c >> index 7233c6a7e6d7..68998c6ba7a2 100644 >> --- a/fs/smb/client/cifs_swn.c >> +++ b/fs/smb/client/cifs_swn.c >> @@ -655,7 +655,7 @@ void cifs_swn_dump(struct seq_file *m) >> seq_printf(m, "%s", swnreg->ip_notify ? "(y)" : "(n)"); >> } >> mutex_unlock(&cifs_swnreg_idr_mutex); >> - seq_puts(m, "\n"); >> + seq_putc(m, '\n'); >> } >> >> void cifs_swn_check(void) >> diff --git a/fs/smb/client/cifsfs.c b/fs/smb/client/cifsfs.c >> index 6397fdefd876..ce5cb72bb81f 100644 >> --- a/fs/smb/client/cifsfs.c >> +++ b/fs/smb/client/cifsfs.c >> @@ -491,7 +491,7 @@ cifs_show_security(struct seq_file *s, struct cifs_ses *ses) >> } >> >> if (ses->sign) >> - seq_puts(s, "i"); >> + seq_putc(s, 'i'); >> >> if (ses->sectype == Kerberos) >> seq_printf(s, ",cruid=%u", >> -- >> 2.45.2 >> >> > >
> are there other examples of modules where similar changes have been made?
Similar source code adjustment possibilities were presented for several software components.
https://lore.kernel.org/all/?q=seq_puts
Regards,
Markus
diff --git a/fs/smb/client/cifs_swn.c b/fs/smb/client/cifs_swn.c index 7233c6a7e6d7..68998c6ba7a2 100644 --- a/fs/smb/client/cifs_swn.c +++ b/fs/smb/client/cifs_swn.c @@ -655,7 +655,7 @@ void cifs_swn_dump(struct seq_file *m) seq_printf(m, "%s", swnreg->ip_notify ? "(y)" : "(n)"); } mutex_unlock(&cifs_swnreg_idr_mutex); - seq_puts(m, "\n"); + seq_putc(m, '\n'); } void cifs_swn_check(void) diff --git a/fs/smb/client/cifsfs.c b/fs/smb/client/cifsfs.c index 6397fdefd876..ce5cb72bb81f 100644 --- a/fs/smb/client/cifsfs.c +++ b/fs/smb/client/cifsfs.c @@ -491,7 +491,7 @@ cifs_show_security(struct seq_file *s, struct cifs_ses *ses) } if (ses->sign) - seq_puts(s, "i"); + seq_putc(s, 'i'); if (ses->sectype == Kerberos) seq_printf(s, ",cruid=%u",