diff mbox series

cifs: Remove useless variable

Message ID 1617870662-78127-1-git-send-email-jiapeng.chong@linux.alibaba.com
State New
Headers show
Series cifs: Remove useless variable | expand

Commit Message

Jiapeng Chong April 8, 2021, 8:31 a.m. UTC
Fix the following gcc warning:

fs/cifs/cifsacl.c:1097:8: warning: variable ‘nmode’ set but not used
[-Wunused-but-set-variable].

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
 fs/cifs/cifsacl.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Steve French April 9, 2021, 4:09 a.m. UTC | #1
merged into cifs-2.6.git for-next

On Thu, Apr 8, 2021 at 3:33 AM Jiapeng Chong
<jiapeng.chong@linux.alibaba.com> wrote:
>
> Fix the following gcc warning:
>
> fs/cifs/cifsacl.c:1097:8: warning: variable ‘nmode’ set but not used
> [-Wunused-but-set-variable].
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
>  fs/cifs/cifsacl.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/fs/cifs/cifsacl.c b/fs/cifs/cifsacl.c
> index d178cf8..fdb258a 100644
> --- a/fs/cifs/cifsacl.c
> +++ b/fs/cifs/cifsacl.c
> @@ -1094,11 +1094,9 @@ static int set_chmod_dacl(struct cifs_acl *pdacl, struct cifs_acl *pndacl,
>         struct cifs_ace *pnntace = NULL;
>         char *nacl_base = NULL;
>         u32 num_aces = 0;
> -       __u64 nmode;
>         bool new_aces_set = false;
>
>         /* Assuming that pndacl and pnmode are never NULL */
> -       nmode = *pnmode;
>         nacl_base = (char *)pndacl;
>         nsize = sizeof(struct cifs_acl);
>
> --
> 1.8.3.1
>
diff mbox series

Patch

diff --git a/fs/cifs/cifsacl.c b/fs/cifs/cifsacl.c
index d178cf8..fdb258a 100644
--- a/fs/cifs/cifsacl.c
+++ b/fs/cifs/cifsacl.c
@@ -1094,11 +1094,9 @@  static int set_chmod_dacl(struct cifs_acl *pdacl, struct cifs_acl *pndacl,
 	struct cifs_ace *pnntace = NULL;
 	char *nacl_base = NULL;
 	u32 num_aces = 0;
-	__u64 nmode;
 	bool new_aces_set = false;
 
 	/* Assuming that pndacl and pnmode are never NULL */
-	nmode = *pnmode;
 	nacl_base = (char *)pndacl;
 	nsize = sizeof(struct cifs_acl);