From patchwork Tue Jan 17 00:09:47 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paulo Alcantara X-Patchwork-Id: 1727366 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=2620:137:e000::1:20; helo=out1.vger.email; envelope-from=linux-cifs-owner@vger.kernel.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=cjr.nz header.i=@cjr.nz header.a=rsa-sha256 header.s=dkim header.b=PLaQXoDB; dkim-atps=neutral Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by legolas.ozlabs.org (Postfix) with ESMTP id 4Nwq6y5tG7z23gc for ; Tue, 17 Jan 2023 11:11:06 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231272AbjAQALB (ORCPT ); Mon, 16 Jan 2023 19:11:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55748 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232913AbjAQALA (ORCPT ); Mon, 16 Jan 2023 19:11:00 -0500 Received: from mx.cjr.nz (mx.cjr.nz [51.158.111.142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DD6522716 for ; Mon, 16 Jan 2023 16:10:57 -0800 (PST) Received: from authenticated-user (mx.cjr.nz [51.158.111.142]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: pc) by mx.cjr.nz (Postfix) with ESMTPSA id 0ED0A80267; Tue, 17 Jan 2023 00:10:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cjr.nz; s=dkim; t=1673914255; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=SKWwpnsCjO9W99zj2nvqCsU/USVpIDBZx7N0nRbw40w=; b=PLaQXoDB5qUeT0ntrEm6FxaEYR3A+PQG1JvFZoj4AuLUGo4OVaE6ypzzsIgedKljPL8qOn +LJYdGvy6r9h0q/P59ipCM2WQYi3VhmNfwAtvVygCRX880i2DVjdtF51tfEsB0FGJaT/R+ GC7znNL+AWmxPUTQVs+2V/7NDsauaB3WnlAzmwfzEnp2XUKvbVcFJ4fs8BXULF8hobVth2 rbWwmWnoKEl+vqSGifTb4DkS5538ksSPg0K+gaQPMCFUE9u7HeaHC0SzkhaxyLtzLJ0NZ+ t0GkPR55wGXs5ha7NPFg2ODd9Z3UFUYTA/mJxIMbG0vZqP17dqV12Puq9Q+RsA== From: Paulo Alcantara To: smfrench@gmail.com Cc: linux-cifs@vger.kernel.org, Paulo Alcantara Subject: [PATCH 0/5] dfs fixes Date: Mon, 16 Jan 2023 21:09:47 -0300 Message-Id: <20230117000952.9965-1-pc@cjr.nz> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-cifs@vger.kernel.org Hi Steve, The most important fix is 1/5 that should fix those random hangs that we've observed while running dfs tests on buildbot. I have run twice 50 dfs tests against Windows 2022 and samba 4.16 with these mount options vers=3.1.1,echo_interval=10,{,hard} vers=3.0,echo_interval=10,{,hard} vers=3.0,echo_interval=10,{,sign} vers=3.0,echo_interval=10,{,seal} vers=2.1,echo_interval=10,{,hard} vers=1.0,echo_interval=10,{,hard} The only tests which failed (2%) were with SMB1 UNIX extensions against samba. readdir(2) was getting STATUS_INVALID_LEVEL from QUERY_PATH_INFO after failover for some reason -- I'll look into that when time allows. Those failures aren't related to this series, though. I also did some quick tests with kerberos. Paulo Alcantara (5): cifs: fix potential deadlock in cache_refresh_path() cifs: avoid re-lookups in dfs_cache_find() cifs: don't take exclusive lock for updating target hints cifs: remove duplicate code in __refresh_tcon() cifs: handle cache lookup errors different than -ENOENT fs/cifs/dfs_cache.c | 185 ++++++++++++++++++++++---------------------- 1 file changed, 94 insertions(+), 91 deletions(-)