| Message ID | 20240926032821.4171466-3-Delphine_CC_Chiu@wiwynn.com |
|---|---|
| State | New |
| Headers | show |
| Series | Add I2C mux on BUS 14 for yosemite4 | expand |
On Thu, 2024-09-26 at 11:28 +0800, Delphine CC Chiu wrote: > From: Ricky CX Wu <ricky.cx.wu.wiwynn@gmail.com> > > Remove led gpio contorller: pca9552 on fan boards since there is > no binding document for pca9552 currently. That's not true, there is, just it's not converted to dt-schema: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/leds/leds-pca955x.txt?h=v6.11 So the nodes can stay, though they probably generate warnings. The right way to fix this is to convert the binding document. Andrew > > Signed-off-by: Ricky CX Wu <ricky.cx.wu.wiwynn@gmail.com> > Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com> > --- > .../aspeed/aspeed-bmc-facebook-yosemite4.dts | 18 ------------------ > 1 file changed, 18 deletions(-) > > diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts > index 04f6378c2b5f..430c28bdd314 100644 > --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts > +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts > @@ -525,15 +525,6 @@ eeprom@52 { > compatible = "atmel,24c128"; > reg = <0x52>; > }; > - > - gpio@61 { > - compatible = "nxp,pca9552"; > - reg = <0x61>; > - #address-cells = <1>; > - #size-cells = <0>; > - gpio-controller; > - #gpio-cells = <2>; > - }; > }; > > imux31: i2c@1 { > @@ -577,15 +568,6 @@ eeprom@52 { > compatible = "atmel,24c128"; > reg = <0x52>; > }; > - > - gpio@61 { > - compatible = "nxp,pca9552"; > - reg = <0x61>; > - #address-cells = <1>; > - #size-cells = <0>; > - gpio-controller; > - #gpio-cells = <2>; > - }; > }; > }; > };
> -----Original Message----- > From: Andrew Jeffery <andrew@codeconstruct.com.au> > Sent: Friday, September 27, 2024 1:43 PM > To: Delphine_CC_Chiu/WYHQ/Wiwynn <Delphine_CC_Chiu@wiwynn.com>; > patrick@stwcx.xyz; Rob Herring <robh@kernel.org>; Krzysztof Kozlowski > <krzk+dt@kernel.org>; Conor Dooley <conor+dt@kernel.org>; Joel Stanley > <joel@jms.id.au> > Cc: Ricky CX Wu <ricky.cx.wu.wiwynn@gmail.com>; > devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > linux-aspeed@lists.ozlabs.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH v1 2/5] ARM: dts: aspeed: yosemite4: remove led gpio > pca9552 on fan boards > > [External Sender] > > [External Sender] > > On Thu, 2024-09-26 at 11:28 +0800, Delphine CC Chiu wrote: > > From: Ricky CX Wu <ricky.cx.wu.wiwynn@gmail.com> > > > > Remove led gpio contorller: pca9552 on fan boards since there is no > > binding document for pca9552 currently. > > That's not true, there is, just it's not converted to dt-schema: > > https://urldefense.com/v3/__https://git.kernel.org/pub/scm/linux/kernel/git/t > orvalds/linux.git/tree/Documentation/devicetree/bindings/leds/leds-pca955x.t > xt?h=v6.11__;!!J63qqgXj!KJlZXg_GnpgYEsfLwrxkUEqwfsHkt_41jTnC09yd5VPAqT > raqktY5p-KwUNQ3xPEbdockSD-knzTeOrQ8ijruq3-Q4c$ > > So the nodes can stay, though they probably generate warnings. The right way > to fix this is to convert the binding document. > > Andrew > Hi Andrew, Thanks for your suggestions. I'll remain the nodes and provide the binding document in another patch. Regards, Ricky
diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts index 04f6378c2b5f..430c28bdd314 100644 --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts @@ -525,15 +525,6 @@ eeprom@52 { compatible = "atmel,24c128"; reg = <0x52>; }; - - gpio@61 { - compatible = "nxp,pca9552"; - reg = <0x61>; - #address-cells = <1>; - #size-cells = <0>; - gpio-controller; - #gpio-cells = <2>; - }; }; imux31: i2c@1 { @@ -577,15 +568,6 @@ eeprom@52 { compatible = "atmel,24c128"; reg = <0x52>; }; - - gpio@61 { - compatible = "nxp,pca9552"; - reg = <0x61>; - #address-cells = <1>; - #size-cells = <0>; - gpio-controller; - #gpio-cells = <2>; - }; }; }; };