| Message ID | 20240816092417.3651434-19-Delphine_CC_Chiu@wiwynn.com |
|---|---|
| State | New |
| Headers | show |
| Series | Add i2c-mux and eeprom devices for Meta Yosemite 4 | expand |
On Fri, 2024-08-16 at 17:24 +0800, Delphine CC Chiu wrote: > add mctp config for NIC > > Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com> > --- > .../aspeed/aspeed-bmc-facebook-yosemite4.dts | 24 +++++++++++++++++++ > 1 file changed, 24 insertions(+) > > diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts > index b46a0b9940e2..7b8a2384d99d 100644 > --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts > +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts > @@ -1281,40 +1281,64 @@ imux24: i2c@0 { > #address-cells = <1>; > #size-cells = <0>; > reg = <0>; > + mctp-controller; > temperature-sensor@1f { > compatible = "ti,tmp421"; > reg = <0x1f>; > }; > + > + temperature-sensor@3c { > + compatible = "smsc,emc1403"; > + reg = <0x3c>; > + }; These nodes are unrelated to MCTP? Given we're assembling the puzzle via the jigsaw pieces in the rest of the series, please split the addition of these nodes out to a separate patch. Further, the EMC1403 compatible is undocumented as of v6.11-rc1, and a brief search didn't turn up anything on the lists. Please send a patch adding it to the trivial-devices binding document. Andrew
diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts index b46a0b9940e2..7b8a2384d99d 100644 --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts @@ -1281,40 +1281,64 @@ imux24: i2c@0 { #address-cells = <1>; #size-cells = <0>; reg = <0>; + mctp-controller; temperature-sensor@1f { compatible = "ti,tmp421"; reg = <0x1f>; }; + + temperature-sensor@3c { + compatible = "smsc,emc1403"; + reg = <0x3c>; + }; }; imux25: i2c@1 { #address-cells = <1>; #size-cells = <0>; reg = <1>; + mctp-controller; temperature-sensor@1f { compatible = "ti,tmp421"; reg = <0x1f>; }; + + temperature-sensor@3c { + compatible = "smsc,emc1403"; + reg = <0x3c>; + }; }; imux26: i2c@2 { #address-cells = <1>; #size-cells = <0>; reg = <2>; + mctp-controller; temperature-sensor@1f { compatible = "ti,tmp421"; reg = <0x1f>; }; + + temperature-sensor@3c { + compatible = "smsc,emc1403"; + reg = <0x3c>; + }; }; imux27: i2c@3 { #address-cells = <1>; #size-cells = <0>; reg = <3>; + mctp-controller; temperature-sensor@1f { compatible = "ti,tmp421"; reg = <0x1f>; }; + + temperature-sensor@3c { + compatible = "smsc,emc1403"; + reg = <0x3c>; + }; }; }; };
add mctp config for NIC Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com> --- .../aspeed/aspeed-bmc-facebook-yosemite4.dts | 24 +++++++++++++++++++ 1 file changed, 24 insertions(+)