From patchwork Tue Oct 30 22:11:06 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 991139 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 42l5Kw04X0z9sBj for ; Wed, 31 Oct 2018 09:12:04 +1100 (AEDT) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="J7kpoqW4"; dkim-atps=neutral Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 42l5Kv5C4tzF1Yv for ; Wed, 31 Oct 2018 09:12:03 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="J7kpoqW4"; dkim-atps=neutral X-Original-To: linux-aspeed@lists.ozlabs.org Delivered-To: linux-aspeed@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=chromium.org (client-ip=2607:f8b0:4864:20::441; helo=mail-pf1-x441.google.com; envelope-from=dianders@chromium.org; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="J7kpoqW4"; dkim-atps=neutral Received: from mail-pf1-x441.google.com (mail-pf1-x441.google.com [IPv6:2607:f8b0:4864:20::441]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 42l5Kd0DCBzF1Ph for ; Wed, 31 Oct 2018 09:11:48 +1100 (AEDT) Received: by mail-pf1-x441.google.com with SMTP id a15-v6so6571859pfn.0 for ; Tue, 30 Oct 2018 15:11:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=G4It3xDRhjbwJBDZhyOLMXPJlT41mX/wrMU8U1COu/w=; b=J7kpoqW4nCOMflV/GPpFHw3wbowwLlSw5cHb8BwCL0tjDKLS2pX+uBdYNdhSv5qJeR YIFqcoisweNYAEye7pDR4UbDTnN4qdVcG62oRk25fXvCZc6XVhIDzWTdT2NTPgeOBPqs 46XOtbWk86TJzDnegELyy5ty0b8CDo42RpUt8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=G4It3xDRhjbwJBDZhyOLMXPJlT41mX/wrMU8U1COu/w=; b=JpfDE69KkCfljU2oyOSXTFZkVUggkTAUF3wz+KIovf++npppkpCOtlYo6ZJR0duyLp n2k3LPS08ulgiQSSU+4IexB6Tj2SOV/dSP/fmp8T0EW3wuv1UnyQ5gNeIql7O8pNfM3Y 2aXACwO5jd9ZLDzCZID/R3Fk7nDS+UUsHLcnw83hDUqDP9iyQZnHcmo1zi787Llsgls9 7shmrAqnYeYydv44+nxyW8LQivDlEly7/xwxcf9fmUDjxx82uM9BfHWTOrLkD/Xdyx+Q Oowihd8jYXHyK+AnSb0xevqv2KB2Ez01RHsUtS9R+s6U47Ke9SMtcRK/w/qdOBr5qDSw jCjg== X-Gm-Message-State: AGRZ1gKgpJLAnF78zEnsWg6Tjp/hiP5b5acrdarK8BjB6wQS7R0kGOj/ jz/3VvShRHXHIucvJCyPNKTuJA== X-Google-Smtp-Source: AJdET5dD/X8oQn38qFkhnjnryX1IEDPvPKRA/R7wBL1aiw2Hj0b6uuIZql51K1rGVa5QRIGGqc0Iiw== X-Received: by 2002:a65:40c5:: with SMTP id u5mr516665pgp.46.1540937507248; Tue, 30 Oct 2018 15:11:47 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:1:c8e0:70d7:4be7:a36]) by smtp.gmail.com with ESMTPSA id b11-v6sm12844491pgi.10.2018.10.30.15.11.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 30 Oct 2018 15:11:46 -0700 (PDT) From: Douglas Anderson To: Greg Kroah-Hartman , Jiri Slaby Subject: [PATCH v2 4/5] serial: core: Include console.h from serial_core.h Date: Tue, 30 Oct 2018 15:11:06 -0700 Message-Id: <20181030221107.79758-5-dianders@chromium.org> X-Mailer: git-send-email 2.19.1.568.g152ad8e336-goog In-Reply-To: <20181030221107.79758-1-dianders@chromium.org> References: <20181030221107.79758-1-dianders@chromium.org> MIME-Version: 1.0 X-BeenThere: linux-aspeed@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux ASPEED SoC development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dan.carpenter@oracle.com, vigneshr@ti.com, linux-aspeed@lists.ozlabs.org, linux-arm-msm@vger.kernel.org, Douglas Anderson , tony@atomide.com, linux-serial@vger.kernel.org, andriy.shevchenko@linux.intel.com, linux-arm-kernel@lists.infradead.org, jk@ozlabs.org Errors-To: linux-aspeed-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Linux-aspeed" In the static inline function uart_handle_break() in serial_core.h we dereference port->cons. That gives an error unless console.h is also included. This error hasn't shown up till now because everyone who has defined SUPPORT_SYSRQ has also included console.h, but it's a bit ugly to make this requirement. Let's make the include explicit. Signed-off-by: Douglas Anderson --- include/linux/serial_core.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/serial_core.h b/include/linux/serial_core.h index 3460b15a2607..ff9d0ee32f11 100644 --- a/include/linux/serial_core.h +++ b/include/linux/serial_core.h @@ -22,6 +22,7 @@ #include #include +#include #include #include #include