mbox series

[v1,00/10] Introduce ASPEED AST27XX BMC SoC

Message ID 20240802090544.2741206-1-kevin_chen@aspeedtech.com
Headers show
Series Introduce ASPEED AST27XX BMC SoC | expand

Message

Kevin Chen Aug. 2, 2024, 9:05 a.m. UTC
This patchset adds initial support for the ASPEED.
AST27XX Board Management controller (BMC) SoC family.

AST2700 is ASPEED's 8th-generation server management processor.
Featuring a quad-core ARM Cortex A35 64-bit processor and two
independent ARM Cortex M4 processors

This patchset adds minimal architecture and drivers such as:
Clocksource, Clock and Reset

This patchset was tested on the ASPEED AST2700 evaluation board.

Kevin Chen (10):
  dt-binding: mfd: aspeed,ast2x00-scu: Add binding for ASPEED AST2700
    SCU
  dt-binding: clk: ast2700: Add binding for Aspeed AST27xx Clock
  clk: ast2700: add clock controller
  dt-bindings: reset: ast2700: Add binding for ASPEED AST2700 Reset
  dt-bindings: arm: aspeed: Add maintainer
  dt-bindings: arm: aspeed: Add aspeed,ast2700-evb compatible string
  arm64: aspeed: Add support for ASPEED AST2700 BMC SoC
  arm64: dts: aspeed: Add initial AST27XX device tree
  arm64: dts: aspeed: Add initial AST2700 EVB device tree
  arm64: defconfig: Add ASPEED AST2700 family support

 .../bindings/arm/aspeed/aspeed.yaml           |    6 +
 .../bindings/mfd/aspeed,ast2x00-scu.yaml      |    3 +
 MAINTAINERS                                   |    3 +
 arch/arm64/Kconfig.platforms                  |   14 +
 arch/arm64/boot/dts/Makefile                  |    1 +
 arch/arm64/boot/dts/aspeed/Makefile           |    4 +
 arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi     |  217 +++
 arch/arm64/boot/dts/aspeed/ast2700-evb.dts    |   50 +
 arch/arm64/configs/defconfig                  |    1 +
 drivers/clk/Makefile                          |    1 +
 drivers/clk/clk-ast2700.c                     | 1166 +++++++++++++++++
 .../dt-bindings/clock/aspeed,ast2700-clk.h    |  180 +++
 .../dt-bindings/reset/aspeed,ast2700-reset.h  |  126 ++
 13 files changed, 1772 insertions(+)
 create mode 100644 arch/arm64/boot/dts/aspeed/Makefile
 create mode 100644 arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi
 create mode 100644 arch/arm64/boot/dts/aspeed/ast2700-evb.dts
 create mode 100644 drivers/clk/clk-ast2700.c
 create mode 100644 include/dt-bindings/clock/aspeed,ast2700-clk.h
 create mode 100644 include/dt-bindings/reset/aspeed,ast2700-reset.h

Comments

Dmitry Baryshkov Aug. 2, 2024, 7:20 p.m. UTC | #1
On Fri, 2 Aug 2024 at 12:05, Kevin Chen <kevin_chen@aspeedtech.com> wrote:
>
> Enable CONFIG_ARCH_ASPEED in arm64 defconfig.

Why? Usually the defconfig changes have "Enable CONFIG_FOO as it is
used on the Bar Baz platform" commit message.

>
> Signed-off-by: Kevin Chen <kevin_chen@aspeedtech.com>
> ---
>  arch/arm64/configs/defconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index 7d32fca64996..b393735a695f 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -38,6 +38,7 @@ CONFIG_ARCH_AIROHA=y
>  CONFIG_ARCH_SUNXI=y
>  CONFIG_ARCH_ALPINE=y
>  CONFIG_ARCH_APPLE=y
> +CONFIG_ARCH_ASPEED=y
>  CONFIG_ARCH_BCM=y
>  CONFIG_ARCH_BCM2835=y
>  CONFIG_ARCH_BCM_IPROC=y
> --
> 2.34.1
>
Kevin Chen Oct. 8, 2024, 3:11 a.m. UTC | #2
> >
> > Enable CONFIG_ARCH_ASPEED in arm64 defconfig.
> 
> Why? Usually the defconfig changes have "Enable CONFIG_FOO as it is used on
> the Bar Baz platform" commit message.
Agree. I will fix it in next patch.
> 
> >
> > Signed-off-by: Kevin Chen <kevin_chen@aspeedtech.com>
> > ---
> >  arch/arm64/configs/defconfig | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm64/configs/defconfig
> > b/arch/arm64/configs/defconfig index 7d32fca64996..b393735a695f 100644
> > --- a/arch/arm64/configs/defconfig
> > +++ b/arch/arm64/configs/defconfig
> > @@ -38,6 +38,7 @@ CONFIG_ARCH_AIROHA=y  CONFIG_ARCH_SUNXI=y
> > CONFIG_ARCH_ALPINE=y  CONFIG_ARCH_APPLE=y
> > +CONFIG_ARCH_ASPEED=y
> >  CONFIG_ARCH_BCM=y
> >  CONFIG_ARCH_BCM2835=y
> >  CONFIG_ARCH_BCM_IPROC=y
> > --
> > 2.34.1
> >
> 
> 
> --
> With best wishes
> Dmitry
Kevin Chen Oct. 8, 2024, 3:13 a.m. UTC | #3
> >>
> >> Enable CONFIG_ARCH_ASPEED in arm64 defconfig.
> >
> > Why? Usually the defconfig changes have "Enable CONFIG_FOO as it is
> > used on the Bar Baz platform" commit message.
> 
> I would also expect to see aspeed specific device drivers to get enabled in the
> same commit. On arm32, I see
For different device drivers, ASPEED would submit code by its owner with CONFIG enabled.

> 
> CONFIG_ASPEED_KCS_IPMI_BMC=m
> CONFIG_ASPEED_BT_IPMI_BMC=m
> CONFIG_I2C_ASPEED=m
> CONFIG_SPI_ASPEED_SMC=m
> CONFIG_GPIO_ASPEED_SGPIO=y
> CONFIG_SENSORS_ASPEED=m
> CONFIG_VIDEO_ASPEED=m
> CONFIG_DRM_ASPEED_GFX=m
> CONFIG_USB_ASPEED_VHUB=m
> CONFIG_RTC_DRV_ASPEED=m
> CONFIG_ASPEED_LPC_CTRL=m
> CONFIG_ASPEED_LPC_SNOOP=m
> CONFIG_ASPEED_P2A_CTRL=m
> CONFIG_ASPEED_ADC=m
> CONFIG_FSI_MASTER_ASPEED=m
> 
> Presumably not all but a lot of these are also used on AST2700.
> 
>      Arnd