| Message ID | 20200719210235.21767-1-vgupta@synopsys.com |
|---|---|
| State | New |
| Headers | show |
| Series | Fix tst-libc_dlvsym{, -static} on ARC: don't check _sys_{err, sig}list | expand |
* Vineet Gupta via Libc-alpha: > diff --git a/elf/tst-libc_dlvsym.h b/elf/tst-libc_dlvsym.h > index 6b132dd7c3e4..7eda47207824 100644 > --- a/elf/tst-libc_dlvsym.h > +++ b/elf/tst-libc_dlvsym.h > @@ -117,8 +117,6 @@ compare_vsyms (void) > obtain an explicit handle for libc.so. */ > void *libc_handle = xdlopen (LIBC_SO, RTLD_LAZY | RTLD_NOLOAD); > > - compare_vsyms_1 (libc_handle, "_sys_errlist"); > - compare_vsyms_1 (libc_handle, "_sys_siglist"); > compare_vsyms_1 (libc_handle, "quick_exit"); > > xdlclose (libc_handle); Please use TEST_COMPAT, as in malloc/tst-mallocstate.c. Thanks, Florian
diff --git a/elf/tst-libc_dlvsym.h b/elf/tst-libc_dlvsym.h index 6b132dd7c3e4..7eda47207824 100644 --- a/elf/tst-libc_dlvsym.h +++ b/elf/tst-libc_dlvsym.h @@ -117,8 +117,6 @@ compare_vsyms (void) obtain an explicit handle for libc.so. */ void *libc_handle = xdlopen (LIBC_SO, RTLD_LAZY | RTLD_NOLOAD); - compare_vsyms_1 (libc_handle, "_sys_errlist"); - compare_vsyms_1 (libc_handle, "_sys_siglist"); compare_vsyms_1 (libc_handle, "quick_exit"); xdlclose (libc_handle);
These symbols were recently deprecated but the test still checks for them which fails for ARC. Tested with arc-linux-gnuhf -FAIL: elf/tst-libc_dlvsym +PASS: elf/tst-libc_dlvsym -FAIL: elf/tst-libc_dlvsym-static +PASS: elf/tst-libc_dlvsym-static | | $ cat elf/tst-libc_dlvsym-static.out | error: tst-libc_dlvsym.h:103: symbol _sys_errlist not found at any version | caveats: 1. This does reduce test-coverage for existing ports with older versions of glibc where these symbols are valid, but reckon it is not an issue since the symbol is being deprecated anyways 2. IMHO, despite the ABI freeze it should be fine for 2.32 too since it doesn't modify glibc ABI/API in any way, only a test-header is. --- elf/tst-libc_dlvsym.h | 2 -- 1 file changed, 2 deletions(-)