From patchwork Tue Dec 12 07:34:53 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sergey Senozhatsky X-Patchwork-Id: 847396 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133; helo=bombadil.infradead.org; envelope-from=linux-snps-arc-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="eEK9aDtO"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="EzhnJoxV"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3yws7z2Cv1z9s82 for ; Tue, 12 Dec 2017 18:36:15 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=j7RtXLR4ka1BkNNjn+8kjQuGxjNvZcOkNS2kfR5iSMo=; b=eEK9aDtObFJxvUoBaZTxPu+eNL B5fgP/v4qgvhiUMh1F1VhHMMdIl0Bcl4WFBPFAg42mlHFlqFMbaoZT+/SgBwY2jdE80FpgVGPVOld xQTsHRkBcqJEnAHyhs37PptoR2h6TCbKRi7g/NoUkrFjCY2Jn4DyP0cmwo8J2wm7URX1//7luTxLn P3fbbuBM4lZSdvH6siXbmcRsFxQXsZDHO/iIUb/K4sdIE8catBwlXLiOwMW4AsNhAQVz8u5Q25/6L aTTKrDuKa6WXvNumdII7m0QSyMgvtiq2sLvKN9UUpvf/+yR5QzmVYku2wlMf1PmQ93+6YOVhzPlAc HHCOnJYQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1eOf6r-0006hh-K8; Tue, 12 Dec 2017 07:36:13 +0000 Received: from mail-pf0-x242.google.com ([2607:f8b0:400e:c00::242]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1eOf6a-0006Lx-9N; Tue, 12 Dec 2017 07:35:58 +0000 Received: by mail-pf0-x242.google.com with SMTP id u19so13599504pfa.12; Mon, 11 Dec 2017 23:35:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Yd1A3IEmxtEOAr1phqe4QhRut/XggTJ8naDq5lA1DXg=; b=EzhnJoxV5wecF9O537uJMLWLcNv4kBg7RHC2uSO+mbfj9Mzco5j+nX2F+IsA1MXJ1h aE6boE36mbfVtclt7XbTVkxoSSWtalqYBwnn9VdUx+3TwVTm507Yscq3nHusuFgaDIjp b0gdXW+uEbQLIEKaNN23s1ue74o27aW4tgtxK2hU2xxlKXfa7LCc9WolNmOBetv6hGyR L7lSOMP6LMr/V+CYxQ4XQHYdc55KYN3yVJfiSJsecPfslHiTc60CG6mIrPCZir8gm9+K nRAKkh/0sCb/L51ov/2RmQElCCtii5cQXX0jON2ONBeqm3A9Aj3bY6s0bxXUDEIILRwB aQJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Yd1A3IEmxtEOAr1phqe4QhRut/XggTJ8naDq5lA1DXg=; b=OFrwU22XVYpwNcDVamxGnsGlF3tEnCv1grYiYVt5pwOli3VoStwvtKMs23prwDVWM9 QuLOXXn06IfXIqiCPNOc9gHUaxZBvS8WSePzEiA8UH4SFQRXv3HFqJ1qjIZyUt1OqQ2x AnjKEe1aO0c7InpCc61wcaoALbepPtTADNeGW1gkZ11zFb/SMtV6WU6icP0M8mnIVTLz qrTQz8qxmrcU9QgYZdeO4RwhYlX9LmjSnRpGT+eJ94SmseTKFmM/fR9pkycE06QZiZqG NB0hlZlSAaLJQ4u4xKetJqG+RyMCicA/3XziXq+TgZMEZtk/0o58p3M7fo9F3suLUWwP e6yA== X-Gm-Message-State: AKGB3mLkgEwLSSYnR4key2DOc89Fx2duHRvDaikiOzKU/GMJPR4Hbie4 qpgrcP/1eDbXOxMqgRs0peA= X-Google-Smtp-Source: ACJfBosyL14FcnHwfC4JEBvsBkXvD0aUXl6EbrD1u1ZVpYjHmhmyttFD1eRKYVoIvkvMxL2BsnxtYg== X-Received: by 10.84.218.204 with SMTP id g12mr1368150plm.213.1513064135638; Mon, 11 Dec 2017 23:35:35 -0800 (PST) Received: from localhost.localdomain ([110.70.52.222]) by smtp.gmail.com with ESMTPSA id 68sm28174687pfx.186.2017.12.11.23.35.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 11 Dec 2017 23:35:34 -0800 (PST) From: Sergey Senozhatsky X-Google-Original-From: Sergey Senozhatsky To: Andrew Morton , Russell King , Catalin Marinas , Mark Salter , Tony Luck , David Howells , Yoshinori Sato , Guan Xuetao , Borislav Petkov , Greg Kroah-Hartman , Thomas Gleixner , Peter Zijlstra , Vineet Gupta , Fengguang Wu , David Laight Subject: [PATCHv2 11/13] irq debug: do not use print_symbol() Date: Tue, 12 Dec 2017 16:34:53 +0900 Message-Id: <20171212073453.21455-1-sergey.senozhatsky@gmail.com> X-Mailer: git-send-email 2.15.1 In-Reply-To: <20171211125025.2270-12-sergey.senozhatsky@gmail.com> References: <20171211125025.2270-12-sergey.senozhatsky@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20171211_233556_415649_5C3CFD94 X-CRM114-Status: UNSURE ( 9.05 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -2.0 (--) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-2.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [2607:f8b0:400e:c00:0:0:0:242 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (sergey.senozhatsky.work[at]gmail.com) -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-snps-arc@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux on Synopsys ARC Processors List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Petr Mladek , linux-am33-list@redhat.com, linux-ia64@vger.kernel.org, linux-c6x-dev@linux-c6x.org, linux-sh@vger.kernel.org, x86@kernel.org, Sergey Senozhatsky , LKML , Steven Rostedt , Sergey Senozhatsky , linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org MIME-Version: 1.0 Sender: "linux-snps-arc" Errors-To: linux-snps-arc-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org print_symbol() uses extra stack space to sprintf() symbol information and then to feed that buffer to printk() char buffer[KSYM_SYMBOL_LEN]; sprint_symbol(buffer, address); printk(fmt, buffer); Replace print_symbol() with a direct printk("%pS") call. Signed-off-by: Sergey Senozhatsky Cc: Thomas Gleixner --- kernel/irq/debug.h | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/kernel/irq/debug.h b/kernel/irq/debug.h index 17f05ef8f575..7e06dd275c17 100644 --- a/kernel/irq/debug.h +++ b/kernel/irq/debug.h @@ -3,8 +3,6 @@ * Debugging printout: */ -#include - #define ___P(f) if (desc->status_use_accessors & f) printk("%14s set\n", #f) #define ___PS(f) if (desc->istate & f) printk("%14s set\n", #f) /* FIXME */ @@ -14,14 +12,14 @@ static inline void print_irq_desc(unsigned int irq, struct irq_desc *desc) { printk("irq %d, desc: %p, depth: %d, count: %d, unhandled: %d\n", irq, desc, desc->depth, desc->irq_count, desc->irqs_unhandled); - printk("->handle_irq(): %p, ", desc->handle_irq); - print_symbol("%s\n", (unsigned long)desc->handle_irq); - printk("->irq_data.chip(): %p, ", desc->irq_data.chip); - print_symbol("%s\n", (unsigned long)desc->irq_data.chip); + printk("->handle_irq(): %p, %pS\n", + desc->handle_irq, desc->handle_irq); + printk("->irq_data.chip(): %p, %pS\n", + desc->irq_data.chip, desc->irq_data.chip); printk("->action(): %p\n", desc->action); if (desc->action) { - printk("->action->handler(): %p, ", desc->action->handler); - print_symbol("%s\n", (unsigned long)desc->action->handler); + printk("->action->handler(): %p, %pS\n", + desc->action->handler, desc->action->handler); } ___P(IRQ_LEVEL);