Message ID | 20161110164454.293477-8-arnd@arndb.de |
---|---|
State | New |
Headers | show
Return-Path: <linux-snps-arc-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2001:1868:205::9]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3tF89Q3tnQz9vDp for <incoming@patchwork.ozlabs.org>; Fri, 11 Nov 2016 03:47:38 +1100 (AEDT) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.85_2 #1 (Red Hat Linux)) id 1c4sVk-0004Ck-Uh; Thu, 10 Nov 2016 16:47:36 +0000 Received: from mout.kundenserver.de ([212.227.126.187]) by bombadil.infradead.org with esmtps (Exim 4.85_2 #1 (Red Hat Linux)) id 1c4sVg-0003vt-RE for linux-snps-arc@lists.infradead.org; Thu, 10 Nov 2016 16:47:33 +0000 Received: from wuerfel.lan ([78.43.20.153]) by mrelayeu.kundenserver.de (mreue002 [212.227.15.129]) with ESMTPA (Nemesis) id 0M48SR-1cwR0O1239-00rnk4; Thu, 10 Nov 2016 17:45:43 +0100 From: Arnd Bergmann <arnd@arndb.de> To: Linus Torvalds <torvalds@linux-foundation.org> Subject: [PATCH v2 07/11] [media] rc: print correct variable for z8f0811 Date: Thu, 10 Nov 2016 17:44:50 +0100 Message-Id: <20161110164454.293477-8-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 In-Reply-To: <20161110164454.293477-1-arnd@arndb.de> References: <20161110164454.293477-1-arnd@arndb.de> X-Provags-ID: V03:K0:I48EU70rNIIJauXLBOhPboRKL2oZVbv2PJs72dsP8yWyN+wBhQv MI4JMVkDjTOF9Qm6SPs3r2RHCUFCykxYDoWNWi+lK3g6VRz5N2/vISpkE8nOLAjZBD067wH 6p3ixXhzahFK1to+3rPA4AUqD2FL819COuIUal8ikpVCKO+WCv7ZhwhcEqwbic/6rrbUH2E 8/v0U86G+VLhn0E3Z/FrQ== X-UI-Out-Filterresults: notjunk:1; V01:K0:XwQ2ynZpHdk=:tyxlLM3dM8D/BbbwuU6dfE /RUfqMQCQY09fiP+wgxOt85IPSv3NDhPXPtoPCDz4tAusOImfQvKKywJ0XfAZ06fymjlXnEib yyEZB+vTPM3W2Rs44emQQ9bmmoUVuT4r7HpsSc+SKGxz66BX8QF+2kOz+Rt7g+HKVOS9zjM8R J0hjO46c5DLHBp+MDJeUaHUKnc4Me9HiRycmL2aeWWgdOnlX+QYB1ihCCjMTjXNH3CZmxS5MW LXsFdzr/INbgTR5ScCpyhrR/qemBgdkT1EejWKhxlUZZvAgJ3pkLgfe0kJYh63ZvyuDtHLkSI nGr8bqJSQnJhtZYFxvx73gputt0OUQWHnyKfZNq5W46Mgp/+uFRYdUxsPdvFqJ33LlRfmCAsR jYc+AZqqh8LekAujjus/Qp2bFs8U4ObHRUfJUqVoqTRUIe0Js3NehkeoxxYNOUILSqqhbOEbw 97rWXUhEMxlWqjoLijuWm6XaQHXm3OP3ySONhkS+rzpFuyk6RXAKk608+NX3s7AiyyFtAlMUD 4C0B6IrJSls5YsjVdyaCVdDXCulNbeK6W2zEnks3c01IlLa6X8LCiSo8p7YKwhOlZHdWd+XSc xcDWpyFO7UF0gbNQQNq0fqPT59ueVeeb6Hq3lHPzkkaU4+XVrZTozVImEh5fJ0gkg0g7Dcgmb q8HdeQj/fgUFHL3H0TmkvfoQJvWvMVq9i6RixG8MHe+iHF+rQluc/lDFPKWpMzZ1UyX8= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20161110_084733_282008_E645B142 X-CRM114-Status: GOOD ( 10.20 ) X-Spam-Score: -1.9 (-) X-Spam-Report: SpamAssassin version 3.4.0 on bombadil.infradead.org summary: Content analysis details: (-1.9 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [212.227.126.187 listed in wl.mailspike.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [212.227.126.187 listed in list.dnswl.org] -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-BeenThere: linux-snps-arc@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Linux on Synopsys ARC Processors <linux-snps-arc.lists.infradead.org> List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-snps-arc>, <mailto:linux-snps-arc-request@lists.infradead.org?subject=unsubscribe> List-Archive: <http://lists.infradead.org/pipermail/linux-snps-arc/> List-Post: <mailto:linux-snps-arc@lists.infradead.org> List-Help: <mailto:linux-snps-arc-request@lists.infradead.org?subject=help> List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-snps-arc>, <mailto:linux-snps-arc-request@lists.infradead.org?subject=subscribe> Cc: Sean Young <sean@mess.org>, Trond Myklebust <trond.myklebust@primarydata.com>, linux-s390@vger.kernel.org, Herbert Xu <herbert@gondor.apana.org.au>, x86@kernel.org, Sebastian Ott <sebott@linux.vnet.ibm.com>, Russell King <linux@armlinux.org.uk>, Javier Martinez Canillas <javier@osg.samsung.com>, Ilya Dryomov <idryomov@gmail.com>, linux-snps-arc@lists.infradead.org, linux-media@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>, linux-kbuild@vger.kernel.org, Jiri Kosina <jikos@kernel.org>, Michal Marek <mmarek@suse.com>, nios2-dev@lists.rocketboards.org, Mauro Carvalho Chehab <mchehab@kernel.org>, linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, Anna Schumaker <anna.schumaker@netapp.com>, "Luis R . Rodriguez" <mcgrof@kernel.org>, linux-crypto@vger.kernel.org, Martin Schwidefsky <schwidefsky@de.ibm.com>, Ley Foon Tan <lftan@altera.com>, Andrew Morton <akpm@linux-foundation.org>, "David S. Miller" <davem@davemloft.net>, Jonathan Cameron <jic23@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-snps-arc" <linux-snps-arc-bounces@lists.infradead.org> Errors-To: linux-snps-arc-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org |
diff --git a/drivers/media/i2c/ir-kbd-i2c.c b/drivers/media/i2c/ir-kbd-i2c.c index f95a6bc..cede397 100644 --- a/drivers/media/i2c/ir-kbd-i2c.c +++ b/drivers/media/i2c/ir-kbd-i2c.c @@ -118,7 +118,7 @@ static int get_key_haup_common(struct IR_i2c *ir, enum rc_type *protocol, *protocol = RC_TYPE_RC6_MCE; dev &= 0x7f; dprintk(1, "ir hauppauge (rc6-mce): t%d vendor=%d dev=%d code=%d\n", - toggle, vendor, dev, code); + *ptoggle, vendor, dev, code); } else { *ptoggle = 0; *protocol = RC_TYPE_RC6_6A_32;
A recent rework accidentally left a debugging printk untouched while changing the meaning of the variables, leading to an uninitialized variable being printed: drivers/media/i2c/ir-kbd-i2c.c: In function 'get_key_haup_common': drivers/media/i2c/ir-kbd-i2c.c:62:2: error: 'toggle' may be used uninitialized in this function [-Werror=maybe-uninitialized] This prints the correct one instead, as we did before the patch. Fixes: 00bb820755ed ("[media] rc: Hauppauge z8f0811 can decode RC6") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/media/i2c/ir-kbd-i2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) I submitted this repeatedly as it is a v4.9 regression, but I never saw a reply for it.