From patchwork Tue Feb 20 09:40:15 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Geert Uytterhoeven X-Patchwork-Id: 875468 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=linux-snps-arc-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="g4NY4PWL"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3zlxDY1ctqz9ryf for ; Tue, 20 Feb 2018 21:09:33 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=8SdLMyoXtxf5uZRgDbbwphOpw/SnAZKeRAxMNo8dy4w=; b=g4N Y4PWLU8wwYoIJbc/HPnuoaT4oai1VuWbrb7piK1nBo7CM+2xuUhgzritsjnWj9meCdwaj11u2qBcZ fqsQayq+dcNf1zqDIser0qTQlzYipzXK9C+ttmOK2tNiTW3Kw9dZic5mjONFkSHi5T4Bwz3i3Qlca hKnmSbBrZqZTNOhl0rWkkTAZyzlXuUqp7YNl7AEzNi82RpAqMwL7WzkrhLeog1+eHtsQpSNQzNgim suol3PcueOfOay/ugage7Vt0BHuFfjCrCHdnPvzTKs+L/np9SljMklxplen1JSNsBoIGJrEJRATFh Wd7XQ99DsdgRHmsWQsiw4RLVXC++d1w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.89 #1 (Red Hat Linux)) id 1eo4rZ-0004LI-ET; Tue, 20 Feb 2018 10:09:29 +0000 Received: from laurent.telenet-ops.be ([2a02:1800:110:4::f00:19]) by bombadil.infradead.org with esmtps (Exim 4.89 #1 (Red Hat Linux)) id 1eo4g7-0006R3-Pp for linux-snps-arc@lists.infradead.org; Tue, 20 Feb 2018 09:57:58 +0000 Received: from ayla.of.borg ([84.194.111.163]) by laurent.telenet-ops.be with bizsmtp id CxxL1x00v3XaVaC01xxMeA; Tue, 20 Feb 2018 10:57:24 +0100 Received: from ramsan.of.borg ([192.168.97.29] helo=ramsan) by ayla.of.borg with esmtp (Exim 4.86_2) (envelope-from ) id 1eo4fo-0002mu-Ti; Tue, 20 Feb 2018 10:57:20 +0100 Received: from geert by ramsan with local (Exim 4.86_2) (envelope-from ) id 1eo4PU-0000LK-5P; Tue, 20 Feb 2018 10:40:28 +0100 From: Geert Uytterhoeven To: Greg Kroah-Hartman Subject: [PATCH 0/9] serial: Fix out-of-bounds accesses through DT aliases Date: Tue, 20 Feb 2018 10:40:15 +0100 Message-Id: <1519119624-1268-1-git-send-email-geert+renesas@glider.be> X-Mailer: git-send-email 2.7.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180220_015740_124031_895A3674 X-CRM114-Status: UNSURE ( 9.51 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -2.4 (--) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-2.4 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [2a02:1800:110:4:0:0:f00:19 listed in] [list.dnswl.org] 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-BeenThere: linux-snps-arc@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux on Synopsys ARC Processors List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Barry Song , Geert Uytterhoeven , Vineet Gupta , Michal Simek , linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-serial@vger.kernel.org, Jiri Slaby , linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-snps-arc" Errors-To: linux-snps-arc-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Hi all, Serial drivers used on DT platforms use the "serialN" alias in DT to obtain the serial port index for a specific port. Drivers typically use a fixed-size array for keeping track of all available serial ports. However, several drivers do not perform any validation on the index obtained from DT, which may lead to out-of-bounds accesses of these fixed-size arrays. While the DTB passed to the kernel might be considered trusted, some of these out-of-bounds accesses can be triggered by a legitimate DTB: - In some drivers the size of the array is defined by a Kconfig symbol, so a user who doesn't need all serial ports may lower this value rightfully, - Tomorrow's new SoC may have more serial ports than the fixed-size array in today's driver can accommodate, which the user may forget to enlarge. Hence this series fixes that by adding checks for out-of-range aliases, logging an error message when triggered. Tested on r8a7791/koelsch (sh-sci), all other drivers were compile-tested only. Thanks for your comments! Geert Uytterhoeven (9): serial: arc_uart: Fix out-of-bounds access through DT alias serial: fsl_lpuart: Fix out-of-bounds access through DT alias serial: imx: Fix out-of-bounds access through DT alias serial: mxs-auart: Fix out-of-bounds access through DT alias serial: pxa: Fix out-of-bounds access through DT alias serial: samsung: Fix out-of-bounds access through DT alias serial: sh-sci: Fix out-of-bounds access through DT alias serial: sirf: Fix out-of-bounds access through DT alias serial: xuartps: Fix out-of-bounds access through DT alias drivers/tty/serial/arc_uart.c | 5 +++++ drivers/tty/serial/fsl_lpuart.c | 4 ++++ drivers/tty/serial/imx.c | 5 +++++ drivers/tty/serial/mxs-auart.c | 4 ++++ drivers/tty/serial/pxa.c | 4 ++++ drivers/tty/serial/samsung.c | 4 ++++ drivers/tty/serial/sh-sci.c | 4 ++++ drivers/tty/serial/sirfsoc_uart.c | 5 +++++ drivers/tty/serial/xilinx_uartps.c | 2 +- 9 files changed, 36 insertions(+), 1 deletion(-)