From patchwork Fri Mar 30 15:46:58 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Yartys via Lede-dev X-Patchwork-Id: 893418 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=lists.infradead.org Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="kaFEsNVJ"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 40CQwZ3Pzpz9sXB for ; Sat, 31 Mar 2018 02:47:10 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Date:Sender:Content-Type: Subject:List-Help:Reply-To:List-Archive:List-Unsubscribe:List-Subscribe:Cc: From:List-Post:List-Id:Message-ID:MIME-Version:To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=UZa+AvkrymRq3Q1nZkRsa2oUl9kt/3rsBhRveUNd3i0=; b=kaFEsNVJs1j3Ac5zeK5pHjZi7t LmbFwcP8296+rWc3zkNvZx45zBTxXP7hJYaM5RHsln0h8I+lcLqx9J2Y5hdMvXOTMkMYDfqcL2LcY qh3RHHxrHhK16Nlc5c8ineKDbhi3TZ8OA0mNIVv7MhB1dVuBqdUjwfMRSbCIoXrpWeckJ9OhTS63q iOduFM6rxBcLyvc0EDxMX8zEJE8aUjTsN79r7D06/2tTCfJxnstB08hJsgeX3z32NYsKBPep3Af+m DJhK1O0yI4qF9+UG9m5cJOSOhTY33xGJmaJVwggj09wCKXMOe6oBdbR/p++5BlCMAwuhmX3uChIRT qeWXuyng==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1f1wF0-0005eM-Nj; Fri, 30 Mar 2018 15:46:58 +0000 To: lede-dev@lists.infradead.org MIME-Version: 1.0 Message-ID: List-Id: List-Post: X-Patchwork-Original-From: Kevin Darbyshire-Bryant via Lede-dev From: Michael Yartys via Lede-dev Precedence: list Cc: Kevin Darbyshire-Bryant X-Mailman-Version: 2.1.21 X-BeenThere: lede-dev@lists.infradead.org List-Subscribe: , List-Unsubscribe: , List-Archive: Reply-To: Kevin Darbyshire-Bryant List-Help: Subject: [LEDE-DEV] [PATCH] Revert "iproute2: fix hidden uint to uin64_t promotion in json_print" Sender: "Lede-dev" Date: Fri, 30 Mar 2018 15:46:58 +0000 Errors-To: lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The sender domain has a DMARC Reject/Quarantine policy which disallows sending mailing list messages using the original "From" header. To mitigate this problem, the original message has been wrapped automatically by the mailing list software. This reverts commit 745d0e7f4b6e8659cc967291acd33889035127f0. It looks like upstream don't want the patch so let's revert it here too. I hope a fix from upstream is forthcoming. Signed-off-by: Kevin Darbyshire-Bryant --- package/network/utils/iproute2/Makefile | 2 +- ...x-hidden-uint-to-uin64_t-promottion-in-js.patch | 65 ---------------------- 2 files changed, 1 insertion(+), 66 deletions(-) delete mode 100644 package/network/utils/iproute2/patches/910-iproute2-fix-hidden-uint-to-uin64_t-promottion-in-js.patch diff --git a/package/network/utils/iproute2/Makefile b/package/network/utils/iproute2/Makefile index d8ff5e590d..ef4befaeda 100644 --- a/package/network/utils/iproute2/Makefile +++ b/package/network/utils/iproute2/Makefile @@ -9,7 +9,7 @@ include $(TOPDIR)/rules.mk PKG_NAME:=iproute2 PKG_VERSION:=4.15.0 -PKG_RELEASE:=2 +PKG_RELEASE:=3 PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.xz PKG_SOURCE_URL:=@KERNEL/linux/utils/net/iproute2 diff --git a/package/network/utils/iproute2/patches/910-iproute2-fix-hidden-uint-to-uin64_t-promottion-in-js.patch b/package/network/utils/iproute2/patches/910-iproute2-fix-hidden-uint-to-uin64_t-promottion-in-js.patch deleted file mode 100644 index a549770045..0000000000 --- a/package/network/utils/iproute2/patches/910-iproute2-fix-hidden-uint-to-uin64_t-promottion-in-js.patch +++ /dev/null @@ -1,65 +0,0 @@ -From e1c6b35f9f978f6919e8bf651de67b30dc145543 Mon Sep 17 00:00:00 2001 -From: Kevin Darbyshire-Bryant -Date: Sun, 18 Mar 2018 08:51:08 +0000 -Subject: [PATCH] iproute2: fix hidden uint to uin64_t promotion in json_print - -print_int used 'int' type internally, whereas print_uint used 'uint64_t' - -These helper functions eventually call vfprintf(fp, fmt, args) which is -a variable argument list function and is dependent upon 'fmt' containing -correct information about the length of the passed arguments. - -Unfortunately print_int v print_uint offered no clue to the programmer -that internally passed ints to print_uint were being promoted to 64bits, -thus the format passed in 'fmt' string vs the actual passed integer -could be different lengths. This is even more interesting on big endian -architectures where 'vfprintf' would be looking in the middle of an -int64 type. Symptoms of this included tc qdisc showing bizarre values -for a variety of fields across a variety of qdiscs (e.g. refcnt, flows, -quantum) - -print_u/int now stick with native int size. - -A similar patch has been sent upstream. - -Fixes FS#1425 - -Signed-off-by: Kevin Darbyshire-Bryant ---- - include/json_print.h | 2 +- - lib/json_print.c | 2 +- - 2 files changed, 2 insertions(+), 2 deletions(-) - -diff --git a/include/json_print.h b/include/json_print.h -index dc4d2bb3..350d35cb 100644 ---- a/include/json_print.h -+++ b/include/json_print.h -@@ -56,10 +56,10 @@ void close_json_array(enum output_type type, const char *delim); - print_color_##type_name(t, COLOR_NONE, key, fmt, value); \ - } - _PRINT_FUNC(int, int); -+_PRINT_FUNC(uint, unsigned int); - _PRINT_FUNC(bool, bool); - _PRINT_FUNC(null, const char*); - _PRINT_FUNC(string, const char*); --_PRINT_FUNC(uint, uint64_t); - _PRINT_FUNC(hu, unsigned short); - _PRINT_FUNC(hex, unsigned int); - _PRINT_FUNC(0xhex, unsigned int); -diff --git a/lib/json_print.c b/lib/json_print.c -index aa527af6..ae3a317d 100644 ---- a/lib/json_print.c -+++ b/lib/json_print.c -@@ -117,8 +117,8 @@ void close_json_array(enum output_type type, const char *str) - } \ - } - _PRINT_FUNC(int, int); -+_PRINT_FUNC(uint, unsigned int); - _PRINT_FUNC(hu, unsigned short); --_PRINT_FUNC(uint, uint64_t); - _PRINT_FUNC(lluint, unsigned long long int); - #undef _PRINT_FUNC - --- -2.14.3 (Apple Git-98) -