From patchwork Fri Dec 29 04:48:26 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nathan Hintz X-Patchwork-Id: 853617 X-Patchwork-Delegate: blogic@openwrt.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133; helo=bombadil.infradead.org; envelope-from=lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ToecWuyi"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=hotmail.com header.i=@hotmail.com header.b="IwLbBruI"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3z7DdC1BG5z9s0g for ; Fri, 29 Dec 2017 15:49:02 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Subject:MIME-Version:Message-ID:Date:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=dogHvjyaq/8112JTOtXFF6Bnk2O6xX7XNXSAX+j8FB4=; b=ToecWuyinAU6H/ BEoq5DGwTOIGfcbscPH7cb4JJ+qp0ULNGzScHF2rmUlmeJ7j9y0rjtgIwfuCiICDtNXQ6ZWH61BK4 9YP8A2NWTrL2mO9IOxkCrR27msZ7xWW79ZCJmofimo0E/HAUboi2icDW3rhhujkUGBQf9HKIoM8Ly bpavvkOs3LlVjNBJyBW1Oy/EAz0cjTeXlvLgLVgVWeqNzblWIiiDN2gjYu/YJ+31cA+GM1RDt+2WH 8iyANXClHxQHIMPr37E9CDWR0b8ofAp7fW+m3wMGVZ2GpztRdSrp45ZX4SAzfTzCXMxpzgAoOKsyo OLe48DSULQEbtkyyt3xg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.89 #1 (Red Hat Linux)) id 1eUmb5-0005tw-Qn; Fri, 29 Dec 2017 04:48:43 +0000 Received: from mail-oln040092004109.outbound.protection.outlook.com ([40.92.4.109] helo=NAM02-CY1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.89 #1 (Red Hat Linux)) id 1eUmb2-0005sU-25 for lede-dev@lists.infradead.org; Fri, 29 Dec 2017 04:48:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=FUT981r4PTCFZX+fCoWrdlbN5+y/lmjImI678c1pBxs=; b=IwLbBruIvToogD2GqNLFTkCaOyUNtKX8sOKC4LOD8vc/bnKw+6MwA+82YmicQ/D5JsmE3fa0aMKDfigGfQzKtF6yDqp+lIC9VVBm6IuF2epBQfQ0xEHy6PoIEFHZj3b4eC0zHm0QItxbnlUQ/iTdgVDRa84zxUunI2u+RGhpnjvVKky81iv+/jhsU9ceQUb3d2pPQZn/1Er6TCvdGnbTxJVQrRSGDFRtXyrSAayFwhhC21B8VJEG7ZNpQzkFa/J3fFmYAQBaRbsaKGjiRtNG6+d7IHGNUv6zkEbW0nyc6NtkONuVjJWJlSHjL2vgJsvJYBH6XdIityHlKprNKO7Uww== Received: from CY1NAM02FT048.eop-nam02.prod.protection.outlook.com (10.152.74.52) by CY1NAM02HT033.eop-nam02.prod.protection.outlook.com (10.152.75.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.20.282.5; Fri, 29 Dec 2017 04:48:26 +0000 Received: from DM5PR2201MB1307.namprd22.prod.outlook.com (10.152.74.57) by CY1NAM02FT048.mail.protection.outlook.com (10.152.74.227) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.20.345.12 via Frontend Transport; Fri, 29 Dec 2017 04:48:26 +0000 Received: from DM5PR2201MB1307.namprd22.prod.outlook.com ([10.174.178.19]) by DM5PR2201MB1307.namprd22.prod.outlook.com ([10.174.178.19]) with mapi id 15.20.0366.007; Fri, 29 Dec 2017 04:48:26 +0000 From: Nathan Hintz To: "lede-dev@lists.infradead.org" Thread-Topic: [PATCH] procd: initd: fix path allocation in early_insmod Thread-Index: AQHTgGBDt75sOQbU20SnqzYm4mdlow== Date: Fri, 29 Dec 2017 04:48:26 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-incomingtopheadermarker: OriginalChecksum:20374A3312D99D07C14D6773D2F7BD84E8A08FD7D2ABA12F0E8E694F9CFE4FAA; UpperCasedChecksum:64E2CC795278552AA200F676102187D5B30EC30FFB7B76A3035160CEBF820808; SizeAsReceived:6999; Count:45 x-ms-exchange-messagesentrepresentingtype: 1 x-tmn: [BefBPIZNC4d6kzLoczwCG76Z7nZrQRXQxUeoXZODPezJsStbpCwNR32GE8PurInc] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; CY1NAM02HT033; 6:mz5MPAOR518KFQ8RIX2hSbGyPIKla3rHAaK5EjakEuF6NJa44dsAUXks9tt0ULyue5St4WahbGiLvmWyvBC8RDao8hpimuF/dhFrrXiwZTrTGTEswawbeq7ZguYNc4jSWlNn0p463ojKQ1nfQxeahax/YgQK+kzZekhvp7zuhotcogW/tDAJbf6rfTCOXv0JXi3TcDgmHOE90BXwjf8euz5WF1BEZdacNRRgh40iHZ7r2fYcfKC5yB1VrJV3hqIVNztoZNcVIj4RuYJxUhFSRPhlFhI004IVVwDJQIZ+duMpgd33JlU/3icGz8VPqpVu+Cny4MPc7f7i4+bO53HU9ysNmphlubHnYw/MnWCt4Tg=; 5:LLF0VKFg0/w6HmkfUujYe1ULG65GmHruPpHH/eQMskfFQFc+nihV4ICqSio60geRzr1z5Te2WqQmUVHDZSbgp7d/4tfYi5fQMs0uylbwRk4y9takaBmW8fuIAEW5atahlzS4RsyUT8S5xczbvi78DWtBhCzM9+370S+osko9w0Q=; 24:hgk2fglagO/i3WABIRFGDyMnj6mW9qcq5HzkISqPZxQ1sh9Xo1gXueWsg9grKsP9jM3/4t5ZwQyLR9h2MG7GhxGO+TcesovC0g3F3FtdFZY=; 7:8ZBcurhGqVJDg4AtEGAX18U+iN56cD3vhbCgB+yCrJIereBVCaWZoeXFVNL91fYjAo/6/QG4cJqYSp543eLQpE+zRE7YGqcYFhNX1oFkN5Syx1p2t13BYVVDtXZx6nQ5v0t5VbDYbIKQL9zHGkct1CN+k16ltC/bn6lmdjc2QL/DZjpzvO5AXRjSL8DDAkO4Yzi9DPMg8wm/oUvTzHQFv1wRrX5WR2WmwKuqoP27u8cY7VE5qQqdTUxslOTy6vVO x-incomingheadercount: 45 x-eopattributedmessage: 0 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(201702061074)(5061506573)(5061507331)(1603103135)(2017031320274)(2017031324274)(2017031323274)(201702181274)(2017031322404)(1601125374)(1603101448)(1701031045); SRVR:CY1NAM02HT033; x-ms-exchange-slblob-mailprops: S/btQ8cKWiTXKPHuLmq5FNioM1PflycXK06GPApAAstm+Y+327fIjk3WVG+t+FGM/BdRZVLwPm6fwwGaDjdfuPYYx1/kFdZ1VGe9n337axI/fLKgPSML4on6XvYnwEQd5etuEiorflZ00wDekMEGTokc6panLH5dp8XF4Mpq7yLssdX6UwBzXg3WjH8ZSc81lKqvYPkh+us3eO3E9wcyZiRaHWpyfOh56h4K5jw/PqFd0zuvVh8FxeBVjxRje9hIQTvavkwXjt7C0rU+gG5uCxx+QbCkzHXukh5+f4VnIDdxlCjVLImqKS/xt2agg96mgKvsCn+uceJhPWVjjHcixzWNKlxq/3ezyMfLLpwyp+Q7F5tQ795+YEqHhVNmMMWUMQdnJGzrh6QEZJH4l8UqSTZ3ZCCEBTz97qliS9SdTFBmlhj7FxK/JvIO3G5Q3G9H7bSFEMG4lid2YVdNs3IyvsU0LvS/zLR0PmJGSqjk8sWVzXuEFnVlih6sU6ojC5TRSrnQdqKqAXZijjGTRTXZkugCPjl8Vvbv6fUhZl5ooIxwV0W4QScSD6/Wgdf+QhFeyPooTsza8yY33dl2Y9Vw0lXPJl/ckaTuZ+naLqTzRWWfp0oK3WTwLT8EzD+DHYz5td2ii3oFLQ1Zp7MU70B5rNCy2hMvXrl4tSFq93ElrlRzRJ3NjxXbbSf6oHNCq9lEbxH8kwMZk6ch5d2RPcmbswEKIg3RoGga6cVAFGM2rdrZYeCmoRSdV6I+cSc2VFLazYRV2BrsuxM= x-ms-traffictypediagnostic: CY1NAM02HT033: x-ms-office365-filtering-correlation-id: c0573dbe-0d91-46f4-d2ad-08d54e7765ce x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(444000031); SRVR:CY1NAM02HT033; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:CY1NAM02HT033; x-forefront-prvs: 0536638EAC x-forefront-antispam-report: SFV:NSPM; SFS:(7070007)(98901004); DIR:OUT; SFP:1901; SCL:1; SRVR:CY1NAM02HT033; H:DM5PR2201MB1307.namprd22.prod.outlook.com; FPR:; SPF:None; LANG:; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: hotmail.com X-MS-Exchange-CrossTenant-Network-Message-Id: c0573dbe-0d91-46f4-d2ad-08d54e7765ce X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Dec 2017 04:48:26.4077 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Internet X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1NAM02HT033 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20171228_204840_190907_A056571C X-CRM114-Status: UNSURE ( 6.21 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -1.1 (-) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-1.1 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [40.92.4.109 listed in list.dnswl.org] 0.9 FORGED_HOTMAIL_RCVD2 hotmail.com 'From' address, but no 'Received:' -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (nlhintz[at]hotmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain Subject: [LEDE-DEV] [PATCH] procd: initd: fix path allocation in early_insmod X-BeenThere: lede-dev@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nathan Hintz Sender: "Lede-dev" Errors-To: lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Noticed that /tmp was not being created on /dev/zram0. This was on ixp4xx (nslu2) using GCC 6.3 and musl. The allocation should be using the length of the passed string (module path), not the size of the pointer to the string. Signed-off-by: Nathan Hintz --- initd/zram.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/initd/zram.c b/initd/zram.c index 0e78195..da1795a 100644 --- a/initd/zram.c +++ b/initd/zram.c @@ -60,7 +60,7 @@ early_insmod(char *module) struct utsname ver; uname(&ver); - path = alloca(sizeof(module) + strlen(ver.release) + 1); + path = alloca(strlen(module) + strlen(ver.release) + 1); sprintf(path, module, ver.release); modprobe[1] = path; execvp(modprobe[0], modprobe);