From patchwork Wed Jan 3 10:31:21 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= X-Patchwork-Id: 854957 X-Patchwork-Delegate: blogic@openwrt.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133; helo=bombadil.infradead.org; envelope-from=lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="dkh1OO+H"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="N8Zh+Z8Q"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3zBS0r5QCbz9t2x for ; Wed, 3 Jan 2018 21:31:57 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Subject:MIME-Version:Message-Id:Date:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=4rRWUfj5VcNlEv0K2XRpd/V23HQY39b3AZg6Riupi1o=; b=dkh1OO+HAHyCvu edkqw0zrKLsw8VFGW6mYk2f1dCuwK4zmqaQi2LgEt+PBw4dPBEc+z9g/XpGvlOVsqM04DJhidyX/i 1Q6oaztW7qEMkqryX1R6Xs48DyDcYiHc51Yp/fuMuIfBt0DhgzC5KKANnuvXa5sqQUv86fIK+tIzk f+2IQ58BiTtp7slOj/4Kc3ilnA2HMAIMDyxni1MWMEsOZP3wGUL24lvkYMtD7kYCfbKqiqqiDEx/q AZD2Lsb20GdsczpCPLAredxzPdgdfWr9CK47My/iKE8V9Ed8bzzj4ABb0ITsOTaaNqnRbgKnmto1L 9V6v+bNtD15FtYmZaJ/w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.89 #1 (Red Hat Linux)) id 1eWgKv-0006wz-K6; Wed, 03 Jan 2018 10:31:53 +0000 Received: from mail-lf0-x243.google.com ([2a00:1450:4010:c07::243]) by bombadil.infradead.org with esmtps (Exim 4.89 #1 (Red Hat Linux)) id 1eWgKr-0006g4-Je for lede-dev@lists.infradead.org; Wed, 03 Jan 2018 10:31:51 +0000 Received: by mail-lf0-x243.google.com with SMTP id w196so1190877lff.5 for ; Wed, 03 Jan 2018 02:31:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=b4UyfN4lzqwurVPPrXfIsRwFaeD+MQ8MW9LTTzNRoPw=; b=N8Zh+Z8Qlg33HtR67Yxag/WkgmnJgb3Ls+7DY+XJD+Jb5SFzHSkI+hhaaWZhPVzlEW tLD/1MRWfikUqA18xOe+28ugeGFME9lQ4/Kpqxn6EGkdpJ9+CIIxbpxIf2C2D/sgB/Ih X3aN4oVD+oIxOH870qlMZnE/DRd0FZfF5EqVbvH/c59FDZE66s34csUthwnQmHzlTreQ wQEoQD05tvpjyLe5izItuu+Uig6RLA72uiuQ6B+kzhK9+mygMOEQc5B5lgMYlPuyMBQ1 fQtZ23eOOl8cinWtV/CEAzrqw9lR6vwne6FNA3F25zWQDC1VhgjVR3slDbsroRl0r2Uq BXIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=b4UyfN4lzqwurVPPrXfIsRwFaeD+MQ8MW9LTTzNRoPw=; b=QjjVVPiansK2u2tIJEvnAFkW76FbmN2gI6wZJan25+MwOMgAkt0WH1TSHKAVGuUWNA JXrLa8w14ccllCVktIaNLFi0xxpW0c22iFfBfNB1aLi5MgFSgW6SPdkVXu9BGzZQf51I PleHtScR7mxL4cQLtBiY7/3F6dLw0SAtwZpwGEyMxr0S4e8CRoRa211viQ2oO2h60LX6 +41CGjRTZnja5VmlK+5uKWvxL1GQbvuPq/cxt8fQnEGEbOOxMU/cpGKgICJWWD+oHuYQ JGZsE6/x5tGSAIQNiHyQGFL01ty2kaXvJvB1uS9VLNiAIBZoWsGu09CxMgHiwKjdYOlQ oZxQ== X-Gm-Message-State: AKGB3mL8nqMbLHSdkbyuGZW4AO+Qgone5yTL25xH+qEdaw18QfQzFjAp yR3+MyzZnnjFAojfMjmfw3QNpg== X-Google-Smtp-Source: ACJfBosQYzRzw3VcowkaCvFVO2TRUGgrUDZBEt4uyDrVTEFzTs4dlRWWHqpGPaH4HUhSrCH7XR2Bmg== X-Received: by 10.25.209.71 with SMTP id i68mr613665lfg.39.1514975496635; Wed, 03 Jan 2018 02:31:36 -0800 (PST) Received: from linux-samsung.lan (ip-194-187-74-233.konfederacka.maverick.com.pl. [194.187.74.233]) by smtp.gmail.com with ESMTPSA id i18sm140206ljb.45.2018.01.03.02.31.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 03 Jan 2018 02:31:35 -0800 (PST) From: =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= To: John Crispin , lede-dev@lists.infradead.org Date: Wed, 3 Jan 2018 11:31:21 +0100 Message-Id: <20180103103123.10950-1-zajec5@gmail.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180103_023149_689382_0C5EA51F X-CRM114-Status: UNSURE ( 8.26 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -1.8 (-) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-1.8 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [2a00:1450:4010:c07:0:0:0:243 listed in] [list.dnswl.org] 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (zajec5[at]gmail.com) 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (zajec5[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Subject: [LEDE-DEV] [PATCH mountd 1/3] mount: call hotplug mount scripts only on success X-BeenThere: lede-dev@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= Sender: "Lede-dev" Errors-To: lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org From: Rafał Miłecki If mounting fails for whatever reason (like unsupported file system or something) hotplug.d scripts shouldn't be called. Signed-off-by: Rafał Miłecki --- mount.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mount.c b/mount.c index caf9d9d..803acc1 100644 --- a/mount.c +++ b/mount.c @@ -160,8 +160,8 @@ static void mount_add_list(char *name, char *dev, char *serial, snprintf(tmp, 64, "%s%s", uci_path, name); snprintf(tmp2, 64, "/tmp/run/mountd/%s", dev); symlink(tmp2, tmp); - mount_new("/tmp/run/mountd/", dev); - system_printf("ACTION=add DEVICE=%s NAME=%s /sbin/hotplug-call mount", dev, name); + if (!mount_new("/tmp/run/mountd/", dev)) + system_printf("ACTION=add DEVICE=%s NAME=%s /sbin/hotplug-call mount", dev, name); } }