From patchwork Wed Jan 3 09:35:13 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Olof Sivertsson X-Patchwork-Id: 854911 X-Patchwork-Delegate: dedeckeh@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133; helo=bombadil.infradead.org; envelope-from=lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="YyAmUmWR"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="P9a7Ej1B"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3zBQmV2d4mz9s81 for ; Wed, 3 Jan 2018 20:36:26 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Subject:Message-Id: Date:To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=GKLuLmBWINDSITyOmukvdx2W0mOoS+rQl7aPDcKQEIA=; b=YyAmUmWRoBOJUT R9XwZQEK1NmHnULKT13z/N4Loo8mYp+9Gje6lGBTd3JkDe0pvkrLb1EqDbA55zCItCQXcTcyLWnv8 s8d1kGKhiYuyUtwxlzPechjHOwZDLAYHSoW5MQpVAJpulfzzZP8n04y5xfnrS9k8KvYuCk/Zf5Mfa 5RuYxhbF7LphilEg/eXl3Capfbl+csL/oUF7zq3sk6PQ0VPTjFnMirORA3yimNost44mS1QH0ZYXq wk014DWK37G42qyMukPkKIzhu+41OC6s3AwbPZNJn1aq4DluCz9kYJQCSazYPGSqw86MXs4zQseYR BefzJqWNyo1UABSgO9Gg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.89 #1 (Red Hat Linux)) id 1eWfTA-0007Kr-V9; Wed, 03 Jan 2018 09:36:20 +0000 Received: from mail-lf0-x243.google.com ([2a00:1450:4010:c07::243]) by bombadil.infradead.org with esmtps (Exim 4.89 #1 (Red Hat Linux)) id 1eWfT7-0007JY-Py for lede-dev@lists.infradead.org; Wed, 03 Jan 2018 09:36:19 +0000 Received: by mail-lf0-x243.google.com with SMTP id o26so1039612lfc.10 for ; Wed, 03 Jan 2018 01:36:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=n9YEVyQOjkYlqbACgjcNEr1cp4JBcrArfvZHk1LGvn8=; b=P9a7Ej1BMsN+jZFNiOto6MflU96kmPTvkSoC2Sas9bagnR3LpB7a+kx8gP6dqu0YRB m40hrhONRhOC4QoLoN6ojh7vISJkYXkZ3IPE5cceHHjcrqGJg/3xVinpnninfHLAaONR jEjsGk3wkfRyCwQq1U2jSYqSVt4f+qb5E5ScT9IZpU+zxfRDgshMUk/ARyIyL5GHpnAY bIGPNm0p3pCeuTtZtIlhTYg1lItYoBQV140dT2mn6qIH+npjOoA2lLJpk20SuFoivCNk QKX+nq07kNF1oMHzTlPyOHisMJ3VDtfOjIAYyym2aGp7ZyMCuVdsQxLTz51hdOJ+ZiOM A20g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=n9YEVyQOjkYlqbACgjcNEr1cp4JBcrArfvZHk1LGvn8=; b=GAZXDwtQn7ByOgIUnd5gPHI8pgQ0BjzwkntXZKEyODxs63x+lJMr5HNyjD+9TaN0xn VP7SYcWjV7RntwSAR8qIFxea27QbhQB0A7SCimt5thMI6GMMTMyKE/zNR+IpHq8aQs70 h7/xBPfXQBf6kD0a4V11m8GgvPHuIWrvlK12IddVTrxiopnEvah40LdB6DVo4aPmNW+2 Lly22l7CzpzMru66Qb+MfF4J6ktTeiQEUyf85DU1XA4bL26/6ugAccjEq2eovXAQ/Y5d LbEuoW0EHWkSpSHtDUBB/2t6tYOD4Z7kPLz5ngWPaY2+qRKmSNf2xF74OH/4hHMKTEfA 5U7g== X-Gm-Message-State: AKGB3mLcuYVhGVUGuaVaenBaOU+4ZnDb2UYW8z6XYULA3iInrwNoO5gb hlp3YXIyxPmLGg4IwhGszWGtC0rq/Sw= X-Google-Smtp-Source: ACJfBotsKw5XVDws2B8ltH5QtXZ5QqXUKvCk8h69v3GdGmoRiKmUJshuJFjgl0OmUdlcFlbSfxqQ5g== X-Received: by 10.46.65.148 with SMTP id d20mr538613ljf.63.1514972165129; Wed, 03 Jan 2018 01:36:05 -0800 (PST) Received: from linw2017.zenterio.lan (vpn2.zenterio.com. [85.112.166.143]) by smtp.gmail.com with ESMTPSA id x84sm130891lff.70.2018.01.03.01.36.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 03 Jan 2018 01:36:04 -0800 (PST) From: Olof Sivertsson X-Google-Original-From: Olof Sivertsson To: lede-dev@lists.infradead.org Date: Wed, 3 Jan 2018 10:35:13 +0100 Message-Id: <20180103093513.8752-1-olof.sivertsson@zenterio.com> X-Mailer: git-send-email 2.15.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180103_013617_863058_D4B5E75C X-CRM114-Status: UNSURE ( 7.83 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -2.0 (--) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-2.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [2a00:1450:4010:c07:0:0:0:243 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (osivertsson[at]gmail.com) -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid Subject: [LEDE-DEV] [PATCH netifd] proto: allow dumping protocol handlers without config_params X-BeenThere: lede-dev@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Olof Sivertsson MIME-Version: 1.0 Sender: "Lede-dev" Errors-To: lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org When ubus invokes proto_dump_handlers, and a struct proto_handler has been added with a NULL config_params, a segmentation fault occurs. Avoid this segmentation fault by checking for a NULL config_params before further access. Signed-off-by: Olof Sivertsson --- proto.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/proto.c b/proto.c index 9eb31c5..6047735 100644 --- a/proto.c +++ b/proto.c @@ -591,7 +591,7 @@ proto_dump_handlers(struct blob_buf *b) void *v; c = blobmsg_open_table(b, p->name); - if (p->config_params->validate) { + if (p->config_params && p->config_params->validate) { int i; v = blobmsg_open_table(b, "validate");