diff mbox series

[LEDE-DEV] ar71xx: spi-rb4xx: balance clk_prepare_enable() call

Message ID 20171219072438.30624-1-juhosg@freemail.hu
State Accepted
Delegated to: John Crispin
Headers show
Series [LEDE-DEV] ar71xx: spi-rb4xx: balance clk_prepare_enable() call | expand

Commit Message

Gabor Juhos Dec. 19, 2017, 7:24 a.m. UTC 
Commit c312cef223dd ("ar71xx: spi-rb4xx fix.") replaced the clk_enable() call
with clk_prepare_enable() to meet the common clock framework requirements.
However it did not change the clk_disable() call in the error patch which
thus leads to imbalance.

Fix the code by using the correct counterpart of clk_prepare_enable() in both
places.

Fixes: c312cef223dd ("ar71xx: spi-rb4xx fix.")
Signed-off-by: Gabor Juhos <juhosg@freemail.hu>
---
 target/linux/ar71xx/files/drivers/spi/spi-rb4xx.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff mbox series

Patch

diff --git a/target/linux/ar71xx/files/drivers/spi/spi-rb4xx.c b/target/linux/ar71xx/files/drivers/spi/spi-rb4xx.c
index 9175fc7ae3..2d95e80495 100644
--- a/target/linux/ar71xx/files/drivers/spi/spi-rb4xx.c
+++ b/target/linux/ar71xx/files/drivers/spi/spi-rb4xx.c
@@ -379,7 +379,7 @@  static int rb4xx_spi_probe(struct platform_device *pdev)
 err_iounmap:
 	iounmap(rbspi->base);
 err_clk_disable:
-	clk_disable(rbspi->ahb_clk);
+	clk_disable_unprepare(rbspi->ahb_clk);
 err_clk_put:
 	clk_put(rbspi->ahb_clk);
 err_put_master:
@@ -394,7 +394,7 @@  static int rb4xx_spi_remove(struct platform_device *pdev)
 	struct rb4xx_spi *rbspi = platform_get_drvdata(pdev);
 
 	iounmap(rbspi->base);
-	clk_disable(rbspi->ahb_clk);
+	clk_disable_unprepare(rbspi->ahb_clk);
 	clk_put(rbspi->ahb_clk);
 	platform_set_drvdata(pdev, NULL);
 	spi_master_put(rbspi->master);