From patchwork Mon Dec 25 23:05:13 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rosen Penev X-Patchwork-Id: 852888 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133; helo=bombadil.infradead.org; envelope-from=lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="BsWpeXrk"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="juhh+XnD"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3z5F850XC2z9ryv for ; Tue, 26 Dec 2017 10:05:25 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Subject:Message-Id: Date:To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=VLOo6ql0Sq1pR9isVZv9TfTmTlT8rdt46GG2Q6Nicl8=; b=BsWpeXrkj2iUtX 678gvoDGUdJEm28kUc+xckVSzKGI8Pnc+hD62kJe8irmcCt50w8/j3fmxWcRqcw9heQnpRCLms2e0 bQSqWXmjxA5FJvfc9WUGFgiTLV71/77/cJ0QZcRmcMijQpQsT8BBhp0gVQRHBab+hRiE31lssod0a hoq9uc/ylI05RleLVtUFiEI+6mpFlaXYEE5v+611Cn68zLttSH2dDItJEHhUTqkUypCDmbIWxTi04 gjT+BiXVe7FcfeJhTwDCDMtCdWaRMWNXlvgVBeT8LQB63lVx6WCzJ4TMUDICDP6U3vgmmxug6ADhc CG1qEAHx9jsBv4g+NyHQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.89 #1 (Red Hat Linux)) id 1eTbo9-0003k2-1v; Mon, 25 Dec 2017 23:05:21 +0000 Received: from mail-pl0-x243.google.com ([2607:f8b0:400e:c01::243]) by bombadil.infradead.org with esmtps (Exim 4.89 #1 (Red Hat Linux)) id 1eTbo6-0003Mx-2O for lede-dev@lists.infradead.org; Mon, 25 Dec 2017 23:05:19 +0000 Received: by mail-pl0-x243.google.com with SMTP id o2so17057877plk.12 for ; Mon, 25 Dec 2017 15:05:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=vqFkMqpySfsdbfF0yEynw8jUQG2AHbM7A3jG+0uO7Pw=; b=juhh+XnDMSqbubOtgV8K/b5PFfWtbEoRQMFs/i5GCp8bo3wHbO+EciE79J+6i+Vmo3 wvbRo4cYmXPrxZLRb0WG24bvyJiJLsSm3FJ9Mj1kYEB5j5KumJWucC3QDdmv/fBmLsv7 Eay4KBAr8tSgzF9lECjN4tcSuzCL9hBeMDAST4z6MLjZKOMXvDufwPnZArq0NzPvbM2I PYI0/d87xCBtHn1pMlb7tnIi6P2pJRbfbt0eBqanV/L2qWNHtUoszOSDKsC8Tu6kkL+W GSoogADtnbBvRHli5XYCIBu4PAsS5D94Lq72Neib7zoeEuJ8OsezwsIXvD7EoZXZnCQ/ 2Crw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=vqFkMqpySfsdbfF0yEynw8jUQG2AHbM7A3jG+0uO7Pw=; b=BipzXvE5KMbYZ6XRFyQEdaM/mPBRmmqgJoh7jBnoCwWY84m5pN5tDNEGzjK7uAP1m3 m2sPkaXpjJ2Ld9eXIlW9baNMlT9fWoC1FUDfQgHgT3bAwq37Amj2hJQbuZzS5+10x7gB DZoYYwj7z3QsjOfCe36FrwVDPs+bf/S3wTUVpGZY9wuUpH5gG1pp/VMwzxy34IZ7N2+L /CsGQSshvxL5wPVOhfr/q//bdIOE0bbVW+IoKkGQY2q6aNAVcHJQ2/w3wZfF1K83HZyc qKaslCpPFetHBZFCASF5/Keuk3882zqRq+a4MOLwcaUrhOUaLfY9R62i3HbTy1osHnYb LUig== X-Gm-Message-State: AKGB3mKQH52kcGU+7xIUXtTvviZrOe4+nFhDfsRppHxXmCGPiFi51AVm H9ydK+h4OhYINTJVhjfA8p9WxWW5 X-Google-Smtp-Source: ACJfBoshUIRCHsnxJM6RbICf+87MRYzB0ed/8Co6d16qHUaqVu88OopgHqnQpkVjDToNVXhDz5lCbQ== X-Received: by 10.84.175.67 with SMTP id s61mr23483006plb.72.1514243106620; Mon, 25 Dec 2017 15:05:06 -0800 (PST) Received: from DESKTOP-CEH0M93.lan ([2001:470:1f05:c3e:98da:65ff:24e5:ee50]) by smtp.gmail.com with ESMTPSA id d66sm50700527pgc.67.2017.12.25.15.05.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 25 Dec 2017 15:05:06 -0800 (PST) From: Rosen Penev To: lede-dev@lists.infradead.org Date: Mon, 25 Dec 2017 15:05:13 -0800 Message-Id: <1514243113-6027-1-git-send-email-rosenp@gmail.com> X-Mailer: git-send-email 2.7.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20171225_150518_122324_36566F28 X-CRM114-Status: UNSURE ( 8.62 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -2.0 (--) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-2.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [2607:f8b0:400e:c01:0:0:0:243 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (rosenp[at]gmail.com) -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain Subject: [LEDE-DEV] [PATCH] odhcp6c: Replace strerror(errno) with %m X-BeenThere: lede-dev@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rosen Penev MIME-Version: 1.0 Sender: "Lede-dev" Errors-To: lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Reduction of 48 bytes in compiled size. No functional difference. -pedantic was removed as %m is a GNU extension. Signed-off-by: Rosen Penev --- CMakeLists.txt | 2 +- src/dhcpv6.c | 4 ++-- src/odhcp6c.c | 5 ++--- 3 files changed, 5 insertions(+), 6 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index a5b0cb3..c80c32a 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -5,7 +5,7 @@ cmake_policy(SET CMP0015 NEW) project(odhcp6c C) set(CMAKE_SHARED_LIBRARY_LINK_C_FLAGS "") set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -g -std=c99") -add_definitions(-D_GNU_SOURCE -Wall -Werror -Wextra -pedantic) +add_definitions(-D_GNU_SOURCE -Wall -Werror -Wextra) if(${EXT_PREFIX_CLASS}) add_definitions(-DEXT_PREFIX_CLASS=${EXT_PREFIX_CLASS}) diff --git a/src/dhcpv6.c b/src/dhcpv6.c index 9dce577..0944dd2 100644 --- a/src/dhcpv6.c +++ b/src/dhcpv6.c @@ -522,9 +522,9 @@ static void dhcpv6_send(enum dhcpv6_msg type, uint8_t trid[3], uint32_t ecs) if (sendmsg(sock, &msg, 0) < 0) { char in6_str[INET6_ADDRSTRLEN]; - syslog(LOG_ERR, "Failed to send DHCPV6 message to %s (%s)", + syslog(LOG_ERR, "Failed to send DHCPV6 message to %s (%m)", inet_ntop(AF_INET6, (const void *)&srv.sin6_addr, - in6_str, sizeof(in6_str)), strerror(errno)); + in6_str, sizeof(in6_str))); } } diff --git a/src/odhcp6c.c b/src/odhcp6c.c index 666af5c..a14c22e 100644 --- a/src/odhcp6c.c +++ b/src/odhcp6c.c @@ -255,15 +255,14 @@ int main(_unused int argc, char* const argv[]) init_dhcpv6(ifname, client_options, sol_timeout) || ra_init(ifname, &ifid, ra_options, ra_holdoff_interval) || script_init(script, ifname)) { - syslog(LOG_ERR, "failed to initialize: %s", strerror(errno)); + syslog(LOG_ERR, "failed to initialize: %m"); return 3; } if (daemonize) { openlog("odhcp6c", LOG_PID, LOG_DAEMON); // Disable LOG_PERROR if (daemon(0, 0)) { - syslog(LOG_ERR, "Failed to daemonize: %s", - strerror(errno)); + syslog(LOG_ERR, "Failed to daemonize: %m"); return 4; }