From patchwork Mon Dec 25 22:52:20 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rosen Penev X-Patchwork-Id: 852882 X-Patchwork-Delegate: blogic@openwrt.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133; helo=bombadil.infradead.org; envelope-from=lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="gw12R0uQ"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="PGZlVA8d"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3z5DsR5d1kz9ryv for ; Tue, 26 Dec 2017 09:52:43 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Subject:Message-Id: Date:To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=llC3M/Z/NYpG9cGljbV90svLG1Y/qfLfyOgRH/cEGCY=; b=gw12R0uQ0ypiX+ h5yYDNIQRMn7ONK5D0t2eIICbJb+MTAEqoTiNZSlVcJphTvtBClLIZ1LZ5+d3O/c6QRHJMXC1ASmA 2Sd6Gh45LVQrcvEKAHlIHHxSFDG6b/7I73bl6vB49jtSpKRm8PbkAHlHJU3IkQuArX8EQ8AJRapBS mogH2CsZxNUDxqZ2faNvw4ley1cVjbv5Xmr34wtFY/Kdw4rNgDrGGqW9fOqxZNxEFQXNlctlxAnoA VGWXe+NzHQ96jAMDol8MZ9oHAE3ctuDqbCny70YC65t7UeqSIxOYlDjZqRh6KWAWgjwBsiFrZCOKF e/9lw+KjIMCU7pEEI6sw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.89 #1 (Red Hat Linux)) id 1eTbbh-0005qS-PM; Mon, 25 Dec 2017 22:52:29 +0000 Received: from mail-pg0-x242.google.com ([2607:f8b0:400e:c05::242]) by bombadil.infradead.org with esmtps (Exim 4.89 #1 (Red Hat Linux)) id 1eTbbe-0005pS-81 for lede-dev@lists.infradead.org; Mon, 25 Dec 2017 22:52:27 +0000 Received: by mail-pg0-x242.google.com with SMTP id f18so579572pga.10 for ; Mon, 25 Dec 2017 14:52:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=f4VkIQQqp/hEQZzkGDRHn75rRUxStbl33zoXVFpb3Qs=; b=PGZlVA8dbaAhERtNaFrTWMKzfa2wSeK4CxREE3bLRT+HbMsxJucKohZyry9GaD3gkP wRm+FAnkEuF4aleKa3DztMOqxd0Hzd13nTuYeF6hhjmmr+yVL3qLHsAqlmO70ex/MQ+P SbW+YIG9k9kZpVLXjht752fPBuoojeOeXiVrDYnouxXgpen2d775/By+wly36eIHLJax yNonNGJarPlyB0nYtDzVEfYY2coosMP0mtts7gwN3K5sqN6O7ji2dT6cFLoB6WILsB1K gkjahJTctHOjMaH3ZSFNcbkXOlZxpwP2CulYGB5Z04oqaTXiMrgbdCnWkGosNmZzpEI6 B2kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=f4VkIQQqp/hEQZzkGDRHn75rRUxStbl33zoXVFpb3Qs=; b=gCtUwuY2KZtBnPwhH/Ga75HggUYKjm9d+Zho+B1wRJlsVAZZgki5PnDA7B9NxssjZ6 dOSqWpUSLPxJD2afAxVotril2blBbE/tsgSVl04IEPdnhYFmvq0yYnT4yGFJiG6MqdpM cbwhVFL3giX5/NsqUbxPbK9wm897xHDo+A2L31wj/aIj4m5erIqVwjtGEJpfIrHoJyFd T0bU8YDHtlAD9MGNyDtpXz7xQn56t2W+8ZpCfxnKkypS1bkoNoyavaEz4NyX/14RVnkd +R9MgMiRBm7iPxKsIX/J/rt4KIOrZlTXDzqk5x9s3wWcC61f+b6Icz+d4xir6U3WlevQ T9bg== X-Gm-Message-State: AKGB3mJhpyFnxQS7d/YsB7HVUk4T6picqHu1Mij1nOWhFTa8KPKZ9b8f n6zOELgBVsnbqvY51RlkGq3AWvjy X-Google-Smtp-Source: ACJfBotgjCBn0mIExZKL/ZQZZEb8FjLd8wUjqIJe2AYA34sS0GG2L9us365FsetCoMbNJVrHv9StMw== X-Received: by 10.101.101.69 with SMTP id a5mr9277256pgw.226.1514242334055; Mon, 25 Dec 2017 14:52:14 -0800 (PST) Received: from DESKTOP-CEH0M93.lan ([2001:470:1f05:c3e:98da:65ff:24e5:ee50]) by smtp.gmail.com with ESMTPSA id b78sm60762519pfc.21.2017.12.25.14.52.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 25 Dec 2017 14:52:13 -0800 (PST) From: Rosen Penev To: lede-dev@lists.infradead.org Date: Mon, 25 Dec 2017 14:52:20 -0800 Message-Id: <1514242340-4247-1-git-send-email-rosenp@gmail.com> X-Mailer: git-send-email 2.7.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20171225_145226_300360_73CE083F X-CRM114-Status: UNSURE ( 6.64 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -2.0 (--) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-2.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [2607:f8b0:400e:c05:0:0:0:242 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (rosenp[at]gmail.com) -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain Subject: [LEDE-DEV] [PATCH] procd: Fix minor null pointer dereference. X-BeenThere: lede-dev@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rosen Penev MIME-Version: 1.0 Sender: "Lede-dev" Errors-To: lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Null pointer check was placed after assigning values to c. Signed-off-by: Rosen Penev --- plug/hotplug.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/plug/hotplug.c b/plug/hotplug.c index c52259e..80e6e4d 100644 --- a/plug/hotplug.c +++ b/plug/hotplug.c @@ -392,12 +392,12 @@ static void queue_add(struct cmd_handler *h, struct blob_attr *msg, struct blob_ &_data, blob_pad_len(data), NULL); - c->msg = _msg; - c->data = _data; - if (!c) return; + c->msg = _msg; + c->data = _data; + memcpy(c->msg, msg, blob_pad_len(msg)); memcpy(c->data, data, blob_pad_len(data)); c->handler = h->handler;