diff mbox series

[LEDE-DEV] procd: Fix minor null pointer dereference.

Message ID 1514242340-4247-1-git-send-email-rosenp@gmail.com
State Accepted
Delegated to: John Crispin
Headers show
Series [LEDE-DEV] procd: Fix minor null pointer dereference. | expand

Commit Message

Rosen Penev Dec. 25, 2017, 10:52 p.m. UTC 
Null pointer check was placed after assigning values to c.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
 plug/hotplug.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
diff mbox series

Patch

diff --git a/plug/hotplug.c b/plug/hotplug.c
index c52259e..80e6e4d 100644
--- a/plug/hotplug.c
+++ b/plug/hotplug.c
@@ -392,12 +392,12 @@  static void queue_add(struct cmd_handler *h, struct blob_attr *msg, struct blob_
 		&_data, blob_pad_len(data),
 		NULL);
 
-	c->msg = _msg;
-	c->data = _data;
-
 	if (!c)
 		return;
 
+	c->msg = _msg;
+	c->data = _data;
+
 	memcpy(c->msg, msg, blob_pad_len(msg));
 	memcpy(c->data, data, blob_pad_len(data));
 	c->handler = h->handler;