From patchwork Mon Dec 4 19:40:24 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rosen Penev X-Patchwork-Id: 844390 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133; helo=bombadil.infradead.org; envelope-from=lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="GKR3gclO"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="o/cZaJHb"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3yrFdk3ShLz9sBd for ; Tue, 5 Dec 2017 06:42:34 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Subject:References: In-Reply-To:Message-Id:Date:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zbJ8YlDLOCWZoBK0JHetf6uAT5Yc+rslGhw0eJyn6y4=; b=GKR3gclO3liqSu hJHyhBefb+NeKETwfro3nTm7SP5aFWaGDla0SYeYYpuTOANZy3alcYwWIRkUhiEm98vG6nT83mGES A9I740aYryFs0/wHNQCQsaRhI0/cpOyt8SAsxnEA9s9/h2cok1JEx9JzayI/JcgfshQfW2/lZwOXd OLld5NnQ6/dkRNN5CsuzaX6JWetsdvV9HDzDj5V4CXW/Sma+4lwh63DOscS4n5OA7/DEodtT8RSoX Lhr+O3sNnvxomOr+026NJcNdInmMsM0yvKD4XMKZx3+6baCViMKt9fxXXr3tTJsO85wg/qXPHHRND rBHZb09U4kI8lM9urnVw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1eLwdM-00089h-5x; Mon, 04 Dec 2017 19:42:32 +0000 Received: from mail-pg0-x243.google.com ([2607:f8b0:400e:c05::243]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1eLwbp-0007UP-5K for lede-dev@lists.infradead.org; Mon, 04 Dec 2017 19:41:00 +0000 Received: by mail-pg0-x243.google.com with SMTP id y6so8921519pgp.4 for ; Mon, 04 Dec 2017 11:40:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=UTvoYAh268oEHJ+WgwFxCAodXx9B/Hh2X70pjAOmhJU=; b=o/cZaJHbdDuBMuyHEiJYSNbGQb6bYR/u2s2/1ex0hcsVfkMzWj7RsNounV9Kh8gy3H fSNXnLZrNXCs+d8Td5FGWNCdWloXJpZ7PdEjwc7wdfAdqZtTN+lUHCdTU6unxcFmm4hU cXy48SWz8aVBCKgXAcVUaRxmYrNPbiNbIR+Si0LVZxd0/v4RLs7qCYglwfGBsc5a5Bbg spZJ7pkFhU5Qc3c1Hrsh7BdxOhP67IAvobQlwwNPLs3dM5egDRDmH/FneMutfq6IS+E+ Az47/n6QtMkfHNMdd78SI8oMa9i+xU0FALt0TpEljLbIB5sekuyeM88x2fvdYN8On/1W AHtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=UTvoYAh268oEHJ+WgwFxCAodXx9B/Hh2X70pjAOmhJU=; b=njzI3gwNg2pBcRxaL5O0vjhurryx2QH4liYT1uNdE1cBXTcxPx1gcAZuoEl8wZMWfd zYhqXNOtOUzYoGCUiqt3rO7uV4Adz6c+E1mTvDdHveRBHCsr9LQoT3Cef/Aqu5kDbocu RfV578TpHFp2Mm7Bt7t77gtyOvUu7iwaTzdBuzGajaAWRbZh319UM5pzEI11bPS/BGHA tn6fl1GDmgVhU+7ZPQGqLhjE89ql2bj7l/hmv/B7lTC7r7s25g0lOGvCyg6+09VXMtk0 25oj3Wsj+ypdZIVnd1nTUmjionZUiFoGbN6x4t7kOMljRXIJDALvXZ3dsNNwUb5He+MS FyVw== X-Gm-Message-State: AJaThX4/voUtSREN75OmGsXkIXrjYinFwbWUYzsT19SSq6GQbnNbYggF hKQe2w3AyjZaJGyXlSKy8fawfbN5 X-Google-Smtp-Source: AGs4zMZC7oUJv3DSD9y/xNqJymNzpNBQTwj9t/eQnS4r3wymU8hihGXA6akeVJz6vdNd4MhvTbw8Tg== X-Received: by 10.159.240.138 with SMTP id p10mr15502370plr.360.1512416436156; Mon, 04 Dec 2017 11:40:36 -0800 (PST) Received: from DESKTOP-CEH0M93.lan (astound-64-85-248-45.ca.astound.net. [64.85.248.45]) by smtp.gmail.com with ESMTPSA id w3sm22889590pge.59.2017.12.04.11.40.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 04 Dec 2017 11:40:35 -0800 (PST) From: Rosen Penev To: lede-dev@lists.infradead.org Date: Mon, 4 Dec 2017 11:40:24 -0800 Message-Id: <1512416424-629-5-git-send-email-rosenp@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1512416424-629-1-git-send-email-rosenp@gmail.com> References: <1512416424-629-1-git-send-email-rosenp@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20171204_114057_318031_92AC37BA X-CRM114-Status: UNSURE ( 9.95 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -2.0 (--) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-2.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [2607:f8b0:400e:c05:0:0:0:243 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (rosenp[at]gmail.com) -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid Subject: [LEDE-DEV] [PATCH 5/5] ag71xx: remove dma_unmap_single as it is no-op. X-BeenThere: lede-dev@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rosen Penev MIME-Version: 1.0 Sender: "Lede-dev" Errors-To: lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Qualcomm claims this is no-op for MIPS. Original commit message below: From: Ben Menchaca Date: Fri, 7 Jun 2013 11:19:08 -0500 Subject: [ag71xx] DMA unmap FROM_DEVICE no-op for our arch The invalidate for FROM_DEVICE map/unmap pairs is done in the map. The unmap is a no-op, but there is a cost for accessing that no-op function through the large number of indirection layers presented by the MIPS linux dma_ops. Signed-off-by: Ben Menchaca Signed-off-by: Rosen Penev --- .../files/drivers/net/ethernet/atheros/ag71xx/ag71xx_main.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/target/linux/ar71xx/files/drivers/net/ethernet/atheros/ag71xx/ag71xx_main.c b/target/linux/ar71xx/files/drivers/net/ethernet/atheros/ag71xx/ag71xx_main.c index 566e951..b67e04e 100644 --- a/target/linux/ar71xx/files/drivers/net/ethernet/atheros/ag71xx/ag71xx_main.c +++ b/target/linux/ar71xx/files/drivers/net/ethernet/atheros/ag71xx/ag71xx_main.c @@ -1051,8 +1051,14 @@ static int ag71xx_rx_packets(struct ag71xx *ag, int limit) pktlen = desc->ctrl & pktlen_mask; pktlen -= ETH_FCS_LEN; - dma_unmap_single(&dev->dev, ring->buf[i].dma_addr, - ag->rx_buf_size, DMA_FROM_DEVICE); + /* + * This is where we'd unmap our buffer from the GMAC in a + * general use of the DMA API. On a MIPS platform this would + * be a complete no-op so we don't bother: + * + * dma_unmap_single(&dev->dev, ring->buf[i].dma_addr, + * ag->rx_buf_size, DMA_FROM_DEVICE); + */ dev->stats.rx_packets++; dev->stats.rx_bytes += pktlen;