From patchwork Mon Dec 4 19:40:22 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rosen Penev X-Patchwork-Id: 844387 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133; helo=bombadil.infradead.org; envelope-from=lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="EBWhf02Q"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="lM3IXtdM"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3yrFcX1NJkz9sCZ for ; Tue, 5 Dec 2017 06:41:32 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Subject:References: In-Reply-To:Message-Id:Date:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3lMEqfH6MxIYbp0+0zsgI8DYedfGXehKOAb3RvsKPgg=; b=EBWhf02Qyv6unA ry+DO1Sq1DfkbaDZcllwf3YGguI0M+If1/od0iEWm9bn/BNoYUnetREUjMZue6PbC1N7y0GS9pC71 OSJtVdKJpGimziPzbWdJNLGKnOoZooAl1IIr0NTRDM1s4rnMnk7qe2NAZZ0SETPSD09bJJsFdbwbp MmRN5Xahgk6KjOwlY4GI9pB7Tt+Fr/JDkGKSFLvoiLM0tmX6xvN3vKhMRNJEBI8/hDRTMKp1jfDjj wsEA7QcYZ97TrYF868yMKRa5BTuJOo61z1wnKmS6/uvnlCnGGxWejqXZtBkMJ+M4A2mAArqF006Ab 5jrf7B2lZFBnP7WWxqLQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1eLwcM-0007fI-Gi; Mon, 04 Dec 2017 19:41:30 +0000 Received: from mail-pf0-x244.google.com ([2607:f8b0:400e:c00::244]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1eLwbm-0007UM-MB for lede-dev@lists.infradead.org; Mon, 04 Dec 2017 19:40:58 +0000 Received: by mail-pf0-x244.google.com with SMTP id j124so9308147pfc.2 for ; Mon, 04 Dec 2017 11:40:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=+t7fRprvv8wS4O+pBQeUBM44tj+bS7Q/w94TINZnN2c=; b=lM3IXtdMcjF/ISjp3chvQOkAWCOu2DGaqmwrNLUZXkobS5u87oYxmvyPYtQ4L6WWLi iH9MhduM2xHef8B+UJx/tUaVOqgBCO8G0sHut5JaMn3/06flU2KOPcvkXk3IJlU+U2ba ruCyaG8xkNlD+G/QgnstnkOyV+FrrMnXmXC8RsbHOTxmzFuX8YfC8qeLqNOU0JBgVrA6 3uInE+DxqpKXHcuHOWl9lHlYIJxEnHHLe9Nm0VxD4qP/V7ORqwE9pC0CRt05usli/R/5 Lk9FX+JOqpVSZTD8lWW0Wh0L0k200sWPyzongA2cecpCWPen76MVsNSNrzUJKfjJwJwv EtOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=+t7fRprvv8wS4O+pBQeUBM44tj+bS7Q/w94TINZnN2c=; b=B+9Ima8GMfmu/zeAOC8I/HNh8yiePt6jGR0V99ppiisVwhPzvGQNOw0key2b79ey8M Ze1vnjdYhL52SNJlJaHr7zNOR5lvlXtg8TpVF3tA29cyaBizf3Mkzu3E9Eat9ontzOhR 5u6gubcCFT5ufjYI3BBhLob8Ql82CHun5Ml7F/bghANdrsl+/KaEKO8vfmYCWRXMR1fV R3vzgV2jKP5gkLyQ7hDbpVRtvEcL2YO+1ivuJ7B6yTqN2EG1jitVV8t8I2/pEmhCJZ7j J7YbscyjzF8xyVWqjQd/fTCz3a5pnHP8DhCRFOROqoSwdy+XA7btvuHMp19CMp08YRlK HFnw== X-Gm-Message-State: AJaThX6DDuC8yFOhWrMaJFz1qQcryBE8M+x+EOukJ5ZvAk/LP3prxw6x Fo8CBDPfzh6x7yr6/3PT/fdymoOn X-Google-Smtp-Source: AGs4zMYgerJ/PaiaKd78eitlOKd9PdP/L+8bkyncznCBJQoe9hB9gu1ZnXPoqobyz9G6y0FR+ZAFnQ== X-Received: by 10.159.195.72 with SMTP id z8mr15530217pln.183.1512416434377; Mon, 04 Dec 2017 11:40:34 -0800 (PST) Received: from DESKTOP-CEH0M93.lan (astound-64-85-248-45.ca.astound.net. [64.85.248.45]) by smtp.gmail.com with ESMTPSA id w3sm22889590pge.59.2017.12.04.11.40.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 04 Dec 2017 11:40:33 -0800 (PST) From: Rosen Penev To: lede-dev@lists.infradead.org Date: Mon, 4 Dec 2017 11:40:22 -0800 Message-Id: <1512416424-629-3-git-send-email-rosenp@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1512416424-629-1-git-send-email-rosenp@gmail.com> References: <1512416424-629-1-git-send-email-rosenp@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20171204_114057_109638_789CDBDF X-CRM114-Status: UNSURE ( 6.69 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -2.0 (--) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-2.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [2607:f8b0:400e:c00:0:0:0:244 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (rosenp[at]gmail.com) -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid Subject: [LEDE-DEV] [PATCH 3/5] ag71xx: Reduce NAPI weight to 32. X-BeenThere: lede-dev@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rosen Penev MIME-Version: 1.0 Sender: "Lede-dev" Errors-To: lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Qualcomm claims this reduces cache misses. Original commit message below: From: Ben Menchaca Date: Tue, 11 Jun 2013 12:18:46 -0500 Subject: [ag71xx] reduce NAPI weight In an attempt to increase our cache warmth, we are decreasing NAPI. This increases the warmth of the reused SKBs. Signed-off-by: Ben Menchaca Signed-off-by: Rosen Penev --- .../ar71xx/files/drivers/net/ethernet/atheros/ag71xx/ag71xx.h | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/target/linux/ar71xx/files/drivers/net/ethernet/atheros/ag71xx/ag71xx.h b/target/linux/ar71xx/files/drivers/net/ethernet/atheros/ag71xx/ag71xx.h index 898bde1..a712812 100644 --- a/target/linux/ar71xx/files/drivers/net/ethernet/atheros/ag71xx/ag71xx.h +++ b/target/linux/ar71xx/files/drivers/net/ethernet/atheros/ag71xx/ag71xx.h @@ -40,7 +40,12 @@ #define AG71XX_DRV_NAME "ag71xx" #define AG71XX_DRV_VERSION "0.5.35" -#define AG71XX_NAPI_WEIGHT 64 +/* + * For our NAPI weight bigger does *NOT* mean better - it means more + * D-cache misses and lots more wasted cycles than we'll ever + * possibly gain from saving instructions. + */ +#define AG71XX_NAPI_WEIGHT 32 #define AG71XX_OOM_REFILL (1 + HZ/10) #define AG71XX_INT_ERR (AG71XX_INT_RX_BE | AG71XX_INT_TX_BE)