From patchwork Sun May 29 23:39:18 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Etienne Champetier X-Patchwork-Id: 627555 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2001:1868:205::9]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3rHx9c45p8z9t3q for ; Mon, 30 May 2016 09:41:56 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=I8jGSHdb; dkim-atps=neutral Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1b7AJC-0007yn-Hq; Sun, 29 May 2016 23:39:50 +0000 Received: from mail-wm0-x243.google.com ([2a00:1450:400c:c09::243]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1b7AJA-0007wB-9f for lede-dev@lists.infradead.org; Sun, 29 May 2016 23:39:49 +0000 Received: by mail-wm0-x243.google.com with SMTP id q62so17580685wmg.3 for ; Sun, 29 May 2016 16:39:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=LMIIlxUzi0B2Bp0RxpR1fXBcF/wchNDQz3rkHvjbkuU=; b=I8jGSHdbW6gLMxLLBrGELeqO1QgXlXD/7DRqzl6Rw/6guy7z9+MPU1akLjaxC69AMJ D994Ze0VxqEEEjDTsV49+b8syJFBodepihib57VAw1fbJiMm0kf6QwFpCYc+qu+Tpvoq l/JOgUvu6VI4rxTpElRj6YQuPu/hdXgn131hKJR5wLjBqBvRLq6vBoBguLmO4zeJDPSs EO/0THzfvu5b/w3iCsupmxDIgIsH199uE5DCGj7MCuQgfmSt3dp6IPlVFQTf24BhJjP8 FFmjjiNHgAcGDJdyRxjsnDAnYQxrfSlyK8iEoLi++IlP63jVQpZjjUxDRal85IK8N74b AP5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=LMIIlxUzi0B2Bp0RxpR1fXBcF/wchNDQz3rkHvjbkuU=; b=KBPBh8ZfgpACQtA5pkC0ibM1saksdi1Y01n9S2fpwkEiVfeT08bKxiD0BykQd2GXPs 0m6VJJliMdorSHIyLMEhXBz9Opt2jneTAK1/LGwf1vZiia109cw9z5H86BQxPrN9Mdt+ kJYm84UwzYeprBG79CguSxcngSvNG7a/NcPaEQhAXafaWUOnAEvahscOgJX8w8Jb/qji By45OpmlZGWPaPFcwYtaA65i12nfPBV4ykTk8DR60J5HU+r+lPwkFfGpLCo+udtzQvFf +mTYhmgm+QJwf/GUUAQqcdNQcTgXaSokTAohH/aYqBWESjG1SG3U8SNmObinEZTnP1rp V40g== X-Gm-Message-State: ALyK8tL8b0x/uhbo44SM24+tEv9oftZkHiKE1wNUKD5yrTWSfcTtXJi7y214G9wU9SUdTw== X-Received: by 10.194.228.102 with SMTP id sh6mr26152333wjc.173.1464565170803; Sun, 29 May 2016 16:39:30 -0700 (PDT) Received: from ubuntu1404.lxcnattst (ns623510.ovh.net. [5.135.134.9]) by smtp.gmail.com with ESMTPSA id 124sm20721292wml.12.2016.05.29.16.39.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 29 May 2016 16:39:29 -0700 (PDT) From: Etienne CHAMPETIER To: lede-dev@lists.infradead.org Date: Sun, 29 May 2016 23:39:18 +0000 Message-Id: <1464565158-18043-7-git-send-email-champetier.etienne@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1464565158-18043-1-git-send-email-champetier.etienne@gmail.com> References: <1464565158-18043-1-git-send-email-champetier.etienne@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160529_163948_535620_B8263F0B X-CRM114-Status: UNSURE ( 9.98 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -2.7 (--) X-Spam-Report: SpamAssassin version 3.4.0 on bombadil.infradead.org summary: Content analysis details: (-2.7 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [2a00:1450:400c:c09:0:0:0:243 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (champetier.etienne[at]gmail.com) -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid Subject: [LEDE-DEV] [PATCH procd 7/7] jail: don't CLONE_NEWUTS if we don't change hostname X-BeenThere: lede-dev@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Etienne CHAMPETIER MIME-Version: 1.0 Sender: "Lede-dev" Errors-To: lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Signed-off-by: Etienne CHAMPETIER --- jail/jail.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/jail/jail.c b/jail/jail.c index e425254..926e42c 100644 --- a/jail/jail.c +++ b/jail/jail.c @@ -386,9 +386,10 @@ int main(int argc, char **argv) uloop_init(); if (opts.namespace) { - jail_process.pid = clone(exec_jail, - child_stack + STACK_SIZE, - CLONE_NEWUTS | CLONE_NEWPID | CLONE_NEWNS | CLONE_NEWIPC | SIGCHLD, NULL); + int flags = CLONE_NEWPID | CLONE_NEWNS | CLONE_NEWIPC | SIGCHLD; + if (opts.hostname) + flags |= CLONE_NEWUTS; + jail_process.pid = clone(exec_jail, child_stack + STACK_SIZE, flags, NULL); } else { jail_process.pid = fork(); }