[v13,73/85] KVM: PPC: Remove extra get_page() to fix page refcount leak

Date: Thu, 10 Oct 2024 11:24:15 -0700
In-Reply-To: <20241010182427.1434605-1-seanjc@google.com>
Mime-Version: 1.0
References: <20241010182427.1434605-1-seanjc@google.com>
Message-ID: <20241010182427.1434605-74-seanjc@google.com>
Subject: [PATCH v13 73/85] KVM: PPC: Remove extra get_page() to fix page
 refcount leak
From: Sean Christopherson <seanjc@google.com>
To: Paolo Bonzini <pbonzini@redhat.com>, Marc Zyngier <maz@kernel.org>,
	Oliver Upton <oliver.upton@linux.dev>,
 Tianrui Zhao <zhaotianrui@loongson.cn>,
	Bibo Mao <maobibo@loongson.cn>, Huacai Chen <chenhuacai@kernel.org>,
	Michael Ellerman <mpe@ellerman.id.au>, Anup Patel <anup@brainfault.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
 Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
 Christian Borntraeger <borntraeger@linux.ibm.com>,
	Janosch Frank <frankja@linux.ibm.com>,
 Claudio Imbrenda <imbrenda@linux.ibm.com>,
	Sean Christopherson <seanjc@google.com>
Cc: kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
  kvmarm@lists.linux.dev, loongarch@lists.linux.dev,
 linux-mips@vger.kernel.org,  linuxppc-dev@lists.ozlabs.org,
 kvm-riscv@lists.infradead.org,  linux-riscv@lists.infradead.org,
 linux-kernel@vger.kernel.org,
  " =?utf-8?q?Alex_Benn=C3=A9e?= " <alex.bennee@linaro.org>,
 Yan Zhao <yan.y.zhao@intel.com>,  David Matlack <dmatlack@google.com>,
 David Stevens <stevensd@chromium.org>,
  Andrew Jones <ajones@ventanamicro.com>
Precedence: list
Reply-To: Sean Christopherson <seanjc@google.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: "kvm-riscv" <kvm-riscv-bounces@lists.infradead.org>
Errors-To: kvm-riscv-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org

Message ID	20241010182427.1434605-74-seanjc@google.com
State	Accepted
Headers	show Return-Path: <kvm-riscv-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org> Date: Thu, 10 Oct 2024 11:24:15 -0700 In-Reply-To: <20241010182427.1434605-1-seanjc@google.com> Mime-Version: 1.0 References: <20241010182427.1434605-1-seanjc@google.com> Message-ID: <20241010182427.1434605-74-seanjc@google.com> Subject: [PATCH v13 73/85] KVM: PPC: Remove extra get_page() to fix page refcount leak From: Sean Christopherson <seanjc@google.com> To: Paolo Bonzini <pbonzini@redhat.com>, Marc Zyngier <maz@kernel.org>, Oliver Upton <oliver.upton@linux.dev>, Tianrui Zhao <zhaotianrui@loongson.cn>, Bibo Mao <maobibo@loongson.cn>, Huacai Chen <chenhuacai@kernel.org>, Michael Ellerman <mpe@ellerman.id.au>, Anup Patel <anup@brainfault.org>, Paul Walmsley <paul.walmsley@sifive.com>, Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>, Christian Borntraeger <borntraeger@linux.ibm.com>, Janosch Frank <frankja@linux.ibm.com>, Claudio Imbrenda <imbrenda@linux.ibm.com>, Sean Christopherson <seanjc@google.com> Cc: kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, " =?utf-8?q?Alex_Benn=C3=A9e?= " <alex.bennee@linaro.org>, Yan Zhao <yan.y.zhao@intel.com>, David Matlack <dmatlack@google.com>, David Stevens <stevensd@chromium.org>, Andrew Jones <ajones@ventanamicro.com> preview: Don't manually do get_page() when patching dcbz, as gfn_to_page() gifts the caller a reference. I.e. doing get_page() will leak the page due to not putting all references. Signed-off-by: Sean Christopherson <seanjc@google.com> --- arch/powerpc/kvm/book3s_pr.c \| 1 - 1 file changed, 1 deletion(-) Content analysis details: (-9.5 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:549 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -7.5 USER_IN_DEF_DKIM_WL From: address is in the default DKIM welcome-list -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.0 DKIMWL_WL_MED DKIMwl.org - Medium trust sender Precedence: list Reply-To: Sean Christopherson <seanjc@google.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kvm-riscv" <kvm-riscv-bounces@lists.infradead.org> Errors-To: kvm-riscv-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org
Series	KVM: Stop grabbing references to PFNMAP'd pages \| expand [v13,00/85] KVM: Stop grabbing references to PFNMAP'd pages [v13,01/85] KVM: Drop KVM_ERR_PTR_BAD_PAGE and instead return NULL to indicate an error [v13,02/85] KVM: Allow calling kvm_release_page_{clean,dirty}() on a NULL page pointer [v13,03/85] KVM: Add kvm_release_page_unused() API to put pages that KVM never consumes [v13,04/85] KVM: x86/mmu: Skip the "try unsync" path iff the old SPTE was a leaf SPTE [v13,05/85] KVM: x86/mmu: Don't overwrite shadow-present MMU SPTEs when prefaulting [v13,06/85] KVM: x86/mmu: Invert @can_unsync and renamed to @synchronizing [v13,07/85] KVM: x86/mmu: Mark new SPTE as Accessed when synchronizing existing SPTE [v13,08/85] KVM: x86/mmu: Mark folio dirty when creating SPTE, not when zapping/modifying [v13,09/85] KVM: x86/mmu: Mark page/folio accessed only when zapping leaf SPTEs [v13,10/85] KVM: x86/mmu: Use gfn_to_page_many_atomic() when prefetching indirect PTEs [v13,11/85] KVM: Rename gfn_to_page_many_atomic() to kvm_prefetch_pages() [v13,12/85] KVM: Drop @atomic param from gfn=>pfn and hva=>pfn APIs [v13,13/85] KVM: Annotate that all paths in hva_to_pfn() might sleep [v13,14/85] KVM: Return ERR_SIGPENDING from hva_to_pfn() if GUP returns -EGAIN [v13,15/85] KVM: Drop extra GUP (via check_user_page_hwpoison()) to detect poisoned page [v13,16/85] KVM: Replace "async" pointer in gfn=>pfn with "no_wait" and error code [v13,17/85] KVM: x86/mmu: Drop kvm_page_fault.hva, i.e. don't track intermediate hva [v13,18/85] KVM: Drop unused "hva" pointer from __gfn_to_pfn_memslot() [v13,19/85] KVM: Introduce kvm_follow_pfn() to eventually replace "gfn_to_pfn" APIs [v13,20/85] KVM: Remove pointless sanity check on @map param to kvm_vcpu_(un)map() [v13,21/85] KVM: Explicitly initialize all fields at the start of kvm_vcpu_map() [v13,22/85] KVM: Use NULL for struct page pointer to indicate mremapped memory [v13,23/85] KVM: nVMX: Rely on kvm_vcpu_unmap() to track validity of eVMCS mapping [v13,24/85] KVM: nVMX: Drop pointless msr_bitmap_map field from struct nested_vmx [v13,25/85] KVM: nVMX: Add helper to put (unmap) vmcs12 pages [v13,26/85] KVM: Use plain "struct page" pointer instead of single-entry array [v13,27/85] KVM: Provide refcounted page as output field in struct kvm_follow_pfn [v13,28/85] KVM: Move kvm_{set,release}_page_{clean,dirty}() helpers up in kvm_main.c [v13,29/85] KVM: pfncache: Precisely track refcounted pages [v13,30/85] KVM: Migrate kvm_vcpu_map() to kvm_follow_pfn() [v13,31/85] KVM: Pin (as in FOLL_PIN) pages during kvm_vcpu_map() [v13,32/85] KVM: nVMX: Mark vmcs12's APIC access page dirty when unmapping [v13,33/85] KVM: Pass in write/dirty to kvm_vcpu_map(), not kvm_vcpu_unmap() [v13,34/85] KVM: Get writable mapping for __kvm_vcpu_map() only when necessary [v13,35/85] KVM: Disallow direct access (w/o mmu_notifier) to unpinned pfn by default [v13,36/85] KVM: x86: Don't fault-in APIC access page during initial allocation [v13,37/85] KVM: x86/mmu: Add "mmu" prefix fault-in helpers to free up generic names [v13,38/85] KVM: x86/mmu: Put direct prefetched pages via kvm_release_page_clean() [v13,39/85] KVM: x86/mmu: Add common helper to handle prefetching SPTEs [v13,40/85] KVM: x86/mmu: Add helper to "finish" handling a guest page fault [v13,41/85] KVM: x86/mmu: Mark pages/folios dirty at the origin of make_spte() [v13,42/85] KVM: Move declarations of memslot accessors up in kvm_host.h [v13,43/85] KVM: Add kvm_faultin_pfn() to specifically service guest page faults [v13,44/85] KVM: x86/mmu: Convert page fault paths to kvm_faultin_pfn() [v13,45/85] KVM: guest_memfd: Pass index, not gfn, to __kvm_gmem_get_pfn() [v13,46/85] KVM: guest_memfd: Provide "struct page" as output from kvm_gmem_get_pfn() [v13,47/85] KVM: x86/mmu: Put refcounted pages instead of blindly releasing pfns [v13,48/85] KVM: x86/mmu: Don't mark unused faultin pages as accessed [v13,49/85] KVM: Move x86's API to release a faultin page to common KVM [v13,50/85] KVM: VMX: Hold mmu_lock until page is released when updating APIC access page [v13,51/85] KVM: VMX: Use __kvm_faultin_page() to get APIC access page/pfn [v13,52/85] KVM: PPC: e500: Mark "struct page" dirty in kvmppc_e500_shadow_map() [v13,53/85] KVM: PPC: e500: Mark "struct page" pfn accessed before dropping mmu_lock [v13,54/85] KVM: PPC: e500: Use __kvm_faultin_pfn() to handle page faults [v13,55/85] KVM: arm64: Mark "struct page" pfns accessed/dirty before dropping mmu_lock [v13,56/85] KVM: arm64: Use __kvm_faultin_pfn() to handle memory aborts [v13,57/85] KVM: RISC-V: Mark "struct page" pfns dirty iff a stage-2 PTE is installed [v13,58/85] KVM: RISC-V: Mark "struct page" pfns accessed before dropping mmu_lock [v13,59/85] KVM: RISC-V: Use kvm_faultin_pfn() when mapping pfns into the guest [v13,60/85] KVM: PPC: Use __kvm_faultin_pfn() to handle page faults on Book3s HV [v13,61/85] KVM: PPC: Use __kvm_faultin_pfn() to handle page faults on Book3s Radix [v13,62/85] KVM: PPC: Drop unused @kvm_ro param from kvmppc_book3s_instantiate_page() [v13,63/85] KVM: PPC: Book3S: Mark "struct page" pfns dirty/accessed after installing PTE [v13,64/85] KVM: PPC: Use kvm_faultin_pfn() to handle page faults on Book3s PR [v13,65/85] KVM: LoongArch: Mark "struct page" pfns dirty only in "slow" page fault path [v13,66/85] KVM: LoongArch: Mark "struct page" pfns accessed only in "slow" page fault path [v13,67/85] KVM: LoongArch: Mark "struct page" pfn accessed before dropping mmu_lock [v13,68/85] KVM: LoongArch: Use kvm_faultin_pfn() to map pfns into the guest [v13,69/85] KVM: MIPS: Mark "struct page" pfns dirty only in "slow" page fault path [v13,70/85] KVM: MIPS: Mark "struct page" pfns accessed only in "slow" page fault path [v13,71/85] KVM: MIPS: Mark "struct page" pfns accessed prior to dropping mmu_lock [v13,72/85] KVM: MIPS: Use kvm_faultin_pfn() to map pfns into the guest [v13,73/85] KVM: PPC: Remove extra get_page() to fix page refcount leak [v13,74/85] KVM: PPC: Use kvm_vcpu_map() to map guest memory to patch dcbz instructions [v13,75/85] KVM: Convert gfn_to_page() to use kvm_follow_pfn() [v13,76/85] KVM: Add support for read-only usage of gfn_to_page() [v13,77/85] KVM: arm64: Use __gfn_to_page() when copying MTE tags to/from userspace [v13,78/85] KVM: PPC: Explicitly require struct page memory for Ultravisor sharing [v13,79/85] KVM: Drop gfn_to_pfn() APIs now that all users are gone [v13,80/85] KVM: s390: Use kvm_release_page_dirty() to unpin "struct page" memory [v13,81/85] KVM: Make kvm_follow_pfn.refcounted_page a required field [v13,82/85] KVM: x86/mmu: Don't mark "struct page" accessed when zapping SPTEs [v13,83/85] KVM: arm64: Don't mark "struct page" accessed when making SPTE young [v13,84/85] KVM: Drop APIs that manipulate "struct page" via pfns [v13,85/85] KVM: Don't grab reference on VM_MIXEDMAP pfns that have a "struct page"

[v13,73/85] KVM: PPC: Remove extra get_page() to fix page refcount leak

Commit Message

Patch