| Message ID | 20240524103307.2684-3-yongxuan.wang@sifive.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Add Svadu Extension Support | expand |
On Fri, May 24, 2024 at 06:33:02PM +0800, Yong-Xuan Wang wrote: > Add an entry for the Svadu extension to the riscv,isa-extensions property. > > Signed-off-by: Yong-Xuan Wang <yongxuan.wang@sifive.com> > Acked-by: Conor Dooley <conor.dooley@microchip.com> > Reviewed-by: Andrew Jones <ajones@ventanamicro.com> I'm going to un-ack this, not because you did something wrong per se, but because there's some discussion on the OpenSBI list about what is and what is not backwards compatible and how an OS should interpret svade and svadu: https://lists.infradead.org/pipermail/opensbi/2024-May/006949.html Thanks, Conor. > --- > Documentation/devicetree/bindings/riscv/extensions.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/riscv/extensions.yaml b/Documentation/devicetree/bindings/riscv/extensions.yaml > index 468c646247aa..598a5841920f 100644 > --- a/Documentation/devicetree/bindings/riscv/extensions.yaml > +++ b/Documentation/devicetree/bindings/riscv/extensions.yaml > @@ -153,6 +153,12 @@ properties: > ratified at commit 3f9ed34 ("Add ability to manually trigger > workflow. (#2)") of riscv-time-compare. > > + - const: svadu > + description: | > + The standard Svadu supervisor-level extension for hardware updating > + of PTE A/D bits as ratified at commit c1abccf ("Merge pull request > + #25 from ved-rivos/ratified") of riscv-svadu. > + > - const: svinval > description: > The standard Svinval supervisor-level extension for fine-grained > -- > 2.17.1 >
Hi Conor, On Mon, May 27, 2024 at 11:09 PM Conor Dooley <conor@kernel.org> wrote: > > On Fri, May 24, 2024 at 06:33:02PM +0800, Yong-Xuan Wang wrote: > > Add an entry for the Svadu extension to the riscv,isa-extensions property. > > > > Signed-off-by: Yong-Xuan Wang <yongxuan.wang@sifive.com> > > Acked-by: Conor Dooley <conor.dooley@microchip.com> > > Reviewed-by: Andrew Jones <ajones@ventanamicro.com> > > I'm going to un-ack this, not because you did something wrong per se, > but because there's some discussion on the OpenSBI list about what is > and what is not backwards compatible and how an OS should interpret > svade and svadu: > https://lists.infradead.org/pipermail/opensbi/2024-May/006949.html > > Thanks, > Conor. > ok. I will remove it in the next version. Regards, Yong-Xuan > > --- > > Documentation/devicetree/bindings/riscv/extensions.yaml | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/riscv/extensions.yaml b/Documentation/devicetree/bindings/riscv/extensions.yaml > > index 468c646247aa..598a5841920f 100644 > > --- a/Documentation/devicetree/bindings/riscv/extensions.yaml > > +++ b/Documentation/devicetree/bindings/riscv/extensions.yaml > > @@ -153,6 +153,12 @@ properties: > > ratified at commit 3f9ed34 ("Add ability to manually trigger > > workflow. (#2)") of riscv-time-compare. > > > > + - const: svadu > > + description: | > > + The standard Svadu supervisor-level extension for hardware updating > > + of PTE A/D bits as ratified at commit c1abccf ("Merge pull request > > + #25 from ved-rivos/ratified") of riscv-svadu. > > + > > - const: svinval > > description: > > The standard Svinval supervisor-level extension for fine-grained > > -- > > 2.17.1 > >
diff --git a/Documentation/devicetree/bindings/riscv/extensions.yaml b/Documentation/devicetree/bindings/riscv/extensions.yaml index 468c646247aa..598a5841920f 100644 --- a/Documentation/devicetree/bindings/riscv/extensions.yaml +++ b/Documentation/devicetree/bindings/riscv/extensions.yaml @@ -153,6 +153,12 @@ properties: ratified at commit 3f9ed34 ("Add ability to manually trigger workflow. (#2)") of riscv-time-compare. + - const: svadu + description: | + The standard Svadu supervisor-level extension for hardware updating + of PTE A/D bits as ratified at commit c1abccf ("Merge pull request + #25 from ved-rivos/ratified") of riscv-svadu. + - const: svinval description: The standard Svinval supervisor-level extension for fine-grained