| Message ID | 20160714101545.GB18175@mwanda |
|---|---|
| State | Accepted |
| Headers | show |
On 07/14/2016 12:15 PM, Dan Carpenter wrote: > We use logical negate where bitwise negate was intended. It means that > we never return -EINVAL here. > > Fixes: ce11e48b7fdd ('KVM: PPC: E500: Add userspace debug stub support') > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Oops :). Reviewed-by: Alexander Graf <agraf@suse.de> Alex -- To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Jul 14, 2016 at 01:15:46PM +0300, Dan Carpenter wrote: > We use logical negate where bitwise negate was intended. It means that > we never return -EINVAL here. > > Fixes: ce11e48b7fdd ('KVM: PPC: E500: Add userspace debug stub support') > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Thanks, applied to kvm-ppc-next. Paul. -- To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/powerpc/kvm/booke.c b/arch/powerpc/kvm/booke.c index 02b4672..df3f270 100644 --- a/arch/powerpc/kvm/booke.c +++ b/arch/powerpc/kvm/booke.c @@ -2038,7 +2038,7 @@ int kvm_arch_vcpu_ioctl_set_guest_debug(struct kvm_vcpu *vcpu, if (type == KVMPPC_DEBUG_NONE) continue; - if (type & !(KVMPPC_DEBUG_WATCH_READ | + if (type & ~(KVMPPC_DEBUG_WATCH_READ | KVMPPC_DEBUG_WATCH_WRITE | KVMPPC_DEBUG_BREAKPOINT)) return -EINVAL;
We use logical negate where bitwise negate was intended. It means that we never return -EINVAL here. Fixes: ce11e48b7fdd ('KVM: PPC: E500: Add userspace debug stub support') Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> -- To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html