diff mbox

booke/powerpc: define wimge shift mask to fix compilation error

Message ID 1399957511-28657-1-git-send-email-Bharat.Bhushan@freescale.com
State New, archived
Headers show

Commit Message

Bharat Bhushan May 13, 2014, 5:05 a.m. UTC
This fixes below compilation error on SOCs where CONFIG_PHYS_64BIT
is not defined:

 arch/powerpc/kvm/e500_mmu_host.c: In function 'kvmppc_e500_shadow_map':
| arch/powerpc/kvm/e500_mmu_host.c:631:20: error: 'PTE_WIMGE_SHIFT' undeclared (first use in this function)
|    wimg = (*ptep >> PTE_WIMGE_SHIFT) & MAS2_WIMGE_MASK;
|                     ^
| arch/powerpc/kvm/e500_mmu_host.c:631:20: note: each undeclared identifier is reported only once for each function it appears in
| make[1]: *** [arch/powerpc/kvm/e500_mmu_host.o] Error 1

Signed-off-by: Bharat Bhushan <Bharat.Bhushan@freescale.com>
---
 arch/powerpc/include/asm/pte-fsl-booke.h |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

Comments

Alexander Graf May 13, 2014, 5:47 a.m. UTC | #1
> Am 13.05.2014 um 07:05 schrieb Bharat Bhushan <r65777@freescale.com>:
> 
> This fixes below compilation error on SOCs where CONFIG_PHYS_64BIT
> is not defined:
> 
> arch/powerpc/kvm/e500_mmu_host.c: In function 'kvmppc_e500_shadow_map':
> | arch/powerpc/kvm/e500_mmu_host.c:631:20: error: 'PTE_WIMGE_SHIFT' undeclared (first use in this function)
> |    wimg = (*ptep >> PTE_WIMGE_SHIFT) & MAS2_WIMGE_MASK;
> |                     ^
> | arch/powerpc/kvm/e500_mmu_host.c:631:20: note: each undeclared identifier is reported only once for each function it appears in
> | make[1]: *** [arch/powerpc/kvm/e500_mmu_host.o] Error 1
> 
> Signed-off-by: Bharat Bhushan <Bharat.Bhushan@freescale.com>

This should go to the normal Linux PPC list, no?

Alex

> ---
> arch/powerpc/include/asm/pte-fsl-booke.h |    2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/powerpc/include/asm/pte-fsl-booke.h b/arch/powerpc/include/asm/pte-fsl-booke.h
> index 2c12be5..e84dd7e 100644
> --- a/arch/powerpc/include/asm/pte-fsl-booke.h
> +++ b/arch/powerpc/include/asm/pte-fsl-booke.h
> @@ -37,5 +37,7 @@
> #define _PMD_PRESENT_MASK (PAGE_MASK)
> #define _PMD_BAD    (~PAGE_MASK)
> 
> +#define PTE_WIMGE_SHIFT (6)
> +
> #endif /* __KERNEL__ */
> #endif /*  _ASM_POWERPC_PTE_FSL_BOOKE_H */
> -- 
> 1.7.0.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Bharat Bhushan May 13, 2014, 6:35 a.m. UTC | #2
> -----Original Message-----
> From: Alexander Graf [mailto:agraf@suse.de]
> Sent: Tuesday, May 13, 2014 11:18 AM
> To: Bhushan Bharat-R65777
> Cc: <kvm-ppc@vger.kernel.org>; <kvm@vger.kernel.org>; Wood Scott-B07421; Bhushan
> Bharat-R65777
> Subject: Re: [PATCH] booke/powerpc: define wimge shift mask to fix compilation
> error
> 
> 
> 
> > Am 13.05.2014 um 07:05 schrieb Bharat Bhushan <r65777@freescale.com>:
> >
> > This fixes below compilation error on SOCs where CONFIG_PHYS_64BIT is
> > not defined:
> >
> > arch/powerpc/kvm/e500_mmu_host.c: In function 'kvmppc_e500_shadow_map':
> > | arch/powerpc/kvm/e500_mmu_host.c:631:20: error: 'PTE_WIMGE_SHIFT' undeclared
> (first use in this function)
> > |    wimg = (*ptep >> PTE_WIMGE_SHIFT) & MAS2_WIMGE_MASK;
> > |                     ^
> > | arch/powerpc/kvm/e500_mmu_host.c:631:20: note: each undeclared
> > | identifier is reported only once for each function it appears in
> > | make[1]: *** [arch/powerpc/kvm/e500_mmu_host.o] Error 1
> >
> > Signed-off-by: Bharat Bhushan <Bharat.Bhushan@freescale.com>
> 
> This should go to the normal Linux PPC list, no?

I was not sure when sending this fix as this fixes issue for KVM build but code changes are in generic files :)
No I will send on  linuxppc-dev@lists.ozlabs.org 

Thanks
-Bharat

> 
> Alex
> 
> > ---
> > arch/powerpc/include/asm/pte-fsl-booke.h |    2 ++
> > 1 files changed, 2 insertions(+), 0 deletions(-)
> >
> > diff --git a/arch/powerpc/include/asm/pte-fsl-booke.h
> > b/arch/powerpc/include/asm/pte-fsl-booke.h
> > index 2c12be5..e84dd7e 100644
> > --- a/arch/powerpc/include/asm/pte-fsl-booke.h
> > +++ b/arch/powerpc/include/asm/pte-fsl-booke.h
> > @@ -37,5 +37,7 @@
> > #define _PMD_PRESENT_MASK (PAGE_MASK)
> > #define _PMD_BAD    (~PAGE_MASK)
> >
> > +#define PTE_WIMGE_SHIFT (6)
> > +
> > #endif /* __KERNEL__ */
> > #endif /*  _ASM_POWERPC_PTE_FSL_BOOKE_H */
> > --
> > 1.7.0.4
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in
> > the body of a message to majordomo@vger.kernel.org More majordomo info
> > at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/arch/powerpc/include/asm/pte-fsl-booke.h b/arch/powerpc/include/asm/pte-fsl-booke.h
index 2c12be5..e84dd7e 100644
--- a/arch/powerpc/include/asm/pte-fsl-booke.h
+++ b/arch/powerpc/include/asm/pte-fsl-booke.h
@@ -37,5 +37,7 @@ 
 #define _PMD_PRESENT_MASK (PAGE_MASK)
 #define _PMD_BAD	(~PAGE_MASK)
 
+#define PTE_WIMGE_SHIFT (6)
+
 #endif /* __KERNEL__ */
 #endif /*  _ASM_POWERPC_PTE_FSL_BOOKE_H */