| Message ID | 6951d217-ac06-4482-a35d-15d757fd90a3@stanley.mountain |
|---|---|
| State | Handled Elsewhere |
| Headers | show |
| Series | [net-next] ice: Fix a NULL vs IS_ERR() check in probe() | expand |
On Sat, Sep 14, 2024 at 12:57:56PM +0300, Dan Carpenter wrote: > The ice_allocate_sf() function returns error pointers on error. It > doesn't return NULL. Update the check to match. > > Fixes: 177ef7f1e2a0 ("ice: base subfunction aux driver") > Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Reviewed-by: Simon Horman <horms@kernel.org>
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Sat, 14 Sep 2024 12:57:56 +0300 you wrote: > The ice_allocate_sf() function returns error pointers on error. It > doesn't return NULL. Update the check to match. > > Fixes: 177ef7f1e2a0 ("ice: base subfunction aux driver") > Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> > --- > drivers/net/ethernet/intel/ice/ice_sf_eth.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Here is the summary with links: - [net-next] ice: Fix a NULL vs IS_ERR() check in probe() https://git.kernel.org/netdev/net-next/c/472d455e7c6f You are awesome, thank you!
diff --git a/drivers/net/ethernet/intel/ice/ice_sf_eth.c b/drivers/net/ethernet/intel/ice/ice_sf_eth.c index d00389c405c4..75d7147e1c01 100644 --- a/drivers/net/ethernet/intel/ice/ice_sf_eth.c +++ b/drivers/net/ethernet/intel/ice/ice_sf_eth.c @@ -108,9 +108,9 @@ static int ice_sf_dev_probe(struct auxiliary_device *adev, vsi->flags = ICE_VSI_FLAG_INIT; priv = ice_allocate_sf(&adev->dev, pf); - if (!priv) { + if (IS_ERR(priv)) { dev_err(dev, "Subfunction devlink alloc failed"); - return -ENOMEM; + return PTR_ERR(priv); } priv->dev = sf_dev;
The ice_allocate_sf() function returns error pointers on error. It doesn't return NULL. Update the check to match. Fixes: 177ef7f1e2a0 ("ice: base subfunction aux driver") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> --- drivers/net/ethernet/intel/ice/ice_sf_eth.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)