| Message ID | 20241104124050.22290-1-wander@redhat.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Anthony Nguyen |
| Headers | show |
| Series | Revert "igb: Disable threaded IRQ for igb_msix_other" | expand |
On Mon, 4 Nov 2024 09:40:50 -0300 Wander Lairson Costa wrote: > This reverts commit 338c4d3902feb5be49bfda530a72c7ab860e2c9f. > > Sebastian noticed the ISR indirectly acquires spin_locks, which are > sleeping locks under PREEMPT_RT, which leads to kernel splats. > > Signed-off-by: Wander Lairson Costa <wander@redhat.com> > Reported-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> Please resend with the reverted commit added as a Fixes tag. Also - your sign off should be the last tag.
diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c index b83df5f94b1f..f1d088168723 100644 --- a/drivers/net/ethernet/intel/igb/igb_main.c +++ b/drivers/net/ethernet/intel/igb/igb_main.c @@ -907,7 +907,7 @@ static int igb_request_msix(struct igb_adapter *adapter) int i, err = 0, vector = 0, free_vector = 0; err = request_irq(adapter->msix_entries[vector].vector, - igb_msix_other, IRQF_NO_THREAD, netdev->name, adapter); + igb_msix_other, 0, netdev->name, adapter); if (err) goto err_out;
This reverts commit 338c4d3902feb5be49bfda530a72c7ab860e2c9f. Sebastian noticed the ISR indirectly acquires spin_locks, which are sleeping locks under PREEMPT_RT, which leads to kernel splats. Signed-off-by: Wander Lairson Costa <wander@redhat.com> Reported-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> --- drivers/net/ethernet/intel/igb/igb_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)