diff mbox series

[RESEND,iwl-next] ice: Unbind the workqueue

Message ID 20241007214408.501013-1-anthony.l.nguyen@intel.com
State Accepted
Delegated to: Anthony Nguyen
Headers show
Series [RESEND,iwl-next] ice: Unbind the workqueue | expand

Commit Message

Tony Nguyen Oct. 7, 2024, 9:44 p.m. UTC
From: Frederic Weisbecker <frederic@kernel.org>

The ice workqueue doesn't seem to rely on any CPU locality and should
therefore be able to run on any CPU. In practice this is already
happening through the unbound ice_service_timer that may fire anywhere
and queue the workqueue accordingly to any CPU.

Make this official so that the ice workqueue is only ever queued to
housekeeping CPUs on nohz_full.

Signed-off-by: Frederic Weisbecker <frederic@kernel.org>
---
Resend of: https://lore.kernel.org/all/20240922222420.18009-1-frederic@kernel.org/
- Added IWL and netdev lists

 drivers/net/ethernet/intel/ice/ice_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Pucha, HimasekharX Reddy Oct. 17, 2024, 4:40 p.m. UTC | #1
> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of Tony Nguyen
> Sent: Tuesday, October 8, 2024 3:14 AM
> To: intel-wired-lan@lists.osuosl.org
> Cc: Kitszel, Przemyslaw <przemyslaw.kitszel@intel.com>; Frederic Weisbecker <frederic@kernel.org>; netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Zaremba, Larysa <larysa.zaremba@intel.com>
> Subject: [Intel-wired-lan] [RESEND PATCH iwl-next] ice: Unbind the workqueue
>
> From: Frederic Weisbecker <frederic@kernel.org>
>
> The ice workqueue doesn't seem to rely on any CPU locality and should therefore be able to run on any CPU. In practice this is already happening through the unbound ice_service_timer that may fire anywhere and queue the workqueue accordingly to any CPU.
>
> Make this official so that the ice workqueue is only ever queued to housekeeping CPUs on nohz_full.
>
> Signed-off-by: Frederic Weisbecker <frederic@kernel.org>
> ---
> Resend of: https://lore.kernel.org/all/20240922222420.18009-1-frederic@kernel.org/
> - Added IWL and netdev lists
>
>  drivers/net/ethernet/intel/ice/ice_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel.com> (A Contingent worker at Intel)
diff mbox series

Patch

diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c
index 179631921611..b819e7f9d97d 100644
--- a/drivers/net/ethernet/intel/ice/ice_main.c
+++ b/drivers/net/ethernet/intel/ice/ice_main.c
@@ -5904,7 +5904,7 @@  static int __init ice_module_init(void)
 
 	ice_adv_lnk_speed_maps_init();
 
-	ice_wq = alloc_workqueue("%s", 0, 0, KBUILD_MODNAME);
+	ice_wq = alloc_workqueue("%s", WQ_UNBOUND, 0, KBUILD_MODNAME);
 	if (!ice_wq) {
 		pr_err("Failed to create workqueue\n");
 		return status;