diff mbox series

[iwl-next] ice: fix BST key index in ice_bst_key_init()

Message ID 20240823230847.172295-1-ahmed.zaki@intel.com
State Superseded
Delegated to: Anthony Nguyen
Headers show
Series [iwl-next] ice: fix BST key index in ice_bst_key_init() | expand

Commit Message

Ahmed Zaki Aug. 23, 2024, 11:08 p.m. UTC 
Index of the BST keys was wrongly initialized to a larger value, a
possible buffer overflow.

Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/intel-wired-lan/b1fb6ff9-b69e-4026-9988-3c783d86c2e0@stanley.mountain/
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Fixes: 9a4c07aaa0f5 ("ice: add parser execution main loop")
Signed-off-by: Ahmed Zaki <ahmed.zaki@intel.com>
---
 drivers/net/ethernet/intel/ice/ice_parser_rt.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff mbox series

Patch

diff --git a/drivers/net/ethernet/intel/ice/ice_parser_rt.c b/drivers/net/ethernet/intel/ice/ice_parser_rt.c
index d5bcc266b01e..c24e651ccf9d 100644
--- a/drivers/net/ethernet/intel/ice/ice_parser_rt.c
+++ b/drivers/net/ethernet/intel/ice/ice_parser_rt.c
@@ -119,13 +119,13 @@  static void ice_bst_key_init(struct ice_parser_rt *rt,
 	u8 *key = rt->bst_key;
 	int idd, i;
 
-	idd = ICE_BST_TCAM_KEY_SIZE - 1;
+	idd = ICE_BST_KEY_SIZE - 1;
 	if (imem->b_kb.tsr_ctrl)
 		key[idd] = tsr;
 	else
 		key[idd] = imem->b_kb.prio;
 
-	idd = ICE_BST_KEY_TCAM_SIZE - 1;
+	idd = ICE_BST_KEY_SIZE - 1;
 	for (i = idd; i >= 0; i--) {
 		int j;