| Message ID | 20240612154607.131914-1-poros@redhat.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | ice: use proper macro for testing bit | expand |
On 12. 06. 24 17:46, Petr Oros wrote: > Do not use _test_bit() macro for testing bit. The proper macro for this > is one without underline. > > Fixes: 4da71a77fc3b ("ice: read internal temperature sensor") > Signed-off-by: Petr Oros <poros@redhat.com> > --- > drivers/net/ethernet/intel/ice/ice_hwmon.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/intel/ice/ice_hwmon.c b/drivers/net/ethernet/intel/ice/ice_hwmon.c > index e4c2c1bff6c086..b7aa6812510a4f 100644 > --- a/drivers/net/ethernet/intel/ice/ice_hwmon.c > +++ b/drivers/net/ethernet/intel/ice/ice_hwmon.c > @@ -96,7 +96,7 @@ static bool ice_is_internal_reading_supported(struct ice_pf *pf) > > unsigned long sensors = pf->hw.dev_caps.supported_sensors; > > - return _test_bit(ICE_SENSOR_SUPPORT_E810_INT_TEMP_BIT, &sensors); > + return test_bit(ICE_SENSOR_SUPPORT_E810_INT_TEMP_BIT, &sensors); > }; > > void ice_hwmon_init(struct ice_pf *pf) Acked-by: Ivan Vecera <ivecera@redhat.com>
diff --git a/drivers/net/ethernet/intel/ice/ice_hwmon.c b/drivers/net/ethernet/intel/ice/ice_hwmon.c index e4c2c1bff6c086..b7aa6812510a4f 100644 --- a/drivers/net/ethernet/intel/ice/ice_hwmon.c +++ b/drivers/net/ethernet/intel/ice/ice_hwmon.c @@ -96,7 +96,7 @@ static bool ice_is_internal_reading_supported(struct ice_pf *pf) unsigned long sensors = pf->hw.dev_caps.supported_sensors; - return _test_bit(ICE_SENSOR_SUPPORT_E810_INT_TEMP_BIT, &sensors); + return test_bit(ICE_SENSOR_SUPPORT_E810_INT_TEMP_BIT, &sensors); }; void ice_hwmon_init(struct ice_pf *pf)
Do not use _test_bit() macro for testing bit. The proper macro for this is one without underline. Fixes: 4da71a77fc3b ("ice: read internal temperature sensor") Signed-off-by: Petr Oros <poros@redhat.com> --- drivers/net/ethernet/intel/ice/ice_hwmon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)