diff mbox series

[net-next] eth: igc: remove unused embedded struct net_device

Message ID 20240301070255.3108375-1-kuba@kernel.org
State Handled Elsewhere
Headers show
Series [net-next] eth: igc: remove unused embedded struct net_device | expand

Commit Message

Jakub Kicinski March 1, 2024, 7:02 a.m. UTC 
struct net_device poll_dev in struct igc_q_vector was added
in one of the initial commits, but never used.

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
CC: jesse.brandeburg@intel.com
CC: anthony.l.nguyen@intel.com
---
 drivers/net/ethernet/intel/igc/igc.h | 1 -
 1 file changed, 1 deletion(-)

Comments

Eric Dumazet March 1, 2024, 7:59 a.m. UTC | #1 
On Fri, Mar 1, 2024 at 8:03 AM Jakub Kicinski <kuba@kernel.org> wrote:
>
> struct net_device poll_dev in struct igc_q_vector was added
> in one of the initial commits, but never used.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>

Reviewed-by: Eric Dumazet <edumazet@google.com>
Jesse Brandeburg March 1, 2024, 4:54 p.m. UTC | #2 
On 2/29/2024 11:02 PM, Jakub Kicinski wrote:
> struct net_device poll_dev in struct igc_q_vector was added
> in one of the initial commits, but never used.
> 
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>

Thanks Jakub, you can just apply this directly AFAICS.

Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
patchwork-bot+netdevbpf@kernel.org March 4, 2024, 10:10 a.m. UTC | #3 
Hello:

This patch was applied to netdev/net-next.git (main)
by David S. Miller <davem@davemloft.net>:

On Thu, 29 Feb 2024 23:02:55 -0800 you wrote:
> struct net_device poll_dev in struct igc_q_vector was added
> in one of the initial commits, but never used.
> 
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> CC: jesse.brandeburg@intel.com
> CC: anthony.l.nguyen@intel.com
> 
> [...]

Here is the summary with links:
  - [net-next] eth: igc: remove unused embedded struct net_device
    https://git.kernel.org/netdev/net-next/c/c2a22688c931

You are awesome, thank you!
diff mbox series

Patch

diff --git a/drivers/net/ethernet/intel/igc/igc.h b/drivers/net/ethernet/intel/igc/igc.h
index cfa6baccec55..90316dc58630 100644
--- a/drivers/net/ethernet/intel/igc/igc.h
+++ b/drivers/net/ethernet/intel/igc/igc.h
@@ -570,7 +570,6 @@  struct igc_q_vector {
 
 	struct rcu_head rcu;    /* to avoid race with update stats on free */
 	char name[IFNAMSIZ + 9];
-	struct net_device poll_dev;
 
 	/* for dynamic allocation of rings associated with this q_vector */
 	struct igc_ring ring[] ____cacheline_internodealigned_in_smp;