From patchwork Wed Jan 24 05:57:00 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sasha Neftin X-Patchwork-Id: 1890011 X-Patchwork-Delegate: anthony.l.nguyen@intel.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256 header.s=default header.b=daTcXm3z; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org (client-ip=140.211.166.136; helo=smtp3.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver=patchwork.ozlabs.org) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4TKYD54BXgz23dy for ; Wed, 24 Jan 2024 16:58:29 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id D0BC161458; Wed, 24 Jan 2024 05:58:27 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org D0BC161458 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1706075907; bh=cAOdK34H/NLVB4G7B010oL5Wl2cqO3ZOiOpWvSxI0Ak=; h=From:To:Date:Subject:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:Cc:From; b=daTcXm3zsPPHOIybCRBMDJYztZzWwCbhn+ogeMp/2u5XWd7DL7fjwKGV8lq74LTz0 oUkxwkYk2J0rz4SmSjSS38NxIiDBE04JEGrW9YlfG6QXYvzop8UCqXRh8/gyA4apaE A1vQNvad24oerrfGlSQN91GkKWt/N3w6AAFBPq83o8FosATj7PvWeVYoKgArVnW1H2 7Zlf7DxnfFGBry1CKGb++k/Zqb6g50NJSJGYVBYfrqIN0YVNLaFB6Vcsx/8YtjqJwF TJCBFp2I3+BN8sbsr0UgQBJx4TgpDE9c24fEbISY7lAZ9+q+LAzb98XPxzRTsSqPBU 5u5XWd4zmadag== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EnG5b2_gPTFG; Wed, 24 Jan 2024 05:58:27 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp3.osuosl.org (Postfix) with ESMTP id 2D4FC61467; Wed, 24 Jan 2024 05:58:27 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 2D4FC61467 X-Original-To: intel-wired-lan@lists.osuosl.org Delivered-To: intel-wired-lan@lists.osuosl.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 55FB01BF25B for ; Wed, 24 Jan 2024 05:58:26 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 344E0408BC for ; Wed, 24 Jan 2024 05:58:26 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 344E0408BC X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ms3c2mAUJaqm for ; Wed, 24 Jan 2024 05:58:25 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.13]) by smtp2.osuosl.org (Postfix) with ESMTPS id 0E4B5408AF for ; Wed, 24 Jan 2024 05:58:24 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 0E4B5408AF X-IronPort-AV: E=McAfee;i="6600,9927,10962"; a="8861862" X-IronPort-AV: E=Sophos;i="6.05,216,1701158400"; d="scan'208";a="8861862" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jan 2024 21:57:08 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10962"; a="856575053" X-IronPort-AV: E=Sophos;i="6.05,216,1701158400"; d="scan'208";a="856575053" Received: from ccdlinuxdev11.iil.intel.com ([143.185.160.232]) by fmsmga004.fm.intel.com with ESMTP; 23 Jan 2024 21:57:04 -0800 From: Sasha Neftin To: intel-wired-lan@lists.osuosl.org Date: Wed, 24 Jan 2024 07:57:00 +0200 Message-Id: <20240124055700.818996-1-sasha.neftin@intel.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1706075905; x=1737611905; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=yo0Csj7FCAFT3zwYQITzeiO7RHAHEdhTFNnmRPv07C8=; b=Iwv4zPtxwwTuzdP0oRVbMVQ90qwAX8wegLkjKvA7Y/meLViw682k2W4m hhUo5GuHGJUHB6h5GCZSTLVBR12aFDCQaGfGNgRfbBuoFtaM3mksFZ47f d9A7F9LgGEpi26pyHZrw1Kb22Uxh0iQ9gSn3uoO0USUt6PsqDrjC3mc9W 7esj7A9D5I4GBu6zudO7m9QU0q7Dpy8VOCNr7S9eaKpQxkXOBUHuHCTrB CiZJoI6kE/SXpyO7HENiW1daZ4J/rC4xCNk6N/ZHScG6shuK4HAE92Ck7 XmjAcLw/cZhWDN+TIzcuymlhmjqWnUlxBJv72RuDLx6zWIjMiSoUWafRg g==; X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=Iwv4zPtx Subject: [Intel-wired-lan] [PATCH iwl-net v1 1/1] igc: Remove temporary workaround X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sasha Neftin Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" PHY_CONTROL register works as defined in the IEEE 802.3 specification. (IEEE 802.3-2008 22.2.4.1). Tide up the temporary workaround. Fixes: 5586838fe9ce ("igc: Add code for PHY support") Signed-off-by: Sasha Neftin Reviewed-by: Paul Menzel Tested-by: Naama Meir --- drivers/net/ethernet/intel/igc/igc_phy.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/net/ethernet/intel/igc/igc_phy.c b/drivers/net/ethernet/intel/igc/igc_phy.c index 7cd8716d2ffa..861f37076861 100644 --- a/drivers/net/ethernet/intel/igc/igc_phy.c +++ b/drivers/net/ethernet/intel/igc/igc_phy.c @@ -130,11 +130,7 @@ void igc_power_down_phy_copper(struct igc_hw *hw) /* The PHY will retain its settings across a power down/up cycle */ hw->phy.ops.read_reg(hw, PHY_CONTROL, &mii_reg); mii_reg |= MII_CR_POWER_DOWN; - - /* Temporary workaround - should be removed when PHY will implement - * IEEE registers as properly - */ - /* hw->phy.ops.write_reg(hw, PHY_CONTROL, mii_reg);*/ + hw->phy.ops.write_reg(hw, PHY_CONTROL, mii_reg); usleep_range(1000, 2000); }