| Message ID | 20230907150251.224931-2-poros@redhat.com |
|---|---|
| State | Accepted |
| Delegated to: | Anthony Nguyen |
| Headers | show |
| Series | [net,v2,1/2] iavf: add iavf_schedule_aq_request() helper | expand |
On Thu, Sep 07, 2023 at 05:02:51PM +0200, Petr Oros wrote: > When the iavf driver wants to reconfigure the VLAN filters > (iavf_add_vlan, iavf_del_vlan), it sets a flag in > aq_required: > adapter->aq_required |= IAVF_FLAG_AQ_ADD_VLAN_FILTER; > or: > adapter->aq_required |= IAVF_FLAG_AQ_DEL_VLAN_FILTER; > > This is later processed by the watchdog_task, but it runs periodically > every 2 seconds, so it can be a long time before it processes the request. > > In the worst case, the interface is unable to receive traffic for more > than 2 seconds for no objective reason. > > Signed-off-by: Petr Oros <poros@redhat.com> > Co-developed-by: Michal Schmidt <mschmidt@redhat.com> > Signed-off-by: Michal Schmidt <mschmidt@redhat.com> > Co-developed-by: Ivan Vecera <ivecera@redhat.com> > Signed-off-by: Ivan Vecera <ivecera@redhat.com> > Reviewed-by: Ahmed Zaki <ahmed.zaki@intel.com> Reviewed-by: Simon Horman <horms@kernel.org>
On 9/7/2023 8:02 AM, Petr Oros wrote: > When the iavf driver wants to reconfigure the VLAN filters > (iavf_add_vlan, iavf_del_vlan), it sets a flag in > aq_required: > adapter->aq_required |= IAVF_FLAG_AQ_ADD_VLAN_FILTER; > or: > adapter->aq_required |= IAVF_FLAG_AQ_DEL_VLAN_FILTER; > > This is later processed by the watchdog_task, but it runs periodically > every 2 seconds, so it can be a long time before it processes the request. > > In the worst case, the interface is unable to receive traffic for more > than 2 seconds for no objective reason. > Changes look ok, however, can you supply or add a Fixes:? > Signed-off-by: Petr Oros <poros@redhat.com> > Co-developed-by: Michal Schmidt <mschmidt@redhat.com> > Signed-off-by: Michal Schmidt <mschmidt@redhat.com> > Co-developed-by: Ivan Vecera <ivecera@redhat.com> > Signed-off-by: Ivan Vecera <ivecera@redhat.com> > Reviewed-by: Ahmed Zaki <ahmed.zaki@intel.com> > --- > drivers/net/ethernet/intel/iavf/iavf_main.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c b/drivers/net/ethernet/intel/iavf/iavf_main.c > index 86d472dfdbc10c..d9f8ac1d57fd62 100644 > --- a/drivers/net/ethernet/intel/iavf/iavf_main.c > +++ b/drivers/net/ethernet/intel/iavf/iavf_main.c > @@ -821,7 +821,7 @@ iavf_vlan_filter *iavf_add_vlan(struct iavf_adapter *adapter, > list_add_tail(&f->list, &adapter->vlan_filter_list); > f->state = IAVF_VLAN_ADD; > adapter->num_vlan_filters++; > - adapter->aq_required |= IAVF_FLAG_AQ_ADD_VLAN_FILTER; > + iavf_schedule_aq_request(adapter, IAVF_FLAG_AQ_ADD_VLAN_FILTER); > } > > clearout: > @@ -843,7 +843,7 @@ static void iavf_del_vlan(struct iavf_adapter *adapter, struct iavf_vlan vlan) > f = iavf_find_vlan(adapter, vlan); > if (f) { > f->state = IAVF_VLAN_REMOVE; > - adapter->aq_required |= IAVF_FLAG_AQ_DEL_VLAN_FILTER; > + iavf_schedule_aq_request(adapter, IAVF_FLAG_AQ_DEL_VLAN_FILTER); > } > > spin_unlock_bh(&adapter->mac_vlan_list_lock);
> -----Original Message----- > From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of > Tony Nguyen > Sent: Friday, September 8, 2023 10:11 PM > To: poros <poros@redhat.com>; netdev@vger.kernel.org > Cc: ivecera <ivecera@redhat.com>; Brandeburg, Jesse > <jesse.brandeburg@intel.com>; linux-kernel@vger.kernel.org; > edumazet@google.com; intel-wired-lan@lists.osuosl.org; horms@kernel.org; > kuba@kernel.org; pabeni@redhat.com; davem@davemloft.net > Subject: Re: [Intel-wired-lan] [PATCH net v2 2/2] iavf: schedule a request > immediately after add/delete vlan > > > > On 9/7/2023 8:02 AM, Petr Oros wrote: > > When the iavf driver wants to reconfigure the VLAN filters > > (iavf_add_vlan, iavf_del_vlan), it sets a flag in > > aq_required: > > adapter->aq_required |= IAVF_FLAG_AQ_ADD_VLAN_FILTER; > > or: > > adapter->aq_required |= IAVF_FLAG_AQ_DEL_VLAN_FILTER; > > > > This is later processed by the watchdog_task, but it runs periodically > > every 2 seconds, so it can be a long time before it processes the request. > > > > In the worst case, the interface is unable to receive traffic for more > > than 2 seconds for no objective reason. > > > > Changes look ok, however, can you supply or add a Fixes:? > > > Signed-off-by: Petr Oros <poros@redhat.com> > > Co-developed-by: Michal Schmidt <mschmidt@redhat.com> > > Signed-off-by: Michal Schmidt <mschmidt@redhat.com> > > Co-developed-by: Ivan Vecera <ivecera@redhat.com> > > Signed-off-by: Ivan Vecera <ivecera@redhat.com> > > Reviewed-by: Ahmed Zaki <ahmed.zaki@intel.com> > > --- > > drivers/net/ethernet/intel/iavf/iavf_main.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c > > b/drivers/net/ethernet/intel/iavf/iavf_main.c > > index 86d472dfdbc10c..d9f8ac1d57fd62 100644 > > --- a/drivers/net/ethernet/intel/iavf/iavf_main.c > > +++ b/drivers/net/ethernet/intel/iavf/iavf_main.c > > @@ -821,7 +821,7 @@ iavf_vlan_filter *iavf_add_vlan(struct iavf_adapter Tested-by: Rafal Romanowski <rafal.romanowski@intel.com>
diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c b/drivers/net/ethernet/intel/iavf/iavf_main.c index 86d472dfdbc10c..d9f8ac1d57fd62 100644 --- a/drivers/net/ethernet/intel/iavf/iavf_main.c +++ b/drivers/net/ethernet/intel/iavf/iavf_main.c @@ -821,7 +821,7 @@ iavf_vlan_filter *iavf_add_vlan(struct iavf_adapter *adapter, list_add_tail(&f->list, &adapter->vlan_filter_list); f->state = IAVF_VLAN_ADD; adapter->num_vlan_filters++; - adapter->aq_required |= IAVF_FLAG_AQ_ADD_VLAN_FILTER; + iavf_schedule_aq_request(adapter, IAVF_FLAG_AQ_ADD_VLAN_FILTER); } clearout: @@ -843,7 +843,7 @@ static void iavf_del_vlan(struct iavf_adapter *adapter, struct iavf_vlan vlan) f = iavf_find_vlan(adapter, vlan); if (f) { f->state = IAVF_VLAN_REMOVE; - adapter->aq_required |= IAVF_FLAG_AQ_DEL_VLAN_FILTER; + iavf_schedule_aq_request(adapter, IAVF_FLAG_AQ_DEL_VLAN_FILTER); } spin_unlock_bh(&adapter->mac_vlan_list_lock);