| Message ID | 20230803023758.3916368-1-sasha.neftin@intel.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [iwl-net,v2,1/1] igc: Fix the typo in the PTM Control macro | expand |
On 8/2/2023 7:37 PM, Sasha Neftin wrote: > The IGC_PTM_CTRL_SHRT_CYC defines the time between two consecutive PTM > requests. The bit resolution of this field is six bits. That bit five was > missing in the mask. This patch comes to correct the typo in the > IGC_PTM_CTRL_SHRT_CYC macro. This doesn't apply > Fixes: a90ec8483732 ("igc: Add support for PTP getcrosststamp()") > Signed-off-by: Sasha Neftin <sasha.neftin@intel.com> > --- > v1->v2: Fixed commit message > --- > drivers/net/ethernet/intel/igc/igc_defines.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/intel/igc/igc_defines.h b/drivers/net/ethernet/intel/igc/igc_defines.h > index c3722f524ea7..0bac6eeb42c0 100644 > --- a/drivers/net/ethernet/intel/igc/igc_defines.h > +++ b/drivers/net/ethernet/intel/igc/igc_defines.h > @@ -546,7 +546,7 @@ > #define IGC_PTM_CTRL_START_NOW BIT(29) /* Start PTM Now */ > #define IGC_PTM_CTRL_EN BIT(30) /* Enable PTM */ > #define IGC_PTM_CTRL_TRIG BIT(31) /* PTM Cycle trigger */ > -#define IGC_PTM_CTRL_SHRT_CYC(usec) (((usec) & 0x2f) << 2) > +#define IGC_PTM_CTRL_SHRT_CYC(usec) (((usec) & 0x3f) << 2) > #define IGC_PTM_CTRL_PTM_TO(usec) (((usec) & 0xff) << 8) > > #define IGC_PTM_SHORT_CYC_DEFAULT 1 /* Default short cycle interval */
diff --git a/drivers/net/ethernet/intel/igc/igc_defines.h b/drivers/net/ethernet/intel/igc/igc_defines.h index c3722f524ea7..0bac6eeb42c0 100644 --- a/drivers/net/ethernet/intel/igc/igc_defines.h +++ b/drivers/net/ethernet/intel/igc/igc_defines.h @@ -546,7 +546,7 @@ #define IGC_PTM_CTRL_START_NOW BIT(29) /* Start PTM Now */ #define IGC_PTM_CTRL_EN BIT(30) /* Enable PTM */ #define IGC_PTM_CTRL_TRIG BIT(31) /* PTM Cycle trigger */ -#define IGC_PTM_CTRL_SHRT_CYC(usec) (((usec) & 0x2f) << 2) +#define IGC_PTM_CTRL_SHRT_CYC(usec) (((usec) & 0x3f) << 2) #define IGC_PTM_CTRL_PTM_TO(usec) (((usec) & 0xff) << 8) #define IGC_PTM_SHORT_CYC_DEFAULT 1 /* Default short cycle interval */
The IGC_PTM_CTRL_SHRT_CYC defines the time between two consecutive PTM requests. The bit resolution of this field is six bits. That bit five was missing in the mask. This patch comes to correct the typo in the IGC_PTM_CTRL_SHRT_CYC macro. Fixes: a90ec8483732 ("igc: Add support for PTP getcrosststamp()") Signed-off-by: Sasha Neftin <sasha.neftin@intel.com> --- v1->v2: Fixed commit message --- drivers/net/ethernet/intel/igc/igc_defines.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)