From patchwork Thu Jul 20 03:48:35 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sasha Neftin X-Patchwork-Id: 1810222 X-Patchwork-Delegate: anthony.l.nguyen@intel.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org (client-ip=2605:bc80:3010::133; helo=smtp2.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256 header.s=default header.b=ANktsy0l; dkim-atps=neutral Received: from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4R5zNY4BnHz1yXp for ; Thu, 20 Jul 2023 13:55:07 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 21CDB400D2; Thu, 20 Jul 2023 03:55:05 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 21CDB400D2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1689825305; bh=HKxgu9jVeAaFSMqCtAmhlTmbtqUTh1i9/rJTRrUZVws=; h=From:To:Date:Subject:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From; b=ANktsy0l8vQHyx4BeAssXRWSiw/H3kCBR//E0qYy2enF1sgYaqqtcdWl/Dip/MCLv luZ1m/UHVy87sEmnXlaW1Rf6nHvXerwWlkVO1ffrnIwPEXBW74S5aeuMmGP+PzVfkl MoFRs8ZP2rIdLKaAAvp7iKI2CQveXtNcJ2I7+oFFKR2VFhALZ+g8ZXxnlREF5sNTqq lSK4xPnJs3bar1zBKQVZg2Y0sGbCNPddKsCDT9G0XeEuOlBLEa4q2Lr1QuxD34H+Jm WJ52LgH53f5jznro6rThyejG1/N6cEmoE9Tmkz5gxeJ99uIbYPVFifHxMFBSLy7YqS ZNDddUcTCgBGg== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id n7irnCL8ya7E; Thu, 20 Jul 2023 03:55:04 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp2.osuosl.org (Postfix) with ESMTP id 44BB3401DD; Thu, 20 Jul 2023 03:55:04 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 44BB3401DD X-Original-To: intel-wired-lan@lists.osuosl.org Delivered-To: intel-wired-lan@lists.osuosl.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id C204B1BF955 for ; Thu, 20 Jul 2023 03:55:02 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 903F44174E for ; Thu, 20 Jul 2023 03:55:02 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 903F44174E X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fXTA9dCO2v-O for ; Thu, 20 Jul 2023 03:55:01 +0000 (UTC) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by smtp4.osuosl.org (Postfix) with ESMTPS id BECDD41743 for ; Thu, 20 Jul 2023 03:55:00 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org BECDD41743 X-IronPort-AV: E=McAfee;i="6600,9927,10776"; a="369278841" X-IronPort-AV: E=Sophos;i="6.01,216,1684825200"; d="scan'208";a="369278841" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jul 2023 20:54:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10776"; a="759410562" X-IronPort-AV: E=Sophos;i="6.01,216,1684825200"; d="scan'208";a="759410562" Received: from ccdrpls178.iil.intel.com ([143.185.160.206]) by orsmga001.jf.intel.com with ESMTP; 19 Jul 2023 20:54:58 -0700 From: Sasha Neftin To: intel-wired-lan@lists.osuosl.org Date: Thu, 20 Jul 2023 06:48:35 +0300 Message-Id: <20230720034835.88372-1-sasha.neftin@intel.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1689825300; x=1721361300; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=Tl1Ffxj80CVsJmaHiXdvTFIXBCOvuw2V8fyOucFakHU=; b=NEhu997liNScqVf5Tor+LlUGNCemYXz15eGgotfJOOOFKRGNCwzMvE5G GaVV1qaveHjK/O+MR5whUvIlZJqvtB+eOtJpLXilTxLtydJtIpOCIk401 A8QJiMrUNQO239Xlmzhz4QT6OlFJgnzHL8/6hYIqOjgqeT1SfKCH1PlSB 9oNKiHkgeyl3aqn8OgcfzJfJXoWNd3hOgPxmYNLI5wGRht+SytHfEWRbb QkKyC+uP8tmrA61mEVWwebBIJXrAC7FKXN2UQYhis7Yo+O0GYBNuoSD88 t3i3QbZ/ywVO29KXuH3lcs8aEt0g84WogqBOeIU19NKfzcweaPEPeW/mV w==; X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=NEhu997l Subject: [Intel-wired-lan] [PATCH iwl-next v2 1/1] igc: Decrease PTM short interval from 10 us to 1 us X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" With the 10us interval, we were seeing PTM transactions take around 12us. Hardware team suggested this interval could be lowered to 1us which was confirmed with PCIe sniffer. With the 1us interval, PTM dialogs took around 2us. Suggested-by: Vinicius Costa Gomes Signed-off-by: Sasha Neftin Tested-by: Muhammad Husaini Zulkifli Reviewed-by: Muhammad Husaini Zulkifli Tested-by: Naama Meir --- v1->v2: Fixed commit message --- drivers/net/ethernet/intel/igc/igc_defines.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/igc/igc_defines.h b/drivers/net/ethernet/intel/igc/igc_defines.h index 44a507029946..c3722f524ea7 100644 --- a/drivers/net/ethernet/intel/igc/igc_defines.h +++ b/drivers/net/ethernet/intel/igc/igc_defines.h @@ -549,7 +549,7 @@ #define IGC_PTM_CTRL_SHRT_CYC(usec) (((usec) & 0x2f) << 2) #define IGC_PTM_CTRL_PTM_TO(usec) (((usec) & 0xff) << 8) -#define IGC_PTM_SHORT_CYC_DEFAULT 10 /* Default Short/interrupted cycle interval */ +#define IGC_PTM_SHORT_CYC_DEFAULT 1 /* Default short cycle interval */ #define IGC_PTM_CYC_TIME_DEFAULT 5 /* Default PTM cycle time */ #define IGC_PTM_TIMEOUT_DEFAULT 255 /* Default timeout for PTM errors */