From patchwork Mon Jul 17 17:19:27 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sasha Neftin X-Patchwork-Id: 1808832 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org (client-ip=2605:bc80:3010::136; helo=smtp3.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256 header.s=default header.b=c++JuZ+Z; dkim-atps=neutral Received: from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4R4TWN0Cj1z20Cs for ; Tue, 18 Jul 2023 03:25:51 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 9AA3360D9D; Mon, 17 Jul 2023 17:25:49 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 9AA3360D9D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1689614749; bh=zKY2yFsNu0FcoHtRa43rBibVPvD9vfCUr/P7HeCCePs=; h=From:To:Date:Subject:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From; b=c++JuZ+Zg5Pi368V5Tw5vAcPp7AaywIGsHwuZibs8DOA7ISzs7pVUIKzxiG9gP767 108PGRtHg2+qHPPFdYaSPquEJsapbTP+zCNyKK7cG42JuA+P2ctVw2kvaIECwTkooW KeVgYFrZNMEKLftA+DF2kzsYWEsWHn0EY0e/TrfqhPNIpBwphYmj28KToLs8igFts3 1F6E/XTOyw2IcGhjBLoQaoCD4jSq++RpfA4jNPJ23JprHOBPRnebc/s/s4vJX7UkGI afzTmEKtXg+rpNhdLK6AdTP5amDcGRBQpucfsDoWMEJEpACi3pHFkS0SkvtsW5QT9v v1MsPvVOSpBzA== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RUxQFeZLnvlx; Mon, 17 Jul 2023 17:25:48 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp3.osuosl.org (Postfix) with ESMTP id B12A760AE9; Mon, 17 Jul 2023 17:25:48 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org B12A760AE9 X-Original-To: intel-wired-lan@lists.osuosl.org Delivered-To: intel-wired-lan@lists.osuosl.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id F14881BF337 for ; Mon, 17 Jul 2023 17:25:46 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id C7AB340890 for ; Mon, 17 Jul 2023 17:25:46 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org C7AB340890 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tnLw7wK_kLWj for ; Mon, 17 Jul 2023 17:25:43 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 8C7A94088D Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by smtp4.osuosl.org (Postfix) with ESMTPS id 8C7A94088D for ; Mon, 17 Jul 2023 17:25:42 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6600,9927,10774"; a="429751995" X-IronPort-AV: E=Sophos;i="6.01,211,1684825200"; d="scan'208";a="429751995" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jul 2023 10:25:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10774"; a="1053964747" X-IronPort-AV: E=Sophos;i="6.01,211,1684825200"; d="scan'208";a="1053964747" Received: from ccdrpls178.iil.intel.com ([143.185.160.206]) by fmsmga005.fm.intel.com with ESMTP; 17 Jul 2023 10:25:40 -0700 From: Sasha Neftin To: intel-wired-lan@lists.osuosl.org Date: Mon, 17 Jul 2023 20:19:27 +0300 Message-Id: <20230717171927.78516-1-sasha.neftin@intel.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1689614743; x=1721150743; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=qhxeABDlLdiU/YHSPDBEl14JunV1EbgLY4i1toM7i9k=; b=EbyYqXOQwPJ6Dp5ouLketYpI61cc8ykUKS9KYsYFJ2wXEmeeYDCt2Ss9 tdBb3izhsfikyoFb71ybJeqpwo70ovFGAEqLbe/6mX0TMBXxlBCSqKGrf hXR67kBcnHOwestViuR1akb77ET/cgdmswZaiK69tzihN9UaJZ0jb03Mc qHfnzBEozt8qP3oy69/7OBhg9SW98tymd7Gsthq544BfTVKOiJ4jBMKPl B2AdjGfmgoti7kLEJj/Y2//J+7HrR4bTxC/on1w74v3Hoq/4N4Px3Jdpr ZV0oyhj6AYnnqSQbRSu1j4ZSQOH6KS7GEoHRlLNz2NaVhxOYTC/sRkohv g==; X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=EbyYqXOQ Subject: [Intel-wired-lan] [PATCH iwl-net v1 1/1] igc: Correct the short interval between PTM requests. X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" With the 10us interval, we were seeing PTM transactions taking around 12us. With the 1us interval, PTM dialogs took around 2us. Checked with the PCIe sniffer. Fixes: a90ec8483732 ("igc: Add support for PTP getcrosststamp()") Suggested-by: Vinicius Costa Gomes Signed-off-by: Sasha Neftin --- drivers/net/ethernet/intel/igc/igc_defines.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/igc/igc_defines.h b/drivers/net/ethernet/intel/igc/igc_defines.h index 44a507029946..c3722f524ea7 100644 --- a/drivers/net/ethernet/intel/igc/igc_defines.h +++ b/drivers/net/ethernet/intel/igc/igc_defines.h @@ -549,7 +549,7 @@ #define IGC_PTM_CTRL_SHRT_CYC(usec) (((usec) & 0x2f) << 2) #define IGC_PTM_CTRL_PTM_TO(usec) (((usec) & 0xff) << 8) -#define IGC_PTM_SHORT_CYC_DEFAULT 10 /* Default Short/interrupted cycle interval */ +#define IGC_PTM_SHORT_CYC_DEFAULT 1 /* Default short cycle interval */ #define IGC_PTM_CYC_TIME_DEFAULT 5 /* Default PTM cycle time */ #define IGC_PTM_TIMEOUT_DEFAULT 255 /* Default timeout for PTM errors */